[RESOLVED] tired code....???

AlGale

Can anyone help?

I have two web sites that have content managements systems, courtesy of standard log in code and simple PHP code such as:

$result = mysql_query("insert into Admin values
('$Username','$Pass', '$Email')");

if (!$result)
return "Could not register you in database - please try again later.";

return true;
}

For YEARS, this has worked. SUDDENLY, it has stopped working. (It enters a completely BLANK entry into all 3 fields of table Admin - and before you point it out, I did used to encode the password, but I stipped that out to eliminate THAT from the enquirey!). The NEXT time you try, with ANY username, it says that one is already taken, because it tries to add another blank field....

I am 10000% convinced my host (www.web-mania.com) has done something to their servers, but they emphatically deny it.

....so... am I going mad? DOES code get tired and stop working? Or COULD they have upgraded something that has had such an effect on BOTH of my sites??

Many thanks guys.

sneakyimp

it would be helpful for you to post more of your code. if you stripped out the encoding line, try putting it back. otherwise, we are not going to be able to help you without seeing more code.

AlGale

Both WITH and WITHOUT the encoding, a blank entry gets placed into the database.

This code fails EVERY time, with and without a valid email address being entered:

function valid_email($address)

{

// check an email address is possibly valid

if (ereg("^{[a-zA-Z0-9_.-]+@[a-zA-Z0-9-]+.[a-zA-Z0-9-.]+$",} $address))

return true;

else

return false;

}

Both pieces of code used to work.... I populated all the tables via the web site... now I cannot.

Thanks.....

etully

Put in a line of code that emails the query to yourself. Or print the query on the screen and test the registration yourself. I bet the fields have no values because someone turned off register globals.

etully

As a quick fix. try putting this line of code at the top of your script:

foreach ($_REQUEST as $k=>$v) { $$k = $v; }

That will simulate what register globals used to do for you. Oh, and then switch hosting services because nobody should have to tolerate a host who changes configs without warning people AND THEN LIES ABOUT IT.

AlGale

??? Er... how do I do that?? I understand about the registe globals, but have no idea how to email myself the code or print the query...

etully

Put this line:
print "insert into Admin values ('$Username','$Pass', '$Email')";
Right before this line:
$result = mysql_query("insert into Admin values ('$Username','$Pass', '$Email')");

This way you can see what your query is trying to do. "Print" is by far the most useful troubleshooting tool that exists in any programming language.

AlGale

Wow..... thanks for that.

OK, I get:

insert into Admin values ('','', '')

So how come nothing is being passed from the form any more??? The form action is POST. On the resulting page I do not use GET at all.... never had to before... Could that be anything to do with it??

etully

Because someone turned register globals off. See my post 4 posts up from this one.

Levatio

Register globals has been turned off. You'll have to refer to them through the post superglobal, which is easily done - just follow the example below:

$username = $_POST['username'];
$pass = $_POST['pass'];
$email = $_POST['email'];

AlGale

The hosts must have done that.... I don`t think I have any control over that.... is there any way I can overome it with some added code?

Thanks for all this.... the hosts have been SO unhelpful, trying to say the code had NEVER worked.....

etully

Yes, you can overcome it by using Levatio's code or see my post 3 posts up from this one.

AlGale

Sorry guys.... missed that post.

But it works!! Thanks a million.... Honestly!!! Excellent. Cheers.