Calling parameter from another function

[kilbey1]

I want to use a parameter from a separate function, like so:

include("error.php");			 
include("fnc_uploadImages.php");

//uploadImages = ($imagesTable, $pathImages, $logfile==FALSE)
$fncupload = uploadImages("images","../images/listings","uploadImages.txt");

if($fncupload === TRUE) {
	echo "OK";
} else {
	echo "NOT OK!";
       senderroremail();
}

Where $logfile (in this case, uploadImages.txt) gets sent in an error e-mail via senderroremail().

function uploadImages, contained in fnc_uploadImages.php, declares the following as global:
global $db, $logdir, $logfile, $log, $time, $to, $subject, $msg, $headers;

While senderroremail(), contained in error.php, has the following:
$logdir = "../logs/"; // outside of function in error.php
global $logdir, $logfile, $time;
$log = $logdir . $logfile;

If I echo $log, $logdir is always output, but not $logfile.

How can I reuse the $logfile portion from function uploadImages?

[Installer]

Using "global" imports variables from the global scope, not from other functions (hence the name). To put it in the global scope (and to possibly aid future maintenance and repair) you could do this:

$logfile = 'uploadImages.txt';
$fncupload = uploadImages("images","../images/listings",$logfile);

[kilbey1]

Sorry for this question; please bear with me! Should I do this even if $logfile is going to be different every time? I'd really like to use what the user has already input into the third parameter as their designated logfile. Then, when an error e-mail is required to be sent out, use the designated logfile as an attachment.

Because I hope to take the error checking further, so the below code would look like:

$fncupload = uploadImages("images","../images/listings","uploadImages.txt"); 
$someotherfunction = someOtherFunction("param1","param2","somefile.txt");

if($fncupload === TRUE) {
	echo "OK";
   if($someotherfunction === TRUE) {
   	echo "OK";
   } else {
   	echo "NOT OK!";
   	senderroremail();
   }
} else {
	echo "NOT OK!";
	senderroremail();
}

I want to ensure everything runs; if it doesn't, stop at that point in the process. (echo OK/NOT OK is meant for testing; other code would be input here)

Perhaps func_num_args, func_get_args, func_get_arg, or call_user_func?

[Installer]

I used "$logfile = 'uploadImages.txt';" only to illustrate. You can, of course, assign anything to "$logfile" that you want. For example, if the filename comes from a posted form, you can use something like "$logfile = $_POST['designated_file'];". Check the input for security, of course. Or, you can always change "senderroremail()" so that it takes one or more arguments and pass the name to it. That would also restore the function's flexibility that you lose by using "global".

[kilbey1]

Ok, if I want argument 2 to act as my variable and get passed to senderroremail() (which I think it what you suggested), then here's what I tried.

Let's assume I change function senderroremail() to function senderroremail($logfile=FALSE). A $logfile may or may not be present in function uploadImages (function uploadImages($imagesTable, $pathImages, $logfile=FALSE)).

So when I try

$fncupload = uploadImages("images","../images/listings","uploadImages.txt");
if($fncupload === TRUE) {
	echo "OK";
	senderroremail($logfile);
} else {
	echo "NOT OK!";
}

...$logfile is not picked from $fncupload. $logfile in senderroremail() should be picking up "uploadImages.txt", and passing it back to senderroremail().

I have also tried to do $logfile = func_get_arg(2); from within senderroremail(), and this doesn't work either. Additionally, I have tried echo it out from within the if statement - but nothing echoes out.

I'm guessing it's possible to do what I want, but don't know how. Thanks for your help; I truly do appreciate it.

[tsinka]

What about this ?

$logfile = "uploadImages.txt";
$fncupload = uploadImages("images","../images/listings",$logfile);
if($fncupload === TRUE) {
    echo "OK";
    senderroremail($logfile);
} else {
    echo "NOT OK!";
} 

Thomas

[Installer]

That looks just like what I suggested. Maybe you'll have better luck. 🙂

Kilbey1 -
You shouldn't need "func_get_arg()", but even if you did, why "func_get_arg(2)" in a function that takes only one argument?

[kilbey1]

Declaring the $logfile variable does work, but isn't this taking an extra step that could be eliminated?

//function uploadImages($imagesTable, $pathImages, $logfile=FALSE) (may or may not have a log)
$logfile = "uploadImages.txt";
$logfile2 = "someotherlogfile.txt";
$logfile3 = "yetanotherlogfile.txt";
$fncupload = uploadImages("images","../images/listings",$logfile);
$fncsomethingelse = someFunction("table","../path/to/directory",$logfile2);
$fncsomethingelseagain = someOtherFunction("table","../path/to/directory",$logfile3);

if($fncupload === TRUE) {
	echo "OK";
    if($fncsomethingelse === TRUE) {
		echo "OK";
       		if($fncsomethingelseagain === TRUE) {
				echo "OK";
			} else {
				echo "NOT OK!";
       			senderroremail();
			}
		} else {
			echo "NOT OK!";
       		senderroremail();
		}
} else {
	echo "NOT OK!";
       senderroremail();
}

For that matter, I could put all arguments into a variable. But is there no way I can just reuse the third argument in each function as necessary, so that the end result would be more like the following? Or should I really rethink my entire approach to this?

$fncupload = uploadImages("images","../images/listings","uploadImages.txt");
$fncsomethingelse = someFunction("table","../path/to/directory","someotherlogfile.txt");
$fncsomethingelseagain = someOtherFunction("table","../path/to/directory","yetanotherlogfile.txt");

if($fncupload === TRUE) {
	echo "OK";
    if($fncsomethingelse === TRUE) {
		echo "OK";
       		if($fncsomethingelseagain === TRUE) {
				echo "OK";
			} else {
				echo "NOT OK!";
       			senderroremail();
			}
		} else {
			echo "NOT OK!";
       		senderroremail();
		}
} else {
	echo "NOT OK!";
       senderroremail();
}

[kilbey1]

Actually, I'm going to post all three scripts that are being used in a .zip file. It may be I'm approaching things all wrong.

[tsinka]

Something like this ?

<?PHP

$strLogfile = '';

function myFunc1()
{
    $blnOK = true;

// add code that does something
if ($myActionFailed === true) {
    //write something to log file mylogfile1.txt
    $blnOK = false;
    $GLOBALS['strLogfile'] = 'mylogfile1.txt';
}

return $blnOK;
}

function myFunc2()
{
    $blnOK = true;

// add code that does something

// oops, it failed
$myActionFailed = true;

if ($myActionFailed === true) {
    //write something to log file mylogfile2.txt
    $blnOK = false;
    $GLOBALS['strLogfile'] = 'mylogfile2.txt';
}

return $blnOK;
}

function myFunc3()
{
    $blnOK = true;

// add code that does something
if ($myActionFailed === true) {
    //write something to log file mylogfile3.txt
    $blnOK = false;
    $GLOBALS['strLogfile'] = 'mylogfile3.txt';
}

return $blnOK;
}

function senderroremail()
{
    if (is_file($GLOBALS['strLogfile'])) {
        // send the error mail with the contents of the logfile
        // created by the function that failed
        // $GLOBALS['strLogfile'] contains the filename
        echo "sending mail using logfile: ".$GLOBALS['strLogfile']."<br>\n";
    } else {
        // could not find or access the logfile
        echo "could not find logfile: ".$GLOBALS['strLogfile']."<br>\n";
    }
}

// now the code
$blnOK = true;
if ($blnOK = myFunc1() === true) {
    echo "myFunc1 ok<br>\n";
}

if ($blnOK === true && $blnOK = myFunc2() === true) {
    echo "myFunc2 ok<br>\n";
}

if ($blnOK === true && $blnOK = myFunc3() === true) {
    echo "myFunc3 ok<br>\n";
}

if ($blnOK === false) {
    senderroremail();
}
?>

You wrote that the logfile names change each time. In that case add the logfile name as argument to the functions like you did already (but as variable not as static strings) and then assign the contents of that variable to $GLOBALS['strLogfile'] inside the function. In my example I just set the logfile name inside the function.

I hope that comes closer to what you want to do.

Thomas

[kilbey1]

Thanks for this; a new way of thinking for me.

I can't get this to work properly; I am unable to get it to ever reach OK. Can you poinpoint where this is going wrong? I'll attach the scripts with the changes.

EDIT: Got it to reach OK; but never recognizes $logfile or $GLOBALS['strLogFile'], even if adding GLOBALS['strLogfile'] = func_get_arg(2) to the uploadImages function.

[kilbey1]

I've gotten this to work. However, I fear - from what I've read and heard - that it's bad practice to declare globals at all in a script. 🙁 I'll keep practicing, but for what it's worth, the working scripts are attached here.

While this does seem to work as-is, I'm open to criticism and corrections, because I'm sure I'm violating some rules of good programming here.

---

From the main function, uploadImages, I do the following:

	global $db, $logdir, $time;
	$GLOBALS['strLogFile'] = func_get_arg(2);

While from the calling function, senderroremail(), I do this:

$logfile = $GLOBALS['strLogFile'];

Following the rest of your suggestions, the page that calls all functions (handlerScripts.php) works:

$fncupload = uploadImages("images","../images/listings","uploadImages.txt");

$blnOK = true; 
if ($blnOK = $fncupload === true) { 
    echo "OK<br>\n"; 
    //senderroremail();
} else {
	echo "NOT OK<br>\n";
	senderroremail();
}

[tsinka]

What about calling senderroremail directly from within the functions after an error occurred ? Add an argument to the function senderroemail that contains the logfile name and call that function from within the other functions.

btw: if you have a function that is defined as let's say

function myFunc($param1, $param2, $param3)

then just access the arguments by their variable name inside the function. You don't need to use func_get_arg. func_get_arg is useful if you have a function with a variable number of arguments.

Thomas