some small help

Sk_

I am new to php, anyway im working on a text based game with a friend. So I started out with the basics, we planned out the game and decided how it would work. Then I setup most of the MySQL DB. After that I started working on a script that would add the user info to the db. So far it takes the users name, password and email, checks them for length and characters then is suppose to connect to mysql and check if the username exists already.

Well something goes wrong with the sql part, i know it can connect to the db I have tested that. I think this is a simple php error.

I have highlighted the parts that do the sql stuff that could be problematic, if someone can help me with this it would be much appreciated.

<?php

// db.php by smartkid

function db_connect()
{
// DB Info
$dbhost = '72.29.87.3';
$dbuser = '--------';
$dbpass = '--------';
$dbname = 'megaman_CyberStorm';

// Connects to db or dies
$db = mysql_connect($dbhost, $dbuser, $dbpass)
or die('Error connecting to mysql');

//Selects Our DB
mysql_select_db($dbname);

// gives back $db info to use to disconnect
return($db);

}

function query($query)
{
$result = mysql_query($query);
}

function username_check($user, $result)
{
$query = "SELECT username FROM user_info WHERE username = '$user'";
mysql_query($query);
$result = 2; //mysql_numrows($query);
return($user);
return($result);
}

function db_disconnect()
{
mysql_close();
}

This file should be fine its just a form VVV

<?php
// register.php by Smartkid
?>

<html>
<head>
<title>Register</title>
</head>
<body>
<form action="check.php" method="POST">
<center>
<table border=0 cellspacing=1 cellpadding=0 width=300>
<tr>
<td colspan=2>Welcome to CyberStorm, please fill out the following information and then hit submit to proceed to step 2.<br></td>
</tr>
<tr>
<td align=right>Username:</td>
<td align=left><input type="text" name="user" maxlength="30" value=""></td>
</tr>
<tr>
<td align=right>Password:</td>
<td align=left><input type="password" name="pass" maxlength="30" value=""></td>
</tr>
<tr>
<td align=right>Email:</td>
<td align=left><input type="text" name="email" maxlength="50" value=""></td>
</tr>
<tr>
<td colspan=2 align=center><input type="submit" value="Join!"></td>
</tr>
</table>
</body>
</html>

<?php
// check.php by Smartkid

include("include/db.php");

$POST['user'] = $user;
$POST['pass'] = $pass;
$_POST['email'] = $email;

// Check username lenth
if(strlen($user) < 5)
{
echo("Username below 5 characters"); die;
}
//Make sure username is not to long
else if(strlen($user) > 30)
{
echo("Username above 30 characters"); die;
}
// Check if username is not alphanumeric
else if(!eregi("^{([0-9a-z])+$",} $user))
{
echo("Username not alphanumeric"); die;
}
// Password Checking
else if(strlen($pass) < 5)
{
echo("Password below 5 characters"); die;
}
//Password checking
else if(strlen($pass) > 30)
{
echo("Password is over 30 characters"); die;
}
//Check if password is not alphanumeric
else if(!eregi("^{([0-9a-z])+$",} $pass))
{
echo("Password not alphanumeric"); die;
}
// Email Checking
else if(strlen($email) < 5)
{
echo("Email is below 5 characters"); die;
}
//Email checking
else if(strlen($email) > 30)
{
echo("Email is over 30 characters"); die;
}
else
$regex = "^{[+a-z0-9-]+(.[+a-z0-9-]+)"."@[a-z0-9-]+(.[a-z0-9-]{1,})".".([a-z]{2,}){1}$";}
if(!eregi($regex,$email))
{
echo("Email has bad charecters"); die;
}
else
db_connect();
$result = 1;
username_check($user, $result);
db_disconnect();
if ($result > 0)
{
echo("User already exists!".$result);
}
else

echo($result."<center>
<table border=0 cellspacing=1 cellpadding=0 width=300>
<tr><td colspan=2>Please check if this information is correct then hit submit. You cannot change your username or email after this step<br></td></tr>
<tr><td align=right>Username:</td><td align=left><input type=text readonly=true name=user maxlength=30 value=".$user."></td></tr>
<tr><td align=right>Password:</td><td align=left><input type=text readonly=true name=pass maxlength=30 value=".$pass."></td></tr>
<tr><td align=right>Email:</td><td align=left><input type=text readonly=ture name=email maxlength=50 value=".$email."></td></tr>
<tr><td colspan=2 align=center><br><input type=submit value=Submit></td></tr>
</table>");

Thanks so much,
Sk~

Mgccl

function username_check($user, $result)
{
$query = "SELECT username FROM user_info WHERE username = '$user'";
mysql_query($query);
$result = 2; //mysql_numrows($query); 
return($user);
return($result);
}

What is the whole point of this code, you need to assign mysql_query($query); to something... or it is useless...
looks like you might need a lot help on this one...
and function should return one varible, and you should make that variable a array if there are more than 1 values

Sk_

The point is to see if $user defined in check.php exists in the db, it is suppose to set $result to the number of results it found or something like that, the truth is i don't know how to do that so i found another script and tried to gut it... After the function is done check.php looks at $result and if its 0 continues, else yells at the user...

Anyway I dont know much at all about functions and nothing about arrays, im new so please bare with me the rest does work (amazingly), how would I go about correcting this?

Mgccl

well... at least you going to learn what Functions and Arrays are and how to use them, you can go around search them... recommand php.net and google XD
OFFTOPIC:in your privit message... I have asked you to add my MSN for further chats because I'm interested on making text games

konrad

Below is function that checks if user with name $username already exists in db:

function username_check($user)
{
$query = "SELECT username FROM user_info WHERE username = '$user'";
$result = mysql_query($query) or die( $query . ' ' . mysql_error() );
$num_rows = mysql_num_rows( $result );
if( $num_rows ) // $user is in db
 return( false ); 
else
 return( true );
}

Changes in check.php file:

include("include/db.php");

$user = $_POST['user'];
$pass = $_POST['pass'];
$email = $_POST['email'];

// Check username lenth
if(strlen($user) < 5)
{
echo("Username below 5 characters"); die();
}
//Make sure username is not to long
else if(strlen($user) > 30)
{
echo("Username above 30 characters"); die();
}
// Check if username is not alphanumeric
else if(!eregi("^([0-9a-z])+$", $user))
{
echo("Username not alphanumeric"); die();
}
// Password Checking
else if(strlen($pass) < 5)
{
echo("Password below 5 characters"); die();
}
//Password checking
else if(strlen($pass) > 30)
{
echo("Password is over 30 characters"); die();
}
//Check if password is not alphanumeric
else if(!eregi("^([0-9a-z])+$", $pass))
{
echo("Password not alphanumeric"); die();
}
// Email Checking
else if(strlen($email) < 5)
{
echo("Email is below 5 characters"); die();
}
//Email checking
else if(strlen($email) > 30)
{
echo("Email is over 30 characters"); die();
}
else
$regex = "^[_+a-z0-9-]+(\.[_+a-z0-9-]+)*"."@[a-z0-9-]+(\.[a-z0-9-]{1,})*"."\.([a-z]{2,}){1}$";
if(!eregi($regex,$email))
{
echo("Email has bad charecters"); die();
}
else
db_connect();
$is_unique = username_check($user);
db_disconnect();
if ($is_unique === true)
{
echo "
<table border=0 cellspacing=1 cellpadding=0 width=300 align=\"center\">
<tr><td colspan=2>Please check if this information is correct then hit submit. You cannot change your username or email after this step<br></td></tr>
<tr><td align=right>Username:</td><td align=left><input type=text readonly=true name=user maxlength=30 value=".$user."></td></tr>
<tr><td align=right>Password:</td><td align=left><input type=text readonly=true name=pass maxlength=30 value=".$pass."></td></tr>
<tr><td align=right>Email:</td><td align=left><input type=text readonly=ture name=email maxlength=50 value=".$email."></td></tr>
<tr><td colspan=2 align=center><br><input type=submit value=Submit></td></tr>
</table>";
}
else{
echo("User already exists!");
}

I haven't test the scripts, hope it works...

Houdini

What do you want the function to do? first develop a script that actually does what you want it to do then create a script out of it so it can be used in other places if it is a one time thing then there is not much point of making a function at all just write the script to do what the fuction would do. Also when creating a function don't create one that the name of is more than what the function actually does as in this case

function db_disconnect()
{
mysql_close();
}

which is a function with a longer name calling a function, just call the function mysql_close. When postin code on these forums please take advantage of the BB Code capabilities ofthese forums when posting PHP use PHP BB Code, just click the link in my signature about how to use BB Code, it real simple and helps you and others, you code posted as is hurts my eyes and is hard to read.

Sk_

To konrad: thanks so much worked like a charm!

To Houdini: So true hits self on head, gets rid of useless functions

To Mgccl: Thanks so much for helping me on msn, I now understand arrays and functions.

This place is great,
Sk~