[RESOLVED] validating html_quickform if,else if, else

[TJ_IN_AK]

Thank you for reading this!

I'm on the final step for my first HTML_Quickform project. I'm stuck on how to write my validate statement correctly. I believe my code is correct but I'm not setting up the if, else if , else statement correctly because my form is not displaying.

Here is what I have:

if ($form->validate()) {
$db_name = "db";
$table_name = "table";
$connection = mysql_connect("localhost", "username", "passwd") or die(mysql_error());
$db = mysql_select_db($db_name, $connection) or die(mysql_error());
$test_username = mysql_query("SELECT * FROM $table_name WHERE user_name='$data[user_name]'",$connection) or die(mysql_error());
$num_rows = mysql_num_rows($test_username);
if ($num_rows > 0) {
	echo "<p>The username is already taken.  Please go back and try again.</p>";
	} else if ($num_rows == 0) {
$sql = "INSERT INTO user SET rowID=NULL, first_name='$data[first_name]', last_name='$data[last_name]', email='$data[email]', phone='$data[phone_number]', user_name='$data[user_name]', passwd=MD5('$data[passwd]')";
$result = mysql_query($sql,$connection) or die(mysql_error());
$msg = "REGISTRATION FORM SUBMITTED FROM RIDESALASKA.ORG \n \n";
$msg .= "Client Name:\t$data[first_name] $data[last_name]\n";
$msg .= "Client Email:\t$data[email]\n";
$msg .= "Client Phone: " . $data['phone_number']['areacode'] . "-" . $data['phone_number']['exchange'] . "-" . $data['phone_number']['last4']."\n";
$msg .= "Gender:\t\t$data[gender]\n";
$msg .= "Date Of Birth: ".$data['dob']['F']. "-" . $data['dob']['d'] . "-" .$data['dob']['Y'] . "\n";
$msg .= "Maritial Status: $data[marital_status]\n";
$msg .= "Number is Household: $data[num_house]\n \n";
$msg .= "Clients Address: $data[street_add]\n";
$msg .= "City: $data[city]\n";
$msg .= "State: $data[state]\n";
$msg .= "Zip Code: $data[ZIP]\n \n";
$msg .= "Directions to Home:\n$data[directions]\n \n";
$msg .= "Impairments: " . $data['Impairments'] . "\n";
$msg .= "Special Circumstances:\n$data[spec_circumstance]\n \n";
$msg .= "Medicaide: $data[medicade]\n";
$msg .= "DKC: $data[dkc]\n";
$msg .= "Choice Waiver: $data[ch_waiver]\n \n";
$msg .= "Emergency Contact1: $data[contact_name1]\n";
$msg .= "Relationship: $data[relation1]\n";
$msg .= "Emergency Contact: " . $data['contact1_phone']['areacode'] . "-" . $data['contact1_phone']['exchange'] . "-" . $data['contact1_phone']['last4']."\n";
$msg .= "Emergency Contact2: $data[contact_name2]\n";
$msg .= "Relationship: $data[relation2]\n";
$msg .= "Emergency Contact2 Phone:" . $data['contact1_phone']['areacode'] . "-" . $data['contact1_phone']['exchange'] . "-" . $data['contact1_phone']['last4']."\n";
$msg .= "Case Manager?\t$data[case_manager]\n";
$msg .= "Case Manager Name: $data[cm_name]\n";
$msg .= "Case Manager Phone: " . $data['cm_phone']['areacode'] . "-" . $data['cm_phone']['exchange'] . "-" . $data['cm_phone']['last4']."\n";
$to = "[e-mail]";
$subject = "*** PASSENGER REGISTRATION FORM - RIDESALASKA.ORG ***";
$mailheader = "From: CARTS <[e-mail]>\n";
$mailheader .= "Reply-To: $data[email]\n";
mail($to, $subject, $msg, $mailheaders);
} else {
$form->display();
}
}

Please help me understand how I'm messing up. My guess is I'm never getting to the $form->display(); function.

Thank you so much!

Tim

[ednark]

Your code only displays the form IF it has validated and IF your sql statment returns a negative value for rows effected, which shouldn't happen.

It looks like you have this (in pseudocode):

$form = new MyForm();
$data = $form->exportValues();
if ( $form->validate() ) {
  $num_row = findUsernameInDB();
  if ( $num_row > 0 ) {
    /// if username has a row already
    echo "<p>The username is already taken.  Please go back and try again.</p>";
  } else if ($num_rows == 0) {
    /// if username has no row
    insertUserIntoDB();
    mail();
  } else {
    /// if username ... exists in a negative number of rows?!
    $form->display();
  }
} 

When you should have something like this (in pseudocode):

$form = new MyForm();
if ( $form->validate() ) {
  $data = $form->exportValues();
  $num_row = findUsernameInDB();
  if ( $num_row > 0 ) {
    /// username already has a row
    echo "<p>The username is already taken.</p>";
    /// take them directly to the form
    $form->display();
    die();  

  }
  /// username has no row
  insertUserIntoDB();
  mail();
  displaySuccessPage();
  die();
}
/// invalid form or first time to page- show form
$form->display();
die();

Does this make sense?

[TJ_IN_AK]

ednark wrote:

Does this make sense?

Thank you for replying ednark! I had to read it and then read it again but I think it finally sunk in. You actually tipped me off to making the form better for the user by displaying the page again when the username is not unique - Thank You!

Tim