Won't write to file?

[Sesquipedalian]

Any idea why it won't write to the file..?

form.php

<?php
error_reporting(2047); // debug 
	echo "<form id='form1' name='form1' method='post' action='edit.php'>Filename:<br>" 
		. "<input name='filename' type='text' id='filename' value='' />"
		. "<input name='subfilename' type='hidden' id='subfilename' value='1' />"
	   	. "<input type='submit' value='Submit' /></form>";
?>

edit.php

<?php
error_reporting(2047); // debug
$test = new edit;
class edit{
    function edit(){

     if(isset($_POST['subfilename'])){
     $this->form();
     }
     else if(isset($_POST['subeditfile'])){
     $this->editfile();
     } 
 }
function form(){
$filename = $_POST['filename'];
$file=fopen($filename, "r");
$read=fread($file, 900000);
	echo "Editing: <b>" . $filename . "</b><br><br>"
         . "<form id='form1' name='form1' method='post' action='edit.php'>"
		 . "Edit:<br /><textarea name='edit' id='edit'>" . $read . "</textarea>"
         . "<input name='subeditfile' type='hidden' id='subeditfile' value='1' />"
		 . "<input name='filename' type='hidden' id='filename' value='" . $filename . "' />"
		 . "<input type='submit' name='Submit' value='Submit' /></form>"; 
fclose($file);
}
function editfile(){

	$filename = $_POST['filename'];
    $edit = $_POST['edit'];
    $edit_file=fopen($filename, "w+");
    $file_read=fread($edit_file, 90000); 
	chmod($filename, 777);     
        if (!$edit==$file_read && !$file_read==""){
            fwrite($edit_file, $edit) or die ("Error");

        } else if ($file_read==$edit) {
            echo "Success,<br><br>" . $edit . "<br><br>has been written to "
                . $filename;   
        } else if (!$file_read==$edit){
            echo "Error,<br><br>" . $edit . "<br><br>Could not be written to "
                . $filename;
        }
    fclose($edit_file);
    }       
};
?> 

[Houdini]

Could it be because you are telling it to read with fread() and not write with fwrite()?

[Sesquipedalian]

No..

 if (!$edit==$file_read && !$file_read==""){
               fwrite($edit_file, $edit) or die ("Error");

I made a variable to read, but I also told it to write. ;]

[mobtex]

permissions. chmod it so you can write to it and it should be okay in thory.

[Sesquipedalian]

I did.. :/ And I never needed to CHMOD the file before, but I tried it anyways.. See:

$file_read=fread($edit_file, 90000);
chmod($filename, 777);
       if (!$edit==$file_read && !$file_read==""){
            fwrite($edit_file, $edit) or die ("Error");

Right under $file_read=fread($edit_file, 90000);

[Sesquipedalian]

<?php
error_reporting(2047); // debug
$test = new edit;
class edit{
    function edit(){

     if(isset($_POST['subfilename'])){
     $this->form();
     }
     else if(isset($_POST['subeditfile'])){
     $this->editfile();
     } 
 }
function form(){
$filename = $_POST['filename'];
$file=fopen($filename, "r");
$read=fread($file, 900000);
	echo "Editing: <b>" . $filename . "</b><br><br>"
         . "<form id='form1' name='form1' method='post' action='edit.php'>"
		 . "Edit:<br /><textarea name='edit' id='edit'>" . $read . "</textarea>"
         . "<input name='subeditfile' type='hidden' id='subeditfile' value='1' />"
		 . "<input name='filename' type='hidden' id='filename' value='" . $filename . "' />"
		 . "<input type='submit' name='Submit' value='Submit' /></form>"; 
fclose($file);
}
function editfile(){
	$filename = $_POST['filename'];
    $string_edit = $_POST['edit'];
	$open_read=fopen($filename, "r");
	$file_read=fread($open_read, filesize($filename)); 
    $open_edit=fopen($filename, "w");

	chmod($filename, 777);     
        if (!$string_edit==$file_read && !$file_read==""){
            fwrite($open_edit, $string_edit);			
        } else if ($file_read==$string_edit) {
            echo "Success,<br><br>" . $string_edit . "<br><br>has been written to "
                . $filename;   
        } else if (!$file_read==$string_edit){
            echo "Error,<br><br>" . $string_edit . "<br><br>Could not be written to "
                . $filename;
        }
    fclose($open_edit);
    }       
};
?> 

[Kudose]

I changed up a few things ... try this (it is untested):

<?php
error_reporting(2047); // debug
$test = new edit;
class edit {
    var $POST, $handle;

function edit($array){
  $this->POST = $array
  if(isset($this->POST['subfilename']))
    $this->form();
  elseif(isset($this->POST['subeditfile']))
    $this->editfile();
  else
    die("Error in edit::edit()");        
}

/** OLD FUNCTION **
    function edit(){

     if(isset($_POST['subfilename'])){
     $this->form();
     }
     else if(isset($_POST['subeditfile'])){
     $this->editfile();
     }
 } **/

function form(){
  $file = fopen($this->POST['filename'];, "r");
  $read = fread($file, filesize($this->POST['filename']));
       echo "Editing: <b>" . $this->POST['filename'] . "</b><br><br>"
         . "<form id='form1' name='form1' method='post' action='edit.php'>"
         . "Edit:<br /><textarea name='edit' id='edit'>" . $read . "</textarea>"
         . "<input name='subeditfile' type='hidden' id='subeditfile' value='1' />"
         . "<input name='filename' type='hidden' id='filename' value='" . $this->POST['filename']; . "' />"
         . "<input type='submit' name='Submit' value='Submit' /></form>";
fclose($file);
}
function editfile(){
    $string_edit = $this->POST['edit'];
    $open_read = fopen($this->POST['filename'], "r");
    $file_read = fread($open_read, filesize($this->POST['filename']));
    $open_write = fopen($this->POST['filename'], "w");
    $file_write = fwrite($this->POST['filename'], $string_edit);

    chmod($this->POST['filename'];, 755);     
        if ($edit != $file_read && $file_read != ''){
            fwrite($open_edit, $string_edit);            
        } else if ($file_read==$string_edit) {
            echo "Success,<br><br>" . $string_edit . "<br><br>has been written to "
                . $filename;   
        } else if (!$file_read==$string_edit){
            echo "Error,<br><br>" . $string_edit . "<br><br>Could not be written to "
                . $filename;
        }
    fclose($open_edit);
    }       
};
?> 

Call it with:

$edit = new edit($_POST);

[bradgrafelman]

This:

if (!$edit==$file_read && !$file_read==""){ 

isn't correct syntax. If you're trying to check if $edit doesn't equal $file_read and that $file_read isn't empty, it should be:

if ($edit != $file_read && $file_read != ''){ 

[Sesquipedalian]

Thanks brad, it worked at first, but now for some reason it isn't working anymore, I CHMOD'd the file directory to 777 before writing to the file, but for some reason it says permission denied.. This is the error messages I get:

Warning: fopen(index.php): failed to open stream: Permission denied in /home/adam/public_html/majyk/test/edit.php on line 33

Warning: fwrite(): supplied argument is not a valid stream resource in /home/adam/public_html/majyk/test/edit.php on line 36

Warning: fclose(): supplied argument is not a valid stream resource in /home/adam/public_html/majyk/test/edit.php on line 44

edit.php

<?php
error_reporting(2047); // debug
$test = new edit;
class edit{
    function edit(){

     if(isset($_POST['subfilename'])){
     $this->form();
     }
     else if(isset($_POST['subeditfile'])){
     $this->editfile();
     } 
 }
function form(){
$filename = $_POST['filename'];
$file=fopen($filename, "r");
$read=fread($file, 900000);
	echo "Editing: <b>" . $filename . "</b><br><br>"
         . "<form id='form1' name='form1' method='post' action='edit.php'>"
		 . "Edit:<br /><textarea name='edit' id='edit'>" . $read . "</textarea>"
         . "<input name='subeditfile' type='hidden' id='subeditfile' value='1' />"
		 . "<input name='filename' type='hidden' id='filename' value='" . $filename . "' />"
		 . "<input type='submit' name='Submit' value='Submit' /></form>"; 
fclose($file);
}
function editfile(){

	$filename = $_POST['filename'];
    $string_edit = $_POST['edit'];
	chmod($filename, 777);
	$open_read=fopen($filename, "r");
	$file_read=fread($open_read, filesize($filename)); 
    $open_edit=fopen($filename, "w");	     
        if ($string_edit != $file_read && $file_read !=''){
            fwrite($open_edit, $string_edit);			
        } else if ($file_read != $string_edit) {
            echo "Success,<br><br>" . $string_edit . "<br><br>has been written to "
                . $filename;   
        } else if ($file_read != $string_edit){
            echo "Error,<br><br>" . $string_edit . "<br><br>Could not be written to "
                . $filename;
        }
    fclose($open_edit);
    }       
};
?> 

I don't get why it would work at first, but now it doesn't?

[bradgrafelman]

You CHMOD'd the directory, but that doesn't affect the files already in the directory unless you did a recursive (-r) CHMOD. Did you do this? Did you try CHMOD'ing the specific file to 777?

[Sesquipedalian]

I wrote:

chmod($filename, 777);

So shouldn't that directly chmod the file, seeing as $filename is the variable for the actual filename.. And why would it work at first after I changed my code according to what you told me, but then when I tried to do it again, it didn't work?

[Sesquipedalian]

Oh and with your code (altered a little bit because you accidently had a bunch of ;'s in places where they shouldn't be), Kudose, I get the errors:

Warning: Missing argument 1 for edit() in /home/adam/public_html/edit.php on line 7
Error in edit: edit()

[Kudose]

Yeah, I did a copy and paste on a few things, so I probably did miss some semicolons.

Did you remember to pass $_POST into edit()?

i.e.

$test = new edit($_POST);

[Sesquipedalian]

I forgot to do that, the error isn't there anymore, besides the "Error in edit: edit()" that you manually put into the code..

<?php
error_reporting(2047); // debug
$test = new edit($_POST); 
class edit {
    var $POST, $handle;

function edit($array){
  if(isset($this->POST['subfilename']))
    $this->form();
  elseif(isset($this->POST['subeditfile']))
    $this->editfile();
  else
    die("Error in edit: edit()"); 
$this->POST = $array;       
}

/** OLD FUNCTION **
    function edit(){

     if(isset($_POST['subfilename'])){
     $this->form();
     }
     else if(isset($_POST['subeditfile'])){
     $this->editfile();
     }
 } **/

function form(){
  $file = fopen($this->POST['filename'], "r");
  $read = fread($file, filesize($this->POST['filename']));
       echo "Editing: <b>" . $this->POST['filename'] . "</b><br><br>"
         . "<form id='form1' name='form1' method='post' action='edit.php'>"
         . "Edit:<br /><textarea name='edit' id='edit'>" . $read . "</textarea>"
         . "<input name='subeditfile' type='hidden' id='subeditfile' value='1' />"
         . "<input name='filename' type='hidden' id='filename' value='" . $this->POST['filename']
		 . "' />"
         . "<input type='submit' name='Submit' value='Submit' /></form>";
fclose($file);
}
function editfile(){
 	$edit = new edit($_POST); 
    $string_edit = $this->POST['edit'];
    $open_read = fopen($this->POST['filename'], "r");
    $file_read = fread($open_read, filesize($this->POST['filename']));
    $open_write = fopen($this->POST['filename'], "w");
    $file_write = fwrite($this->POST['filename'], $string_edit);

    chmod($this->POST['filename'], 755);     
        if (!$string_edit==$file_read && !$file_read==""){
            fwrite($open_edit, $string_edit);            
        } else if ($file_read==$string_edit) {
            echo "Success,<br><br>" . $string_edit . "<br><br>has been written to "
                . $filename;   
        } else if (!$file_read==$string_edit){
            echo "Error,<br><br>" . $string_edit . "<br><br>Could not be written to "
                . $filename;
        }
    fclose($open_edit);
    }       
};
?> 

[Sesquipedalian]

<?php
error_reporting(2047); // debug
$edit = new edit($_POST); 
class edit {
    var $POST, $handle;

function edit($array){
$this->POST = $array; 
  if(isset($this->POST['subfilename']))
    $this->form();
  elseif(isset($this->POST['subeditfile']))
    $this->editfile();
  else
    die("Error in edit: edit()"); 

}

/** OLD FUNCTION **
    function edit(){

     if(isset($_POST['subfilename'])){
     $this->form();
     }
     else if(isset($_POST['subeditfile'])){
     $this->editfile();
     }
 } **/

function form(){
  $file = fopen($this->POST['filename'], "r");
  $read = fread($file, filesize($this->POST['filename']));
       echo "Editing: <b>" . $this->POST['filename'] . "</b><br><br>"
         . "<form id='form1' name='form1' method='post' action='edit.php'>"
         . "Edit:<br /><textarea name='edit' id='edit'>" . $read . "</textarea>"
         . "<input name='subeditfile' type='hidden' id='subeditfile' value='1' />"
         . "<input name='filename' type='hidden' id='filename' value='" . $this->POST['filename']
		 . "' />"
         . "<input type='submit' name='Submit' value='Submit' /></form>";
fclose($file);
}
function editfile(){
chmod($this->POST['filename'], 755); 
    $string_edit = $this->POST['edit'];
    $open_read = fopen($this->POST['filename'], "r");
    $file_read = fread($open_read, filesize($this->POST['filename']));
    $open_write = fopen($this->POST['filename'], "w");
    $file_write = fwrite($this->POST['filename'], $string_edit);
        if (!$string_edit==$file_read && !$file_read==""){
            fwrite($open_write, $string_edit);            
        } else if ($file_read==$string_edit) {
            echo "Success,<br><br>" . $string_edit . "<br><br>has been written to "
                . $filename;   
        } else if (!$file_read==$string_edit){
            echo "Error,<br><br>" . $string_edit . "<br><br>Could not be written to "
                . $filename;
        }
    fclose($open_write);
    }       
};
?> 

[Kudose]

Ok, here is my version -- it is not perfect (security wise) but it works enough to give you a foundation.

class.editfile.form.php

<?php
  class edit {
    /** define class variables **/
    var $POST, $handle, $fileinfo, $buffer, $rootDIR;

/** constructor **/
function edit($rootDIR){
    $this->rootDIR = $rootDIR;
}/** end edit() **/

/** function to set file to edit contents to the buffer **/
function fileform(){
  /** put the form HTML into the buffer **/
  $this->buffer = '<form name="which_page" method="POST" action="edit.php">';
    $this->buffer .= '<input type="text" name="filename" value="" /><br />';
    $this->buffer .= '<input type="submit" name="submit_which" value="Submit!" />';
  $this->buffer .= '</form>';
}

/** create a function to display the contents of the file 
*   to a textarea while maintaing the filename in a hidden
*   input field **/
function editForm(){
  $this->fileinfo = $this->readContents();
  $this->buffer = '';
  $this->buffer .= '<form name="edit_page" method="POST" action="edit.php">';
    $this->buffer .= '<textarea name="newContents">'.$this->fileinfo.'</textarea>';
    $this->buffer .= '<input type="hidden" name="filename" value="'.$this->POST['filename'].'" /><br />';
    $this->buffer .= '<input type="submit" name="submit_edit" value="Submit!" />';
  $this->buffer .= '</form>';
}

/** create funtion to output buffer to the screen **/
function dispForm(){
  echo $this->buffer;
  return true;
}

/** create a function to set POST variables **/
function setPOST($_POST){
  $this->POST = $_POST;
}

/** create a file to read the contents of a file to buffer **/
function readContents(){
  $this->handle = fopen($this->POST['filename'], 'r');
  $this->buffer = fread($this->handle, filesize($this->POST['filename']));
  return $this->buffer;
}


/** create a function to write the buffer to the file in $this->POST['filename'] **/
function writeContents(){
  /** overwrite $POST['filename'] to include the absolute path to the file **/
  $this->POST['filename'] = $this->rootDIR.$this->POST['filename'];
  /** make sure file exists **/
  if(!file_exists($this->POST['filename'])){
    echo 'Error in edit::readContents()!<br />The file you are accessing does not exist!';
    return false;
  }
  /** open the file **/
  $this->handle = fopen($this->POST['filename'], "w+");
  $this->buffer = fwrite($this->handle, $this->POST['newContents']);
  /** output the what happened **/
  if($this->buffer !== NULL){
    return 'File '.$this->POST['filename'].' was edited.';
  } else {
    return 'File '.$this->POST['filename'].' was not edited.';
  }
}

  }  

?>

edit.php

<?php
  require_once('class.editfile.form.php');
  $class = new edit('/home/123456/public_html/new/phpbuilder/');

  /** first page you come to **/
  if(!$_POST){
    $class->fileForm();
    $class->dispForm();
  }

  /** after submit_which is clicked **/
  if(isset($_POST['submit_which'])){
    $class->setPOST($_POST);
    unset($_POST);
    $class->editForm();
    $class->dispForm();
  }

  /** after submit_edit is clicked **/
  if(isset($_POST['submit_edit'])){
    $class->setPOST($_POST);
    unset($_POST);
    echo $class->writeContents();
  }
?>

index.php

hello

[Sesquipedalian]

I am guessing that will work, by the way thank you for taking your time to write that, but right now it's not echoing the form to enter the name of the file on class.editfile.form.php.. Is there something else I'm supposed to do?

[Kudose]

No, you should be able to copy everything into the three files and give it a whirl.

[Sesquipedalian]

I get the error:

Error in edit::readContents()!
The file you are accessing does not exist!

When the file does exist.. :/

[Sesquipedalian]

It works now, I forgot to change the DIR.. xP

Thanks a lot Kudose!!!