quick problem

roooss

hey there, ive got a quick problem i need a fresh set of eyes to look at im writing a script and in running it i just cannot debug the T_Variable parse error. ove managed to character by character go through the code and still cannot fix it im sure its this line of code...

 $sql_email_check = mysql_query("SELECT mem_email FROM members WHERE mem_email = "$email"", $my_sql) or die("<br />". mysql_error());

the rest of the code that matters is below...

$hostname_my_sql = "localhost";
$database_my_sql = "xxxxx";
$username_my_sql = "xxxxxx";
$password_my_sql = "xxxxxxx";
$my_sql = mysql_pconnect($hostname_my_sql, $username_my_sql, $password_my_sql) or trigger_error(mysql_error(),E_USER_ERROR); 


$uname = stripslashes($_POST['uname']);
$pword = stripslashes($_POST['pword']);
$pword2 = stripslashes($_POST['pword2']);
$email = stripslashes($_POST['email']);
$fname = stripslashes($_POST['fname']);
$sname = stripslashes($_POST['sname']);
$dob = stripslashes($_POST['dob']);
$saddy = stripslashes($_POST['saddy']);
$pcode = stripslashes($_POST['pcode']);
$gend = stripslashes($_POST['gend']);

$sql_email_check = mysql_query("SELECT mem_email FROM members WHERE mem_email = "$email"", $my_sql) or die("<br />". mysql_error());
 $sql_uname_check = mysql_query("SELECT mem_nick FROM {'members WHERE mem_nick = "$uname"",  $my_sql) or die("<br />". mysql_error());

 if ((!$sql_email_check) || (!$sql_uname_check)){
 $email_check = mysql_num_rows($sql_email_check) or die("<br />". mysql_error());
 $uname_check = mysql_num_rows($sql_uname_check) or die("<br />". mysql_error());
 }
else
{
print "Error from MySQL: ".mysql_error($my_sql)."\n"; 
}

ive been looking for this error since about 6 am!!!! lol

Houdini

Dont quote table names or surround them with curly braces.
Also use single quote around variables inside double quotes and do not add a connection resource to the query.

$sql_email_check = mysql_query("SELECT mem_email FROM members WHERE mem_email = '$email'") or die("<br />". mysql_error());
$sql_uname_check = mysql_query("SELECT mem_nick FROM members WHERE mem_nick = '$uname'") or die("<br />". mysql_error());

roooss

sorry abut that, lol they werent supposed to be there...

but still without the braces still no luck, with just the ' still not luck. even with " i still get the parse error. this is so confusing

roooss

ok ive wrtten the line exactly as you have and now i get myself seeing this error....

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''members' WHERE mem_email = admin@admin.com' at line 1

i know my server is configured fine because i can use phpmyadmin theres deffinately something wrong... but wehre!!!!!!! lol

EDIT: i dont know what ive just done but it works now! thanks for the help! i do have a seperate problem though! lol

$email_check = mysql_num_rows($sql_email_check) or die("<br />". mysql_error());
$uname_check = mysql_num_rows($sql_uname_check) or die("<br />". mysql_error());

im being told that both $uname_check and $email_check are undeclared the code above shows theyre not... any ideas?

tomhath

What does $email contain? It looks like there might be a quote character in there somewhere.

Try echoing the query instead of running it.

roooss

ok i have echoed the queries and gotg a completely unexpected result! lol

 $sql_email_check =  mysql_query("SELECT mem_email FROM members WHERE mem_email = '$email'", $my_sql) or die("<br />". mysql_error());

when i send those 2 queries and then echo them this is what i see

Resource id #3
Resource id #4

i was expecting the querie to return nothing when i entered new details and either the email address or username if it was matched. not these resource id's. how would i got about rectifying this?

tomhath

Echo the SQL, not the result. Something like this (untested):

$query = "SELECT mem_email FROM members WHERE mem_email = '$email'";

echo $query;

$sql_email_check =  mysql_query($query, $my_sql) or die("<br />". mysql_error());

roooss

ok.... here is my code as now...

$sql_email_check1 = "SELECT mem_email FROM members WHERE mem_email = '$email'";
$sql_uname_check1 = "SELECT mem_nick FROM members WHERE mem_nick = '$uname'";
echo $sql_uname_check1;
echo $sql_email_check1;
 $sql_email_check =  mysql_query($sql_email_check1, $my_sql) or die("<br />". mysql_error());
 $sql_uname_check = mysql_query($sql_uname_check1,  $my_sql) or die("<br />". mysql_error());

  $email_check = '';
 $uname_check = '';
 if ((!$sql_email_check) || (!$sql_uname_check)){
 $email_check = mysql_num_rows($sql_email_check, $my_sql) or die("<br />". mysql_error());
 $uname_check = mysql_num_rows($sql_uname_check, $my_sql) or die("<br />". mysql_error());
 }
else
{
print "1. Error from MySQL: ".mysql_error($my_sql)."\n"; 
}


 if(($email_check > 0) || ($uname_check > 0)){
     echo "Please fix the following errors: <br />";
     if($email_check > 0){
         echo "<strong>Your email address has already been used by another member in our database. Please submit a different Email address!<br />";
         unset($email_address);
     }
     if($uname_check > 0){
         echo "The username you have selected has already been used by another member in our database. Please choose a different Username!<br />";
         unset($uname);
     }
     include 'register-form.htm'; // Show the form again!
     exit();  // exit the script so that we do not create this account!
 } 

$sql = mysql_query("INSERT INTO members (mem_id, mem_nick, mem_pass, mem_email, mem_fname, mem_sname, mem_dob, mem_street, mem_postcode, mem_level, mem_active, mem_dor)
    VALUES('', '$uname', '$pword', '$email', '$fname', '$sname', '$dob', '$saddy', '$pcode', '0', '0', now())") or die (mysql_error($my_sql));

if(!$sql){
    echo 'There has been an error creating your account. Please contact the webmaster.';
} else {
include 'register-form.htm';
echo "congrats";
exit();

now the script executes and manages to inut the data into the table. however. i get the query echo saying...

SELECT mem_nick FROM members WHERE mem_nick = 'admin'

and

SELECT mem_email FROM members WHERE mem_email = 'admin@admin.com'

but im still getting this line of code printed...

print "1. Error from MySQL: ".mysql_error($my_sql)."\n";

i dont get the error message however, which doesn't help lol.

i dont know if because there is something in the query my code will actually insert a duplicate entry or weather that a seperate problem on its own

tomhath

It's probably not printing an error because it appears there was no error. Look carefully at this line. If both queries are successful, both of those variables will have a nonzero value.

 if ((!$sql_email_check) || (!$sql_uname_check)){

I think you meant:

 if ($sql_email_check && $sql_uname_check){

roooss

ok i took your advice on.. but i needed the OR because i i want to let the user know when they have the same username OR the same e-mail. but now having changed that i dont get a single error meesage or success message, and nothing is entered into the database.

i was getting an error when the num_rows command was called. Wrong parameter count for mysql_num_rows() so i took the connection string out as the record (if at all) has already been retrieved.
but now i get nothing, nothing is edited/added. i tried to echo $email_check and $uname_check

$sql_email_check1 = "SELECT mem_email FROM members WHERE mem_email = '$email'";
$sql_uname_check1 = "SELECT mem_nick FROM members WHERE mem_nick = '$uname'";

 $sql_email_check =  mysql_query($sql_email_check1, $my_sql) or die("<br />". mysql_error());
 $sql_uname_check = mysql_query($sql_uname_check1,  $my_sql) or die("<br />". mysql_error());

  $email_check = '';
 $uname_check = '';
 if ($sql_email_check || $sql_uname_check){
 $email_check = mysql_num_rows($sql_email_check) or die("<br />". mysql_error());
 $uname_check = mysql_num_rows($sql_uname_check) or die("<br />". mysql_error());
  echo $email_check;
 echo $uname_check;
 }else{
print "1. Error from MySQL: ".mysql_error($my_sql)."\n";
} 
 echo $email_check;
 echo $uname_check;

somethign there is causing an errorbut i just cannot see it :mad:

tomhath

It sounds like the script got a little farther before it ran into another problem.

At the very bottom this looks wrong, missing the } for the "else":

if(!$sql){
    echo 'There has been an error creating your account. Please contact the webmaster.';
} else {
include 'register-form.htm';
echo "congrats";
exit();

One way to find these problems is to make a copy of the script, then delete everything below the last line you think works. Put an "echo" there to be sure it's doing what you want, then start adding a few lines at a time and testing it until you get to the end.