Code syntax

Bob_PHP_Builder

Can anyone tell me whats wrong with this line of code?
$t_if needs to be sent to a database table




while ($result=mysql_fetch_array($type_id)){

$t_id= $result['type_id'];
}

Thankyou

bpat1434

Umm... what is $type_id? Is it the result resource from a query?

Other than that clarification, that bit of code is perfectly fine......

Bob_PHP_Builder



<?	




 $width= $_POST ['Width_1'];
 $height= $_POST ['Height_1'];
 $desc='1';
 $amount= '12';
     $o_id= $_GET ['data1'];

 $extra = $_GET ['extratype'];
 $size= '4x6';
 $paper= $_GET ['papertype'];

/* Connect to database */

$db= mysql_connect("localhost", "", "");
mysql_select_db("", $db);


$lastphoto = mysql_query("SELECT photo_id 
FROM order_line 
ORDER BY photo_id DESC LIMIT 1"); 

while($row= mysql_fetch_array($lastphoto)) 
{ 

$newlastphoto= ($row["photo_id"]+1); 


} 



$newtype="SELECT type_id FROM `type` WHERE extra='$extra' AND size='$size' AND paper='$paper'"; 
if( !($type_id=mysql_query($newtype)) ) {
  die('Error SQL query');
}


$type_id=mysql_query($newtype);


while ($result=mysql_fetch_array($type_id)){
// echo $result['type_id']."<br/>";

$t_id= $result['type_id'];
}





$sql= 	"INSERT INTO order_line
	VALUES ('$newlastphoto', '$fileName', '$amount', '$width', '$height', '$desc', '$t_id', '$o_id')";
	mysql_query($sql);

?>

Bob_PHP_Builder

Basically there are 2 queries in here both work seperatley but when i add the two together i get nothing going to the table.. All the Variables have values as well

m_tt

Instead of using mysql_fetch_array try using mysql_fetch_assoc. Or pass the result type like so:

mysql_fetch_array($type_id, MYSQL_ASSOC)

Also $type_id is already defined here:
if( !($type_id=mysql_query($newtype)) )

So there is no need to redefine it here:
$type_id=mysql_query($newtype);

Weedpacket

There is also no need to use a loop; if you're going to return exactly one row, then the loop will run exactly once - which is pretty pointless for a loop.

bpat1434

Instead of using mysql_fetch_array try using mysql_fetch_assoc. Or pass the result type like so:

mysql_fetch_array($type_id, MYSQL_ASSOC)

This is trivial. If you read the manual it says that the type of array to be returned is not needed / required. If left off or blank, then MYSQL_BOTH will be used, which returns an array with both associative and numeric indexes.

It may also help you to actually specify what columns you're inserting data into in the INSERT query, then the values.

And of course, as the mother of all suggestions: use [man]mysql_error/man and [man]mysql_errno/man to help get a more informative error message 😉