[RESOLVED] A better way out there?

RARZG

The code below works fine, but is way to long! now i have a few of these linked together its taking some time to process and configure each page!

Program requirments;
1. Get source code from web page
2. Dump in txt file
3. delete all but the line i say i want to keep
4. trim out all non numberic chars
5. save / close txt file.

here the code [working];

<? 
$mainfile = 'test.txt';
$source = file("http://www.example.com/index.html");
$data = join ($source);
function filterBadWords($str){
 $badwords=array( "[a]", "[b]", "[c]", "[d]" , "[e]", "[f]", "[g]", "[h]" , "[i]", "[j]" ,"[k]", "[l]", "[m]", "[n]", "[o]", "[p]", "[q]", "[r]" , "[s]", "[t]" , "[u]", "[v]", "[w]", "[x]", "[y]", "[z]" , "[<]", "[>]" ,"[/]", "[\]" , "[']" , "[%]", "[=]" , "[+]", "[{]", "[}]", "[-]", "[#]", "[&]" , "[*]", "[:]" , "[;]");
 $replacements=( "" );
 for($i=0;$i < sizeof($badwords);$i++){
  srand((double)microtime()*1000000); 
  $str=eregi_replace($badwords[$i], $rand_key, $str);
 }
 return $str;
}

$data = filterBadWords($data);  

$fp = fopen( $mainfile, "w");
fwrite( $fp, $data );

$filearray=file( $mainfile );
$fp = fopen($mainfile,"w");
$c=count($filearray);
//Added lines to the top - high number mores lines add on to the top
for($i=($c < 76 ? 0 : $c-76);$i < $c;++$i) {
fputs($fp,$filearray[$i]);
}
fclose($fp);

 $inp = file($mainfile);
 $out = fopen($mainfile,'w');
 //lower the number the more content comes through
 for ($i=0;$i<count($inp)-73;$i++)
 fwrite($out,$inp[$i]);
 fclose($out);

?>

there has gotta be a way easy of shorting this down? Hasen`t there? Im just a newbie im affraid been reading about flatfiles for a few days now so i decide to post for help. thanks for reading.

Vectorman211

there are many unnecessary steps in this code.

<?
$mainfile = 'test.txt';
//get file as text blob rather than array then filter out non-numeric chars.
$data=ereg_replace 
('[^0-9]+','',file_get_contents("http://www.example.com/index.html"));

//I'm not sure what you're trying to do here so not going to touch it.
$fp = fopen( $mainfile, "w");
fwrite( $fp, $data );

$filearray=file( $mainfile );
$fp = fopen($mainfile,"w");
$c=count($filearray);
//Added lines to the top - high number mores lines add on to the top
for($i=($c < 76 ? 0 : $c-76);$i < $c;++$i) {
fputs($fp,$filearray[$i]);
}
fclose($fp);

$inp = file($mainfile);
$out = fopen($mainfile,'w');
//lower the number the more content comes through
for ($i=0;$i<count($inp)-73;$i++)
fwrite($out,$inp[$i]);
fclose($out);

?>

As you see by using ereg_replace you specify the chars your want to keep rather than the one's you don't want.

RARZG

Thanks. that is a real help. just reading up atm on how i can also keep the "£" sign also...

//I'm not sure what you're trying to do here so not going to touch it.
$fp = fopen( $mainfile, "w");
fwrite( $fp, $data );

this is the code that opens up the text file and saves the returned data to it.

RARZG

Ok so ive now got the code to keep '0-9' '£' '.' which is what i was after. Now ill need to filter these results as the code returns too many chars.

Is there a way to search a string by a char say "£" and then echo the char and the next 15 chars after? As atm its a bit messy

777 £140.00 0000£100.99 0641 0

Obv need to get it to echo

£140.00 £100.99

Which is never going to happen but

£140.00 0000£100.99

Would be nice!
Thanks again Vectorman211

RARZG

Ok so after a few hours of reading ive got it down to a few line;

<?
//the file I will be using to save data
$main = ('test.txt');
//data source
$web = ("http://www.example.com/1.html");
//get data and strip out everything apart from 0-9 £ . chars
$data = ereg_replace('[^0-9 £ .]','', file_get_contents($web));
//trim up till first "£"
$trimmed = strstr($data, '£');
//trim anything f=after the 23 char
$final = substr( $trimmed , 0, 23);
//open file
$fp = fopen( $main, "w");
//save file
fwrite( $fp, $final );


$main = ('test2.txt');
$web = ("http://www.example.com/2.html");
$data = ereg_replace('[^0-9 £ .]','', file_get_contents($web));
$trimmed = strstr($data, '£');
$final = substr( $trimmed , 0, 23);
$fp = fopen( $main, "w");
fwrite( $fp, $final );

?>

but as you can see the code is reapting itself, as i need data from website1 into text file 1, then data from website2 into text file 2. etc etc

can i make this into a array or function somehow? ideally so i can dump all the URL's in a text file and

ideas?

RARZG

thanks again for the help guys.
Code if any body was wondering. Learnt alot on this one.

$data = file_get_contents("http://www.example.com");
$trimmed = strstr($data, '&pound');
$ok1 = substr( $trimmed , 0, 58);

one small step forward from my zero knowledge of PHP!