uploading files?

lukeurtnowski

I allow people to upload files to my server, how can I ensure that each uploaded file has a unique name so that a file doesn't accidentally overwritten?
Thanks...

hadoob024

You could look at the name of the uploaded file while it's in the temp directory. Search your permanent directory for a file with similar file name. If you find a match, you can handle it with some error handling (either prompt the user with an error saying that the file already exists or just rename the file when you move it to the permanent directory).

qadeer_ahmad

Hi,
Another way to make uniqe files just add this str to current uploaded file name (rename current file with new name).
$newName=$currentname.date("Ymdhis");

this will be a uniqe name to every file.

lukeurtnowski

ok, well, here is how I get the name of the file being uploaded,

$Image1_name = $_FILES['Image1']['name'];

and its when I upload it into /images/ASP_images is when I want to ensure a unique name.
How do I change the name before i upload it (And how do I upload it also?)
Thanks

hadoob024

OK. Well, for the form, you'll need to implement something like:

<input type="hidden" name="MAX_FILE_SIZE" value="102400" />
<input name="picture" type="file" size="30" />

This code will actually upload the file. It then gets stored in a temp directory for the duration of the running of your PHP script. It's before your script runs to completion where you'll have to rename and move the file, save it, etc. Of course, you should implement many checks (even if they're redundant) to make sure that the file being uploaded is of the correct type and size.

Stuff like:

if (($_FILES['picture']['type'] != 'image/jpeg'))

or:

if ($_FILES['picture']['error'] > 0)

or:

if ((isset($_FILES['picture'])) && ($_FILES['picture']['size'] != 0) && ($_FILES['picture']['tmp_name'] != ''))

lukeurtnowski

ok, I think this will work (I have 6 images)

if ((isset($_FILES['Image1'])) || (isset($_FILES['Image2'])) || (isset($_FILES['Image3 '])) || (isset($_FILES['Image4'])) || (isset($_FILES['Image5'])) || (isset($_FILES['Image6'])))

Once this is true how do I upload the files, like this?

$uploaddir = "/images/ASP_Images";

$currentname1 =  $_FILES['Image1']['name'];
$currentname2 =  $_FILES['Image2']['name'];
$currentname3 =  $_FILES['Image3']['name'];
$currentname4 =  $_FILES['Image4']['name'];
$currentname5 =  $_FILES['Image5']['name'];
$currentname6 =  $_FILES['Image6']['name'];

$newName1=$currentname1.date("Ymdhis");
$newName2=$currentname2.date("Ymdhis");
$newName3=$currentname3.date("Ymdhis");
$newName4=$currentname4.date("Ymdhis");
$newName5=$currentname5.date("Ymdhis");
$newName6=$currentname6.date("Ymdhis");

if(is_uploaded_file($_FILES['Image1']['tmp_name']))
{
move_uploaded_file($newname1,$uploaddir.'/'.$newname1);
}
if(is_uploaded_file($_FILES['Image2']['tmp_name']))
{
move_uploaded_file($newname2,$uploaddir.'/'.$newname2);
}
if(is_uploaded_file($_FILES['Image3']['tmp_name']))
{
move_uploaded_file($newname3,$uploaddir.'/'.$newname3);
}
if(is_uploaded_file($_FILES['Image4']['tmp_name']))
{
move_uploaded_file($newname4,$uploaddir.'/'.$newname4);
}
if(is_uploaded_file($_FILES['Image5']['tmp_name']))
{
move_uploaded_file($newname5,$uploaddir.'/'.$newname5);
}
if(is_uploaded_file($_FILES['Image6']['tmp_name']))
{
move_uploaded_file($newname6,$uploaddir.'/'.$newname6);
}

Thanks

hadoob024

Pretty similar. Like on my site, I allow the user to upload 1 image file (either JPG or GIF). Just by submitting the form, the file gets uploaded into the temp directory. There's no process to actually upload the file. The form handles it for you.

One thing I would change is how you move the files. Instead of:

move_uploaded_file($newname1,$uploaddir.'/'.$newname1);

I think you might have to reference the file by it's location in the temp directory like so:

move_uploaded_file($_FILES['picture']['tmp_name'], $uploaddir.'/'.$newname1)

Also, you want to check your naming convention. In one part, you called files like so "$newName1", but then you reference it by "$newname1".