[RESOLVED] class method returns true AND false at the same time!!

ppowell

class ThumbView extends PaginationView {

   function ThumbView() {}

/**
 * Determine if the original image is actually an image and thus a thumbnail can be generated at all
 *
 * @access public
 * @param mixed $image_name (optional)
 * @param mixed $album (optional)
 * @param mixed $section (optional)
 * @return boolean
 * @see mime_content_type
 * @see actual_path
 */
function isImage($image_name = '', $album = '', $section = '') {					// BOOLEAN METHOD
	/*--------------------------------------------------------------------------------------------------------------------------------------------------------
		ResizeView will inherit ThumbView::isImage() method now and thus will have its own instance of $this->id in existence
		which is the image name and not an actual id (other instances of $this->id in class objects inheriting this method will
		be numeric by database design).  Set the obtainably inherited $this->{$section . '_name'} to $this->id.
	---------------------------------------------------------------------------------------------------------------------------------------------------------*/
	if (!$section) global $section;
	global ${$section . 'LocationPath'};
	if (!$this->{$section . '_name'} || $image_name) ThumbView::setThumbViewProperties($image_name, $album);
	if ($this->{$section . '_name'}) {
	 if (strlen($this->album) > 0) $album =  $this->album;
	 $locationPath = ($album) ? "${$section . 'LocationPath'}/$album" : ${$section . 'LocationPath'};
	 $imgStatArray = @getimagesize(actual_path("$locationPath/" . $this->{$section . '_name'}));
	 if (!is_array($imgStatArray) || @sizeof($imgStatArray) == 0) return false;
	print_r("111<P>");
	 if (preg_match('/^image\//i', @mime_content_type(actual_path("$locationPath/" . $this->{$section . '_name'})))) return true;
	 print_r("222<P>");
	}
	print_r("333<P>");
	return false;	// WILL EVEN RETURN FALSE IF NO IMAGE NAME IS PROVIDED SINCE IMPOSSIBLE TO DETERMINE IF ?? IS AN IMAGE OR NOT
}

}

This class method, isImage(), for some bizarre reason, has the uncanny ability to return both TRUE AND FALSE literally at the exact same time, or so it seems!

This will be your output:

111
333

Based on this logic flow, that means that it should have returned true and that's it, but for some bizarre reason it is literally capable of returning true, then suddenly returning false, even though the method is called "statically":

if (!ThumbView::isImage($fileName, $_REQUEST['album'])) {
 print_r("This is not an image<P>"); // ALWAYS PRINTS THIS EVEN IF IT *IS* AN IMAGE!!
}

Has anyone ever seen this within a statically called class method ever in PHP?

Phil

cgraz

are you printing 111 and 222 and 333 to see what your method is evaluating too? If so, you need to do the print just before you return true or false, not outside the conditional that calls true or false. My suggestion would be to change this

		if (!is_array($imgStatArray) || @sizeof($imgStatArray) == 0) 
		{
			return false;
		}

	print_r("111<P>");

	if (preg_match('/^image\//i', @mime_content_type(actual_path("$locationPath/" . $this->{$section . '_name'})))) 
	{
		return true;
	}

	print_r("222<P>");

to this

	if (!is_array($imgStatArray) || @sizeof($imgStatArray) == 0) 
	{
		print "111";
		return false;
	}

	if (preg_match('/^image\//i', @mime_content_type(actual_path("$locationPath/" . $this->{$section . '_name'})))) 
	{
		print "222";
		return true;
	}

ppowell

I did that, exact same result

111
333

It is still somehow returning TRUE and FALSE!

Phil

ppowell

Here is the code:

	/**
	 * Determine if the original image is actually an image and thus a thumbnail can be generated at all
	 *
	 * @access public
	 * @param mixed $image_name (optional)
	 * @param mixed $album (optional)
	 * @param mixed $section (optional)
	 * @return boolean
	 * @see mime_content_type
	 * @see actual_path
	 */
	function isImage($image_name = '', $album = '', $section = '') {					// BOOLEAN METHOD
		/*--------------------------------------------------------------------------------------------------------------------------------------------------------
			ResizeView will inherit ThumbView::isImage() method now and thus will have its own instance of $this->id in existence
			which is the image name and not an actual id (other instances of $this->id in class objects inheriting this method will
			be numeric by database design).  Set the obtainably inherited $this->{$section . '_name'} to $this->id.
		---------------------------------------------------------------------------------------------------------------------------------------------------------*/
		if (!$section) global $section;
		global ${$section . 'LocationPath'};
		if (!$this->{$section . '_name'} || $image_name) ThumbView::setThumbViewProperties($image_name, $album);
		if (!is_object($this) || @!is_a($this, 'ThumbView')) {
		 $self =& new ThumbView($image_name, $album);
		} else {
		 $self =& $this;
		}
		if ($self->{$section . '_name'}) {
		 if (strlen($self->album) > 0) $album =  $self->album; else $album = $_REQUEST['album'];
		 $locationPath = ($album) ? "${$section . 'LocationPath'}/$album" : ${$section . 'LocationPath'};
		 $imgStatArray = @getimagesize(actual_path("$locationPath/" . $self->{$section . '_name'}));
		 if (!is_array($imgStatArray) || @sizeof($imgStatArray) == 0) { print_r('111<P>');  return false; }
		 if (preg_match('/^image\//i', @mime_content_type(actual_path("$locationPath/" . $self->{$section . '_name'})))) { print_r('222<P>'); return true; }
		}
		print_r('333<P>');
		return false;	// WILL EVEN RETURN FALSE IF NO IMAGE NAME IS PROVIDED SINCE IMPOSSIBLE TO DETERMINE IF ?? IS AN IMAGE OR NOT
	}

Now I get this:

222

333

222

222

Phil

jdorsch

After spending about 10 minutes formatting your code into something readable I cannot find anything inherently wrong. Are you sure that it is this method you are calling and that it is only being called once? Does the ThumbView constructor call any methods?

PABobo

$imgStatArray = @getimagesize(actual_path("$locationPath/" . $this->{$section . 'name'}));
if (!is_array($imgStatArray) || @sizeof($imgStatArray) === '0') return false;
print_r("111<P>");
if (preg_match('/^image\//i', @mime_content_type(actual_path("$locationPath/" . $this->{$section . 'name'})))) return true;
print_r("222<P>");
}
print_r("333<P>");
return false; // WILL EVEN RETURN FALSE IF NO IMAGE NAME IS PROVIDED SINCE IMPOSSIBLE TO DETERMINE IF ?? IS AN IMAGE OR NOT
}

}

do an exact match === and also give value '0' not null/nothing

ppowell

Thanx, all, but I gave up and rewrote the entire class from scratch, using local self-instantiation within the isImage() method, and all is well, it "returns once" now.

Thanx
Phil