[RESOLVED] help onn making code more efficient

[tlavalle]

how can i make this smaller and work more efficient?

if(empty($row[6])){

		} else if(empty($row[7])){
			print("<p>$row[6]<br></p>");
		} else if(empty($row[8])){
			print("<p>$row[6]<br>$row[7]<br></p>");
		} else if(empty($row[9])){
			print("<p>$row[6]<br>$row[7]<br>$row[8]<br></p>");
		} else if(empty($row[10])){
			print("<p>$row[6]<br>$row[7]<br>$row[8]<br>$row[9]<br></p>");
		} else if(empty($row[11])){
			print("<p>$row[6]<br>$row[7]<br>$row[8]<br>$row[9]<br>$row[10]<br></p>");
		} else if(empty($row[12])){
			print("<p>$row[6]<br>$row[7]<br>$row[8]<br>$row[9]<br>$row[10]<br>$row[11]<br></p>");
		} else if(empty($row[13])){
			print("<p>$row[6]<br>$row[7]<br>$row[8]<br>$row[9]<br>$row[10]<br>$row[11]<br>$row[12]<br></p>");
		} else if(empty($row[14])){
			print("<p>$row[6]<br>$row[7]<br>$row[8]<br>$row[9]<br>$row[10]<br>$row[11]<br>$row[12]<br>$row[13]<br></p>");
		}else if(empty($row[15])){
			print("<p>$row[6]<br>$row[7]<br>$row[8]<br>$row[9]<br>$row[10]<br>$row[11]<br>$row[12]<br>$row[13]<br>$row[14]<br></p>");
		} else {
			print("<p>$row[6]<br>$row[7]<br>$row[8]<br>$row[9]<br>$row[10]<br>$row[11]<br>$row[12]<br>$row[13]<br>$row[14]<br>$row[15]<br></p>");
		}

[madwormer2]

for($i=6;isset($row[$i]);$i++){  echo $row[$i] . '<br>'; }

Haha! One line!

[tlavalle]

Madwormer2,
Wow that is awesome I would have had 6 line but 1. nice.

but one last question

If i want to do a return after : what would i need to do?

[madwormer2]

I assume you mean you want it in <p> tags?

Simple, just put the <p> tags around the code snippet.

echo '<p>';for($i=6;isset($row[$i]);$i++){  echo $row[$i] . '<br>'; } echo '</p>';

[tlavalle]

actually here is what i have in the database.

Internship:
San Joaquin General Hospital
Stockton, California

but when i pull it and echo it it looks like

Internship:San Joaquin General Hospital Stockton,
California

how would i fix it if i want it to show like the first example.

then i will quit bothering people. 🙂

[madwormer2]

Oh, you want [man]nl2br/man :p

[tlavalle]

echo '<p>';for($i=6;isset($row[$i]);$i++){ echo nl2br($row[$i] ). '<br>'; } echo '</p>';

does the syntax look right?

[madwormer2]

Yup 😃 If you inserted the data into the database with the new lines, this code should convert it to a <br>.

Just so that you understand what's happening here, I'm gonna lay out the code a bit more sensibly, because I used one line for effect 😉

echo '<p>';
for($i=6;isset($row[$i]);$i++){ // Start a loop at 6, and continue until $row[$i] no longer exists
  echo nl2br($row[$i] ). '<br>'; // Echo the current data
}  // and continue again at the top of the loop.
echo '</p>';

[tlavalle]

LOL Thank you.

[tlavalle]

ok so i lied:

so here is what we have
for($i=6;isset($row[$i]);$i++){ // Start a loop at 6, and continue until $row[$i] no longer exists
echo nl2br($row[$i] ). '<br>'; // Echo the current data
} // and continue again at the top of the loop.

this works realy awesome thank, but it goes through the whole record. the last problem trust me i

[madwormer2]

Haha

<?php
$row= Array(0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20);
echo '<p>';
for($i=6;( isset($row[$i]) && $i < 16 );$i++){ // Start a loop at 6, and continue until $row[$i] no longer exists
  echo nl2br($row[$i] ). '<br>'; // Echo the current data
}  // and continue again at the top of the loop.
echo '</p>'; 
?>

[tlavalle]

Ok the whole thing went from 22 lines to

echo '<p>';
for($i=6;(isset($row[$i]) && $i < 16 );$i++){
if(empty($row[$i])){
} else {
echo nl2br($row[$i] ). '<br>'; // Echo the current data
echo '<br>';
}
} // and continue again at the top of the loop.
echo '</p>';

9 lines and the desired effect is achieved.

thank you once again I probally would have figured it out, but not this quickly.

[tlavalle]

one quick question on this code how would i put comma after the item but not on the last one

for($i=36;(isset($row[$i]) && $i < 38 );$i++){ // Start a loop at 6, and continue until $row[$i] no longer exists
if(empty($row[$i])){
} else {
echo nl2br($row[$i] ); // Echo the current data
}
} // and continue again at the top of the loop.

[madwormer2]

if(isset($row[($i+1])){
echo ',';
}

That checks to see if the NEXT value is set, and if it is, it echoes the comma. When it gets to the last record, the next value WILL NOT BE SET, so it will not echo the comma. 😃

[tlavalle]

hmm I put it in and fix a bug but seems to put a comma at the end. Heres the complete code for the section.

for($i=36;(isset($row[$i]) && $i < 38 );$i++){ // Start a loop at 36, and continue until $row[$i] no longer exists
if(empty($row[$i])){
} else {
echo nl2br($row[$i] ); // Echo the current data
if(isset($row[$i - 1])){
echo ', ';
}
}
} // and continue again at the top of the loop.

[madwormer2]

Okay, I see it:

$start = 3; // Where d'ya wanna start?
$end = 5; // Where d'ya wanna end?
for($i=$start;(isset($row[$i]) && $i <= $end );$i++){ 
  echo nl2br($row[$i] ); // Echo the current data
  if(isset($row[$i + 1]) && $i != $end ){
    echo ', ';
  }
}

[tlavalle]

ok, did that but same, sorry i am bugging but this helping to understand the php language even better.

[madwormer2]

I've edited the code in my last post.

[tlavalle]

thanks once again 🙂