Stuck on arrays, help pls! :)

scottrohe

alright well i got my fav system started, anyways.. i have a "hot layouts" ( top 3 ) that are in a sql table 'layouts' being outputted, ran by a while loop.. then i try to add another while loop for another table 'favorites', for ONE part which is "if this favorite exists.. show 'delete' favorite image.. if favorite doesnt exist.. show 'add' favorite image. now it was working fine, and still does before i put the while loop for the favorites images in, i echod the result and i think its because instead of the result output being 1 single ID, its mixing them. so instead of it saying ok, fav id = 1, layout id = 1, its saying... layout id=1, fav id=12 and picking up only one of them since im running an if statement.. ( with 2 favorites added, being id 1 & 2 ). it outputs just 1 'delete' favorite image and then stops the other is a 'add' image, even though its already in the table added. pretty unclear explanation but i hope its understandable. i will show code below. i left my test echo in there too btw. any help is appreciated.

<?
$sqltwo1 = mysql_query("SELECT * FROM ".TBL_LAYOUTS." ORDER BY views DESC LIMIT 3");

while ($r=mysql_fetch_array ($sqltwo1))
{    

    $hl_id=$r["id"];
    $hl_subcat=$r["subcat"];
    $hl_username=$r["username"];
    $hl_lname=$r["lname"];
    $hl_thumb=$r["thumb"];
    $hl_views=$r["views"];

$hl_views++;
$sqltwo2 = "UPDATE ".TBL_LAYOUTS." SET views='$hl_views' WHERE id='$hl_id'";
$result = mysql_query($sqltwo2);

?>

<table cellpadding="0" cellspacing="0" border="0" width="240">
<tr>
<td valign="top" width="55">
<img src="i/hotlayouttest.gif" align="left">
	</td>
	<td valign="top" width="16">
<?

$sqlfavcheck4 = mysql_query("SELECT * FROM ".TBL_FAVORITES." WHERE username='$session->username'");
while ($ss=mysql_fetch_array ($sqlfavcheck4))
{    

    $ef_id=$ss["id"];
    $ef_favid=$ss["favid"];
    $ef_cat=$ss["cat"];
    $ef_subcat=$ss["subcat"];
echo $ef_favid;
}


if ($hl_id == $ef_favid)
{

?>
<a href="?x=delf&f=<?echo $hl_id;?>&c=layouts&s=<?echo $hl_subcat;?>"><img src="i/alreadyfav.gif" hsrc="i/alreadyfav2.gif" align="left" border="0"></a>
<?} else { ?>
<a href="?x=addf&fav=<?echo $hl_id;?>&cat=layouts&sub=<?echo $hl_subcat;?>"><img src="i/favicon2.gif" hsrc="i/favicon2_2.gif" align="left" border="0"></a>
<?
}
?>
	</td>
	<td valign="top" width="169">
<font class="text1">
<?echo $hl_lname;?><br>
<?echo $hl_subcat;?><br>
<font class="text1lb"><b>By:</font></b> <a href="?x=profile&user=<?echo $hl_username;?>"><?echo $hl_username;?></a><br>
<font class="text1db">#</font> of Views: <font class="text1lb"><?echo $hl_views;?></font>
	</td>
	</tr>
	</table> 

<br>

<?
}
?>

cbj4074

I don't say this to be a prick, but it would be really helpful if you only showed us what we needed to see. That is, we don't need to see all of your HTML. And you can reduce your PHP to a simpler format that is representative of the real issue; doing so might even lead you to the solution all on your own. Also, it would be nice if you could use the PHP code tags instead of the generic code tags, so we have the benefit of viewing your code with syntax highlighting.

More important, if you have a problem of this nature, it would be great if you could provide us with a zipped SQL dump of your database tables. That way, we can actually test with your real configuration instead of spend time guessing.

Okay, now onto your problem. The flaw is in your logic. Think about what you are actually doing here... you are looping through your MySQL result set and setting $hl_id to a given value EACH ITERATION through the loop; $hl_id's value is changing each time your while() loop runs.

Now, think about your second while() loop. You're doing the same thing with $ef_favid. So, when you do your value comparison

if ($hl_id == $ef_favid)

both of those values are set to whatever the LAST row in each respective MySQL result set returned. You need to perform the value comaprison within the looping process, not at the end (because, after all, you want to compare the values for EACH favorite, not just the last one, right?).

Is this helping?

scottrohe

still cant seem to get it :queasy:

cbj4074

I'm not sure I'm really understanding what exactly you're trying to do, and I haven't tested this code, but see if this works:

(All I did was indent your control structures a little so they were legible and move the if() statement up into the 2nd while() loop.)

Also, I would advise against using the short PHP tag (<? ?>) because a) it's officially deprecated, and b) your script will break on IIS and you'll spend days trying to figure out why. And don't use <?=$var?> to echo out variables, either, for the same reason.

<?
$sqltwo1 = mysql_query("SELECT * FROM ".TBL_LAYOUTS." ORDER BY views DESC LIMIT 3");

while ($r=mysql_fetch_array ($sqltwo1))
{    

	$hl_id=$r["id"];
	$hl_subcat=$r["subcat"];
	$hl_username=$r["username"];
	$hl_lname=$r["lname"];
	$hl_thumb=$r["thumb"];
	$hl_views=$r["views"];

$hl_views++;
$sqltwo2 = "UPDATE ".TBL_LAYOUTS." SET views='$hl_views' WHERE id='$hl_id'";
$result = mysql_query($sqltwo2);

?>

<table cellpadding="0" cellspacing="0" border="0" width="240">
<tr>
<td valign="top" width="55">
<img src="i/hotlayouttest.gif" align="left">
</td>
<td valign="top" width="16">
<?

$sqlfavcheck4 = mysql_query("SELECT * FROM ".TBL_FAVORITES." WHERE username='$session->username'");
while ($ss=mysql_fetch_array ($sqlfavcheck4))
{    
	$ef_id=$ss["id"];
	$ef_favid=$ss["favid"];
	$ef_cat=$ss["cat"];
	$ef_subcat=$ss["subcat"];

	if ($hl_id == $ef_favid)
	{

		?>
		<a href="?x=delf&f=<?echo $hl_id;?>&c=layouts&s=<?echo $hl_subcat;?>"><img src="i/alreadyfav.gif" hsrc="i/alreadyfav2.gif" align="left" border="0"></a>
		<?} else { ?>
		<a href="?x=addf&fav=<?echo $hl_id;?>&cat=layouts&sub=<?echo $hl_subcat;?>"><img src="i/favicon2.gif" hsrc="i/favicon2_2.gif" align="left" border="0"></a>
		<?
	}
}


?>
</td>
<td valign="top" width="169">
<font class="text1">
<?echo $hl_lname;?><br>
<?echo $hl_subcat;?><br>
<font class="text1lb"><b>By:</font></b> <a href="?x=profile&user=<?echo $hl_username;?>"><?echo $hl_username;?></a><br>
<font class="text1db">#</font> of Views: <font class="text1lb"><?echo $hl_views;?></font>
</td>
</tr>
</table>

<br>

<?
}
?>

scottrohe

doesn't work, ive tried that.. it just shows both images. i think whats needed is like an array within the loop and then a variable that is noted as true or false then another if outside of the loop, so basicaly heres what i need but cant figure out.. ex;
favyidd = brought in from url..

select favorites where username=username..
get all favorites id results
split each result up so it doesnt get confused
go through every result
if splitupresult = favyidd{
$favalreadyexists = true
}else{
$favalreadyexists = false

end loop

then another if statement for the images to determine which to show
if $favalreadyexists = true
show 'deletefavorite' image
else
show 'addfavorite' image

hope this helps you help me lol. thanks for the help so far, its like i understand what i need and want to do, i just cant get it!

scottrohe

still havnt figed it out, really frustrating, help please!

cbj4074

think the problem is that I'm not sure I understand what you are trying to do, simply from a logical perspective.

Can you do your very best to walk me through a clear and concise (but use as much space as you need) explanation of what exactly you are trying to do?

Using ONLY the original code sample that you posted, are you hoping to end up with just one table that has a list of the three "hot layouts", and images next to each item in the list that say "ADD" or "REMOVE", depending on whether or not the person already has the hot layout added to his or her personal, stored-list of favorite layouts?

scottrohe

yes, you understand me now 🙂 thats exactly what im trying to do. if you want me to walkthrough, i will jsut let me know.

scottrohe

ok so heres what im at. it works EXCEPT for the fact that it only grabs 1 column from the database.. so instead of the array coming out like [0]=1 [1]=2 it comes out [0]=1 and thats it. what am i doing wrong?

    

$sqlfavc = mysql_query("SELECT favid FROM favorites WHERE username='$session->username'");
	$ss=mysql_fetch_row($sqlfavc);
	foreach ($ss as $key){
	if($key == $hl_id){
$exists='false';
}
else {
$exists='true';
}