error inserting values

[thread_PHP]

<?php
$csvfilename=$_FILES['userfile']['name'];


$target_path = "c:/EasyPHP/www/eCoupoun/";

$target_path = $target_path . basename( $_FILES['userfile']['name']); 

if(move_uploaded_file($_FILES['userfile']['tmp_name'], $target_path)) {
    echo "The file ".  basename( $_FILES['userfile']['name']). " has been uploaded";
} else{
    echo "There was an error uploading the file, please try again!";
}


$skipfirstline = true; 
$delimiter = ','; 

include('adodb/adodb.inc.php');

$db = ADONewConnection('MySQL'); # eg. 'mysql' or 'oci8' 
$db->debug = true;
$db->Connect('localhost', 'root', 'sachi', 'ecoupon');

$handle = fopen($csvfilename, "r"); 

while (($data = fgetcsv($handle, 1000, $delimiter)) !== FALSE) { 
    if ($skipfirstline == true) { 
        $skipfirstline = false; 
        continue; 
    } 


    // prepare for inserting to database 
foreach (array_keys($data) as $v) 
    $data[$v] = mysql_real_escape_string($data[$v]); 

//$values = implode("','",$data);
//	$values = '[e-mail]';
	foreach($data as $values){
		$values=implode(",",$data);
echo 		'INSERT INTO couponemail(email)'.'VALUES('."$values".')';



	$query= $db->Execute('INSERT INTO couponemail(email)'. 'VALUES('."$values".')'); }
die;

//	$query = $db->Execute('INSERT INTO couponemail('.$values.')'. 'VALUES ('$values')');

 //  $query=$db->Execute('INSERT INTO couponemail VALUES($values)');
//	$query = "INSERT INTO couponemail VALUES ('".$values."')"; 
	echo "<br>".$query."<br>";

} 

?>

I am getting following error please help me

The file testcsv1.csv has been uploadedINSERT INTO couponemail(email)VALUES(1,[e-mail])

(mysql): INSERT INTO couponemail(email)VALUES(1,[e-mail])

1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '@yahoo.com)' at line 1

adodb_mysql._execute(INSERT INTO couponemail(email)VALUES(1,[e-mail]), false) % line 861, file: adodb.inc.php
adodb_mysql.execute(INSERT INTO couponemail(email)VALUES(1,[e-mail])) % line 46, file: csvindex.php

INSERT INTO couponemail(email)VALUES(1,[e-mail])

(mysql): INSERT INTO couponemail(email)VALUES(1,[e-mail])

1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '@yahoo.com)' at line 1

adodb_mysql._execute(INSERT INTO couponemail(email)VALUES(1,[e-mail]), false) % line 861, file: adodb.inc.php
adodb_mysql.execute(INSERT INTO couponemail(email)VALUES(1,[e-mail])) % line 46, file: csvindex.php

[cbj4074]

You need to quote any literal values you are attempting to insert into the table.

In your first line, for example, you need to quote the values, like this:

... couponemail (email) VALUES ("1", "[e-mail]")

So, you need to modify the way in which you're attempting to create the $values array. If you are going to use explode(), you need to ensure that quotes (in your case, double quotes) are added to each side of the value itself.

$query= $db->Execute('INSERT INTO couponemail (email) VALUES("' . $some_var. '")'); }

Is how the query would work for a single value; since you're using an array of values, you need to quote each value in your array.

I think you had the right idea but botched the execution. You could also use to put some spaces into your queries... why jam it all together and make it illegible?

[thread_PHP]

Thank you cbj4074
for your reply

its working thank you very much

can you please tell me how to insert values from excel file

Thanks in advance