[RESOLVED] foreach not working within a function

Alex_Starnet

Hi,

The following works as expected:

foreach($menuarray as $check)
	{
		echo $check["link"] . '<br>';
	}

but when incorporated into a function:

menu();
function menu()
{
	foreach($menuarray as $check)
	{
		echo $check["link"] . '<br>';
	}
}

doesn't work and an error message is displayed
"Warning: Invalid argument supplied for foreach() in /Library/WebServer/Documents/muscles.php on line 68"

Why?

note: $menuarray is loaded and ready to go, but the foreach statement is where I first mention $check.

Thank you, A.

notaloser

try setting up your array inside the function and see if it fixes your problem..

function menu() 
{ 
$query = mysql_query("SELECT field FROM table");
$menuarray = mysql_fetch_array($query);

foreach($menuarray as $check) 
{ 
    echo $check["link"] . '<br>'; 
} 
}

NogDog

Or pass it as a parameter to the function:

function menu($menuarray)
{
    foreach($menuarray as $check)
    {
        echo $check["link"] . '<br>';
    }
} 
// usage:
$testArray = ("one", "two", "three");
menu($testArray);

Alex_Starnet

Thank you, It works now!

Is it okay to query each time this function is run, in terms of loading speed that is?

NogDog

If it's going to be used multiple times, then I'd suggest using my method of supplying it as a function parameter instead of redundant calls to the database.

Alex_Starnet

Nogdog, that works also! Thanks to both of you... I love this stuff.

Now I need to figure out how to label this post as resolved.

NogDog

Click the "Thread Tools" drop-down just above the first post, and select the "Mark Thread Resolved" option.