[RESOLVED] php sessions (in login script)

thinkgfx

this is my login page

<?
require("sys/func.php");
session_start();

if(isset($_POST[lsubmit])) {
	$username = $_POST[uname];
	$q = mysql_query("SELECT * FROM Users WHERE userName='$username' and password='$_POST[password]'");
	$str = mysql_fetch_object($q);
	if($str) {
		$_SESSION['user']=$str->userName;
		header("Location: index.php");
	}
	else {
		echo "Username and password did not match";
	}
}
?>

Then on index.php, I have this:

<?
require("sys/func.php");
session_start()
if(isset($_SESSION['user'])) {
echo "Logged in as $_SESSION['user']";
}
else {
echo "please login";
}
?>

It tells me
Logged in as Array

Why as Array? Then if I refresh the page, I just get "Logged in as " and nothing more.

Why is this?

PHP Version - 5.1.4

Thanks

bradgrafelman

Couple of things..

Array indeces in your case should be strings. $row[name] does not have a string as an index, but a constant. PHP will detect this (assuming there actually isn't a constant named 'name') and throw an E_WARNING and then assume it is a string. So, use quotes: $row['name'].
Arrays, more specifically items in arrays referenced by indeces, should not simply appear inside a double-quoted string. If they do, they should be wrapped in braces ( {} ). Instead, I usually escape out of the string and concatenate the array in the middle, like so:
```
echo 'Your name is: ' . $row['name'] . '! Hello there.';
```
Don't do a SELECT * if you're not going to use all of the columns in MySQL. In your case, you're only using 1 column, so select that column only.
Try commenting out the header() redirect on the login page and echo out $_SESSION['user'] after you set it. What does it say? If it still says Array, try using [man]print_r/man to get a look at this array.

thinkgfx

I tried those methods you told me, but it still not working.

bradgrafelman

And what is the answer to my question posed in step 4?

thinkgfx

yes yes, the problem basicly is like PHP is forgeting the value of $SESSION['user'] after refreshing the page. It works for the first time, but when I refresh, $SESSION['user'] is still set, but the value is null.

HalfaBee

Use session_write_close() before the header().

I think I will put that in my sig. <sigh>

thinkgfx

HalfaBee wrote:
Use session_write_close() before the header().

I think I will put that in my sig. <sigh>

you mean so it is is

session_write_close();
header("Location index.php");
}

i tried that but it did not work.

tbobker

session_start() must be the very first line! That should work.

bradgrafelman

tbobker wrote:
session_start() must be the very first line!

No, not really. Just needs to be called before any data is outputted...

thinkgfx

tbobker wrote:
session_start() must be the very first line! That should work.

I also tried that.

I figured the problem has to be with my host. I installed the script in XAMPP and it works perfectly fine.

Thanks everyone.

HalfaBee

$_SESSION['user']=$str->userName;

case is different for username.

thinkgfx

I know, the row name is userName