&amp; symbol wont work in URLs

& symbol wont work in URLs

David_McKim

Here is my entire header page

<?php

if( !defined('IN_SITE') )
{
	exit;
}

if( !defined('NO_ACCEPT_XHTML_HEADER') )
{
	/* Accept-header Code by NeoThermic (www.neothermic.com). Modified as needed by MHobbit or David McKim. */

$accept_header = explode( ',', $_SERVER["HTTP_ACCEPT"]);

$xhtml_value = preg_grep( '/^application\/xhtml\+xml(;q=(0\.\d{1,5}|1\.0|[01]))?$/i', $accept_header);
$xhtml_value = array_values($xhtml_value); // reset the keys

if (count($xhtml_value) == 0)
{
	$xhtmlxml = floatval(0.0); //if you're not specified anywhere, you don't support it
}
else
{
	// now parse the XHTML value found for any q-value
	if ( strpos($xhtml_value[0], 'q') === FALSE )
	{
		// with no q-value explicitly set, then your XHTML support is 1
		$xhtmlxml = floatval(1.0);
	}
	else
	{
		// with one specified, lets obtain it
		$qloc = strpos($xhtml_value[0], 'q');
		$qvalue = substr($xhtml_value[0], $qloc + 2 ); //we add two to skip past the = sign
		$xhtmlxml = floatval($qvalue);
	}
}

//now do the above but for text/html
$html_value = preg_grep( '/^text\/html(;q=(0\.\d{1,5}|1\.0|[01]))?$/i', $accept_header);
$html_value = array_values($html_value); //reset the keys

if (count($html_value) == 0)
{
	$texthtml = floatval(0.0); // if you're not specified anywhere, you dont' support it
}
else
{
	// now parse the HTML value found for any q-value
	if ( strpos($html_value[0], 'q') === FALSE )
	{
		// with no q-value explicitly set, then your HTML support is 1
		$texthtml = floatval(1.0);
	}
	else
	{
		// with one specified, let's obtain it
		$qloc = strpos($html_value[0], 'q');
		$qvalue = substr($html_value[0], $qloc + 2 ); // we add two to skip past the = sign
		$texthtml = floatval($qvalue);
	}
}

if ($xhtmlxml > $texthtml || ($xhtmlxml == $texthtml && $texthtml > 0))
{
	header("Content-type: application/xhtml+xml");
}
else

{
	header("Content-type: text/html");
}
}

?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" lang="en" xml:lang="en">
	<!-- GWP Site -->
	<!-- Copyright (c) 2006 GarbageWars Productions. All rights reserved. -->
	<!-- http://www.garbagewars.com -->
	<head>
		<title><?php echo PAGE_TITLE; ?></title>

	<link rel="stylesheet" type="text/css" href="./css/main.css" />
	<link rel="stylesheet" type="text/css" href="./css/advertise.css" />
	<link rel="stylesheet" type="text/css" href="./css/art.css" />
	<link rel="stylesheet" type="text/css" href="./css/comics.css" />
	<link rel="stylesheet" type="text/css" href="./css/contacts.css" />
	<link rel="stylesheet" type="text/css" href="./css/donate.css" />
	<link rel="stylesheet" type="text/css" href="./css/fanwork.css" />
</head>

<body>
	<div id="wrapper">
		<div id="header" align="center">
			<div id="topmenu">
				<ul>
					<li class="first-li">
					<a href="http://www.garbagewars.com"><img src="./images/site/buttons/home.png" alt="Home" /></a></li>
					<li><a href="./comics.php"><img src="./images/site/buttons/comics.png" alt="Comics" /></a></li>
					<li><a href="./art.php"><img src="./images/site/buttons/art.png" alt="Art" /></a></li>
					<li><a href="./shop/"><img src="./images/site/buttons/shop.png" alt="Shop" /></a></li>
					<li><a href="./extras.php"><img src="./images/site/buttons/extras.png" alt="Extras" /></a></li>
					<li><a href="./contacts.php"><img src="./images/site/buttons/contacts.png" alt="Contacts" /></a></li>
					<li><a href="./links.php"><img src="./images/site/buttons/links.png" alt="Links" /></a></li>
				</ul>
			</div>
		</div>

		<div id="gutter"></div>

I read that this code should fix my problem...

// set your charset in $mycharset
        header("Content-type: text/html; charset=&amp");

After applying the code, it allows the link to show properly. However, it screws up the font size of my other links and it also (for some reason) pushes the page down in the content area of both art.php and contact.php as if there were like 9 <br /> in the code

Here is an image of what I am talking about after applying the code...

http://img96.imageshack.us/img96/5538/untitled1sr0.png

If I do not use the above code to get the urls to work with the "&" (&amp) symbol, but keep the & symbol in the url, then I get this error...

http://www.garbagewars.com/art.php

I didn't code the header file and I just recently started learning php, I hope someone can help me.

-David

Rodney_H_

David,

I believe your "charset" is invalid.

Maybe try something like this:

<?php
header("Content-type: text/html; charset=UTF-8");
?>

OR, if there really is a value for your variable, $mycharset, then USE it:

<?php
header("Content-type: text/html; charset=" . $mycharset);
?>

David_McKim

Sorry that didn't help, it does the same thing and screws up my pages.

no the mycharset is not a value, it's just supposed to help or so I've read. (After setting the charset like I did above ^ to &amp.)

I hope someone out there can help me fix this problem T_T

Rodney_H_

David,

What exactly are you hoping to accomplish with all the PHP code prior to the HTML output in your header? I am not sure, but if it is merely to determine if the content type is HTML versus XHTML then it seems redundant (and a lot of work) with the fact that you have a DTD in your HTML.

I would delete all of that and see how your page looks:

<?php
if( !defined('IN_SITE') ) exit;
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" lang="en" xml:lang="en">
	<!-- GWP Site -->
	<!-- Copyright (c) 2006 GarbageWars Productions. All rights reserved. -->
	<!-- http://www.garbagewars.com -->
	<head>
		<title><?php echo PAGE_TITLE; ?></title>

	<link rel="stylesheet" type="text/css" href="./css/main.css" />
	<link rel="stylesheet" type="text/css" href="./css/advertise.css" />
	<link rel="stylesheet" type="text/css" href="./css/art.css" />
	<link rel="stylesheet" type="text/css" href="./css/comics.css" />
	<link rel="stylesheet" type="text/css" href="./css/contacts.css" />
	<link rel="stylesheet" type="text/css" href="./css/donate.css" />
	<link rel="stylesheet" type="text/css" href="./css/fanwork.css" />
</head>

<body>
	<div id="wrapper">
		<div id="header" align="center">
			<div id="topmenu">
				<ul>
					<li class="first-li">
					<a href="http://www.garbagewars.com"><img src="./images/site/buttons/home.png" alt="Home" /></a></li>
					<li><a href="./comics.php"><img src="./images/site/buttons/comics.png" alt="Comics" /></a></li>
					<li><a href="./art.php"><img src="./images/site/buttons/art.png" alt="Art" /></a></li>
					<li><a href="./shop/"><img src="./images/site/buttons/shop.png" alt="Shop" /></a></li>
					<li><a href="./extras.php"><img src="./images/site/buttons/extras.png" alt="Extras" /></a></li>
					<li><a href="./contacts.php"><img src="./images/site/buttons/contacts.png" alt="Contacts" /></a></li>
					<li><a href="./links.php"><img src="./images/site/buttons/links.png" alt="Links" /></a></li>
				</ul>
			</div>
		</div>

		<div id="gutter"></div>

David_McKim

I didn't code it, a friend that I can't seem to get a hold of did.

I can't do that, if I do then I lose all of my css files that are defined for each page, plus I lose my entire menu bar for the site.

This is very complex code, there has got to be someone out there that knows what I can do to fix this :bemused:

Rodney_H_

David McKim wrote:
I didn't code it, a friend that I can't seem to get a hold of did.

I can't do that, if I do then I lose all of my css files that are defined for each page, plus I lose my entire menu bar for the site.

This is very complex code, there has got to be someone out there that knows what I can do to fix this :bemused:

I am NOT saying to scrap the entire file. Look at the code sample in my last post.

I am saying you are doing a lot of work to figure out what content-type to use, that I say/think is redundant with the DTD in the HTML section OF the header file.

David_McKim

Rodney H. wrote:
I am NOT saying to scrap the entire file. Look at the code sample in my last post.

I am saying you are doing a lot of work to figure out what content-type to use, that I say/think is redundant with the DTD in the HTML section OF the header file.

Oh I see, the way it was worded above I thought you meant get rid of it all.

Im sorry I didn't reply to this earlier, I just recently upgraded my pc.

I did as you said, however the error doesn't change, then I noticed if I use Corel it works (but looks screwed up) but if I use my default browser Mozilla, I just see the XML Error that was created by the fact that the page doesn't like the "&" symbol in one of my links.

NogDog

In order for your [X]HTML mark-up to be valid, any place you want an ampersand in your output, including url's within link tags, you need to use the & character entity:

<a href="http://www.site.com/page.php?foo=1[color=red]&amp;[/color]bar=2">link</a>

David_McKim

NogDog wrote:
In order for your [X]HTML mark-up to be valid, any place you want an ampersand in your output, including url's within link tags, you need to use the & character entity:
<a href="http://www.site.com/page.php?foo=1[color=red]&amp;[/color]bar=2">link</a>

Hi, thank you for helping me. I tried that once but forgot the ; at the end. Thanks, that part is fixed, but I have another huge problem.