Thumbnail generation script problem

george_newb

hi all,
I'm using the script below to generate thumbnail of pictures,and copy them to a folder.The problem is the script supports only jpeg files.Can anyone give some info of how I can add support to other formats as well?

Thumbnail generation script:

<?
$im_file_name = '/original_file/' . $_FILES['userfile']['name'];
$image_attribs = getimagesize($im_file_name);
$im_old = imageCreateFromJpeg($im_file_name); 

$th_max_width = 90;
$th_max_height = 90;
$ratio = ($width > $height) ? $th_max_width/$image_attribs[0] : $th_max_height/$image_attribs[1];
$th_width = $image_attribs[0] * $ratio;
$th_height = $image_attribs[1] * $ratio;
$im_new = imagecreatetruecolor($th_width,$th_height);
imageAntiAlias($im_new,true);

$th_file_name = '/thumbnails/' . $_FILES['userfile']['name'];
imageCopyResampled($im_new,$im_old,0,0,0,0,$th_width,$th_height, $image_attribs[0], $image_attribs[1]);
imageJpeg($im_new,$th_file_name,100);

?>

bradgrafelman

You could try getting the type of the image and use the appropriate function. For example, you'd replace the 4th line ($im_old = ...) with this:

$info = getimagesize($im_file_name);
if(in_array( $info[2], array('GIF', 'PNG', 'WBMP', 'XBM') ))
	$im_old = call_user_func('imageCreateFrom' . $info[2], $im_file_name);
elseif($info[2] == 'JPG')
	$im_old = imageCreateFromJpeg($im_file_name);
else
	die('Source image is of unknown type!');

Later, replace the line that outputs the JPEG image using [man]imageJpeg/man with this:

(($info[2] == 'JPG') ? imageJpeg($im_new, $th_file_name, 100) : call_user_func('image' . $info[2], $im_new, $th_file_name));

EDIT: This code is untested - it may or may not work, you'll have to try it and see.

george_newb

I added the code you suggested but i think I'm doing something wrong,the original image is uploaded correctly but the thumbnail is not created and I get the "Source image is of unknown type!" error.

new version of the script:

<?
$im_file_name = '/original_pic/' . $_FILES['userfile']['name'];
$image_attribs = getimagesize($im_file_name);
 $info = getimagesize($im_file_name);
if(in_array( $info[2], array('GIF', 'PNG', 'WBMP', 'XBM') ))
    $im_old = call_user_func('imageCreateFrom' . $info[2], $im_file_name);
elseif($info[2] == 'JPG')
    $im_old = imageCreateFromJpeg($im_file_name);
else
    die('Source image is of unknown type!'); 

$th_max_width = 90;
$th_max_height = 90;
$ratio = ($width > $height) ? $th_max_width/$image_attribs[0] : $th_max_height/$image_attribs[1];
$th_width = $image_attribs[0] * $ratio;
$th_height = $image_attribs[1] * $ratio;
$im_new = imagecreatetruecolor($th_width,$th_height);
imageAntiAlias($im_new,true);

$th_file_name = '/thumbs/' . $_FILES['userfile']['name'];
imageCopyResampled($im_new,$im_old,0,0,0,0,$th_width,$th_height, $image_attribs[0], $image_attribs[1]);
(($info[2] == 'JPG') ? imageJpeg($im_new, $th_file_name, 100) : call_user_func('image' . $info[2], $im_new, $th_file_name));

chmod($th_file_name,0777)
?>

bradgrafelman

Uh.. few things that I didn't catch the first time:

In your _file_name paths, you're beginning with a forward slash. I really doubt the folders are on the root of the server's hard drives. You might want to fix those paths.
You said that the original image uploads correctly... but I don't see any call to [man]move_uploaded_file/man or anything of that nature. How are images getting to their destination directory after the file upload?
I didn't realize you were already using [man]getimagesize/man, so you can remove my line that sets $info and change references of $info to $image_attribs instead.

george_newb

yeah I know about the path,it's not the real path.
The files are moved to a directory using this🙁from another script):

copy($HTTP_POST_FILES['userfile']['tmp_name'], $path .
$HTTP_POST_FILES['userfile']['name']);

I tried the changes,but I still get the same error.

script:

<?
$im_file_name = '/original_pic/' . $_FILES['userfile']['name'];
$image_attribs = getimagesize($im_file_name);

if(in_array( $image_attribs[2], array('GIF', 'PNG', 'WBMP', 'XBM') ))
    $im_old = call_user_func('imageCreateFrom' . $image_attribs[2], $im_file_name);
elseif($image_attribs[2] == 'JPG')
    $im_old = imageCreateFromJpeg($im_file_name);
else
    die('Source image is of unknown type!'); 

$th_max_width = 90;
$th_max_height = 90;
$ratio = ($width > $height) ? $th_max_width/$image_attribs[0] : $th_max_height/$image_attribs[1];
$th_width = $image_attribs[0] * $ratio;
$th_height = $image_attribs[1] * $ratio;
$im_new = imagecreatetruecolor($th_width,$th_height);
imageAntiAlias($im_new,true);

$th_file_name = '/thumbs/' . $_FILES['userfile']['name'];
imageCopyResampled($im_new,$im_old,0,0,0,0,$th_width,$th_height, $image_attribs[0], $image_attribs[1]);
(($image_attribs[2] == 'JPG') ? imageJpeg($im_new, $th_file_name, 100) : call_user_func('image' . $info[2], $im_new, $th_file_name));

chmod($th_file_name,0777)
?>

george_newb

Any ideas?