Help with a function

mark707

Hi all

I am trying to adapt some code that was written for another website application, I don't know too much about PHP so be gentle with me, could anyone tell me why the following function is not working?

function narrowcountry_options($country = ''){
$html = "";
$sql = "SELECT DISTINCT country FROM avmain where activated='yes' and category='$category' and subcat='$subcat' ORDER BY country";
$dataSet = $this->query($sql);
foreach ($dataSet as $dataRow){
$html .= "<option";
if ($dataRow[country] == $country) $html .= " selected='selected' ";
$html .= " value='".$dataRow[country]."'>".$dataRow[country]."</option>";
}
echo $html;
}

Many thanks
Mark

laserlight

How does it not work?

mark707

i am trying to use it to populate a selection box using:

<select name="select" style="height: 18px; width: 130px; color: #000000; font-size: 9pt;" onChange="location.href = 'directoryresults1.php?category=<?=$REQUEST['category']?>&subcat=<?=$REQUEST['subcat']?>&country='+this.options[this.selectedIndex].value;">

<option>Please Select</option>
<? $dbaccess->narrowcountry_options($_REQUEST['country']); ?>
</select>

it doesn't seem to want to though.

the only things I have changed in the original function are:

category='$category' and subcat='$subcat'

thanks for any help

mark

bad76

And what don't works?
what is the current output?