Help with include function

Andy_Pugh

🙂 HI Guys,

I'm hoping I can explain this in an effective way, it's kind of a long winded request that i'm hoping someone can help me with, I have at the moment - 3 PHP scripts .. 1 for album reviews, 1 for videos and 1 for artist biographys - at the moment I have it setup so when your in either, it will put 2 iframes at the bottom . for example - one linking to http://www.bangorfm.co.uk/albuminclude.php?cdartist=Aerosmith and one linking to http://www.bangorfm.co.uk/videoinclude.php?videoartist=Aerosmith

These include on this page http://www.bangorfm.co.uk/artistsread.php?newsid=13&cdartist=Aerosmith

I've done it using a simple url carrying function sending aerosmith from cdartist= to videoartist= etc

However, what I would like to do as opposed to using Iframes is have it include on the page, so when there is no linked album, it won't show a big white space!

The code I currently use on albuminclude.php is as follows

<?
if ($newsid == "") {
$sql="SELECT * FROM cdreview WHERE cdartist LIKE '" . $_GET["cdartist"] . "%'ORDER BY cdartist ASC";

$result=mysql_query($sql);
$ncount=0;
echo "<font size=1> </font>";
while ($myrow=mysql_fetch_array($result)) {
if ($ncount<100)
{
$ncount=$ncount+1;
$cdreview = str_replace("\'", "'", $cdreview);
?>

I have used the get cdartist function so it just reads from the URL that the iframe is sent too, what I would like to know is how I can include this file without having to use iframes and it still select the CD artist or Video.

It's hard to explain! Let me know if you need any more detail, thanks guys 🙂

Andy

liquorvicar

You could just write a function to output the album if one exists, or nothing if there isn't one. On each page that calls the album include, you can just call the function rather than using an iframe.

btw, 2 suggestions; you may well be better off referring to artists by id numbers rather than their names. You may well need to create a separate artist table to do this, depending on your db structure.
You should definitely read up on escaping any input (especially $GET and $POST) data. Code like this:

$sql="SELECT * FROM cdreview WHERE cdartist LIKE '" . $_GET["cdartist"] . "%'ORDER BY cdartist ASC";

is potentially very dangerous. At the very least you should wrap your $_GET data in mysql_real_escape_string