Passing variables in this code?

[rockofaith]

I need to find out how to pass the variables from this page

http://stu.aii.edu/~jas5317/php/register.php , with php code

ini_set ('display_errors', 1);
error_reporting (E_ALL & ~E_NOTICE);


if ( isset ($_POST['submit'])) {

$problem = FALSE; // No problems so far.

// Check for each value.
if (empty ($_POST['username'])) {
	$problem = TRUE;
	print '<p>Please enter a username!</p>';
}

if (empty ($_POST['first_name'])) {
	$problem = TRUE;
	print '<p>Please enter your first name!</p>';
}

if (empty ($_POST['last_name'])) {
	$problem = TRUE;
	print '<p>Please enter your last name!</p>';
}

if (empty ($_POST['email'])) {
	$problem = TRUE;
	print '<p>Please enter your email address!</p>';
}

if (empty ($_POST['password1'])) {
	$problem = TRUE;
	print '<p>Please enter a password!</p>';
}

if ($_POST['password1'] != $_POST['password2']) {
	$problem = TRUE;
	print '<p>Your password did not match your confirmed password!</p>';
} 
if (!$problem) { // If there weren't any problems...

    header ('location: thankyou4.php');
	exit();

} else { // Forgot a field.

    print '<p>Please try again!</p>';

}

} // End of handle form IF.

print '<div id="leftcontent">';
    print "<h4>Register here to access Fred's Forum and to purchase CD's</h4>";

// Display the form.
print '<form action="register.php" method="post"><p>';

print 'Username: <input type="text" name="username" size="20" value="' . $_POST['username'] . '" /><br />';

print 'First Name: <input type="text" name="first_name" size="20" value="' . $_POST['first_name'] . '" /><br />
Last Name: <input type="text" name="last_name" size="20" value="' . $_POST['last_name'] . '" /><br />
Email Address: <input type="text" name="email" size="20" value="' . $_POST['email'] . '" /><br />';

print 'Password: <input type="password" name="password1" size="20" /><br />
Confirm Password: <input type="password" name="password2" size="20" /><br />
<input type="submit" name="submit" value="Register!" /></p>
</form>';

// Complete the HTML formatting stuff.
print '</div>';  

To this page - http://stu.aii.edu/~jas5317/php/thankyou4.php

With php code

 <?php 
$username = $_POST['username'];
$password = $_POST['password'];
$firstname = $_POST['firstname'];
$lastname = $_POST['lastname'];
$email = $_POST['email'];

print "$name,<br/>";
	print "<br/>";
print "Thank you for your registering.<br/>"; 
print "<br/>";
print "Please make a note of your username <b>$username</b> and your password <b>$password</b>. You will use these to login for entering comments in the forum, to add an entry to the guestbook, and when you're ready to purchase a CD.<br/>";



	

What am I doing wrong?

Thanks

[notaloser]

you see, your variables $_POST['whatever'] on thankyou4.php are not valid anymore when the header location changes pages

in order to pass the variables, you could move all the form processing code over to thankyou4.php, change a few things in the processing to fit of course, and set your <form action="thankyou4.php">.

OR

you could create a session using the variables posted and kill them after they are displayed on thankyou4.php

with your system, i would just do something like this using explode:

//on your first page.. 

$string = $var1.":".$var2.":".$var3;
$_SESSION['registerinfo'] = $string;
header("Location: thankyou4.php");

//and here on thankyou4.php

$registerinfo = $_SESSION['registerinfo'];
$info = explode(":", $registerinfo);

echo $info[0]; //var1 from your prev page
echo $info[1]; //var2 from your prev page
echo $info[2]; //var3 from your prev page

when submitted and there are no problems, a string with the registration information is created (seperating each one with the character ':') and a session is started with the string.
then the location is changed and you explode the session information into the array $info, and you can echo them out as so..

thats probably how i would go about it,
good luck

[notaloser]

here you go.. btw.. why do you have your $_POST['var'] as the values of your html? there will be nothing displayed until you press submit, and when you do.. your location will be changed.. in that case, i just took them out

make sure session_start(); is at the first line of your code

///first page

ini_set ('display_errors', 1); 
error_reporting (E_ALL & ~E_NOTICE); 


if ( isset ($_POST['submit'])) { 

$problem = FALSE; // No problems so far. 

// Check for each value. 
if (empty ($_POST['username'])) { 
    $problem = TRUE; 
    print '<p>Please enter a username!</p>'; 
} 

if (empty ($_POST['first_name'])) { 
    $problem = TRUE; 
    print '<p>Please enter your first name!</p>'; 
} 

if (empty ($_POST['last_name'])) { 
    $problem = TRUE; 
    print '<p>Please enter your last name!</p>'; 
} 

if (empty ($_POST['email'])) { 
    $problem = TRUE; 
    print '<p>Please enter your email address!</p>'; 
} 

if (empty ($_POST['password1'])) { 
    $problem = TRUE; 
    print '<p>Please enter a password!</p>'; 
} 

if ($_POST['password1'] != $_POST['password2']) { 
    $problem = TRUE; 
    print '<p>Your password did not match your confirmed password!</p>'; 
} 
if (!$problem) { // If there weren't any problems... 

    $string = $_POST['username'].":".$_POST['first_name'].":".$_POST['last_name'].":".$_POST['email'].":".$_POST['password1'];
    $_SESSION['registerinfo'] = $string; 
    header("Location: thankyou4.php"); 
    exit(); 

} else { // Forgot a field. 

    print '<p>Please try again!</p>'; 

} 

} // End of handle form IF. 

print '<div id="leftcontent">'; 
    print "<h4>Register here to access Fred's Forum and to purchase CD's</h4>"; 

// Display the form. 
print '<form action="register.php" method="post"><p>'; 

print 'Username: <input type="text" name="username" size="20" /><br />'; 

print 'First Name: <input type="text" name="first_name" size="20" /><br /> 
Last Name: <input type="text" name="last_name" size="20" /><br /> 
Email Address: <input type="text" name="email" size="20" /><br />'; 

print 'Password: <input type="password" name="password1" size="20" /><br /> 
Confirm Password: <input type="password" name="password2" size="20" /><br /> 
<input type="submit" name="submit" value="Register!" /></p> 
</form>'; 

// Complete the HTML formatting stuff. 
print '</div>'; 

// and here on thankyou4.php

<?php 

$registerinfo = $_SESSION['registerinfo']; 
$info = explode(":", $registerinfo); 

$username = $info[0];
$password = $info[4];
$firstname = $info[1];
$lastname = $info[2];
$email = $info[3];

echo $firstname." ".$lastname."<br/>"; 
    echo "<br/>"; 
echo "Thank you for your registering.<br/>"; 
echo"<br/>"; 
echo "Please make a note of your username <b>".$username."</b> and your password <b>".$password."</b>. You will use these to login for entering comments in the forum, to add an entry to the guestbook, and when you're ready to purchase a CD.<br/>";

[rockofaith]

notaloser wrote:

why do you have your $_POST['var'] as the values of your html?

That's just how it was written in my text book.

notaloser wrote:

make sure session_start(); is at the first line of your code

Is that supposed to be on the thankyou4.php page or the register.php page...or both?

Thanks friend :-D

[notaloser]

thats weird that your book would write it like that..

because if you have echo "<input type='text' name='text1' value='".$_POST[text1]."'> then you are saying display the value of what is POSTED in the box on submition as the value of the textbox on loading the page.. but thats ok, you don't need that part.

any time you work with sessions on any page of your website, you will want to keep session_start();, so in this case, you will need it on both pages.