[RESOLVED] converting session_register () to work with PHP 4.2.3 upwards

Rupie

Hello

I have used a code snippet from http://www.triquitips.com/php_scripts/image_gallery_session_iframe.php
on my website.

The code basically uses what was apparently a loophole in pre PHP 4.2.3 to pass session variables to an image switcher. The code in the include "gallery.php" is this:

<?php
// 7 = number of pictures in the folder
session_start();
$id += $add;
if ($id < 1){$id = 7;}
if ($id > 7){$id = 1;}
session_register("id");
?>

with a link to the first picture like this:

<img src="/pathtoimage/image-<?php echo $id; ?>.jpg" alt="" />

There are then two Previous / Next links on the main page like this:

<a href="gallery.php?add=-1" target="iframe"> Prev</a> |
<a href="gallery.php?add=1" target="iframe">Next </a>

It's great, it's simple - but it doesn't work now I've switched hosts to a server running PHP 4.4.2 (with register_globals turned off).

I get an error message saying something about session.bug_compat_42 and
session.bug_compat_warn. The first image displays, but the previous / next links don't work.

I have looked in php.net manual and it says to change to using $_SESSION instead of session_register, which I have tried to do in several different combinations, none of which work. I'm just wondering whether I should give up now as this type of script will NEVER work in 4.4.2, or if there is a workaround / hack, that someone can help out with.

any suggestions are very, very gratefully received.

Cheers,

Rupie

drew010

when you use
$_SESSION['id'] = $id;

you are also doing
<img src="/pathtoimage/image-<?php echo $_SESSION['id']; ?>.jpg" alt="" />
right?

also
$id += $add;
probably has to be changed to
$id += $_GET['add']; //will also want to make sure this is a numeric value

Rupie

Thanks for the quick reply.

Yes, I was using <img src="/pathtoimage/image-<?php echo $_SESSION['id']; ?>.jpg" alt="" /> already but I have now added the:

$id += $_GET['add'];

as you suggested. This is definitely an improvement! I can now switch from the first image to the last and back again, but not loop through the whole set.

Here is my revised code in the gallery.php include:

<?php
//7 = no. of pics in folder
session_start();
$id +=$_GET['add'];
if ($id < 1){$id = 7;}
if ($id > 7){$id = 1;}
$_SESSION['id'] = $id;
?>

I have not changed the Previous / Next links (<a href="gallery.php?add=-1"> and <a href="gallery.php?add=1">) on the main page, though - could that be my problem?

I have also tried explicitly declaring the value of $id (as $id = 0 and $id = 1) but that doesn't work.

Thanks once again for your help.

notaloser

your code looks solid, maybe you should try just declaring $id in the URL and setting up your links using $_GET['id'] directly instead of going through your $add +1 or -1.. cant quite see what is wrong with what you have right now sorry

drew010

$id +=$_GET['add'];
if ($id < 1){$id = 7;}
if ($id > 7){$id = 1;}
$_SESSION['id'] = $id;

change to

$id = (isset($_SESSION['id'])) ? $_SESSION['id'] : 1; //get id
$id +=$_GET['add'];  //add to it

//check it
if ($id < 1){$id = 7;}
if ($id > 7){$id = 1;}

$_SESSION['id'] = $id; //save it again

Rupie

notaloser wrote:
your code looks solid, maybe you should try just declaring $id in the URL and setting up your links using $_GET['id'] directly instead of going through your $add +1 or -1.. cant quite see what is wrong with what you have right now sorry

Sorry to sound stupid, but I don't quite follow.

I replaced $GET ['add'] with $GET['id'], then declared $id in the Prev / Next links (as I think that is what you are suggesting) but it didn't make any difference.

Seems like the $id / $add variable is being passed back to gallery.php but is only working if the resulting number is >7 or <1

Maybe there's something missing in the if statement ? What?

Again, all replies greatly appreciated!

Rupie

drew010,

YOU ARE MY HERO!

Works like a charm, you have just made my (very frustrating) day.

Thank you, thank you, thank you.

Rupie