Need help with resizejpeg

[Paul_Ferrie]

Hi guys,
Spent the past couple of hours tinkering about with this function i got off the php docs.

The code works to a point. Am hoping someone can help me with this final step.
The main image that is resized appears to skew and distort.
What i need is if it does not meet max height or max width then either fill to max height and max or width or crop to.
i also need the same to happen to the thumbnail created.

/**********************************************************
 * function resizejpeg:
 *
 *  = creates a resized image based on the max width
 *    specified as well as generates a thumbnail from
 *    a rectangle cut from the middle of the image.
 *
 *    @dir  = directory image is stored in
 *    @img  = the image name
 *    @max_w = the max width of the resized image
 *    @max_h = the max height of the resized image
 *    @th_w  = the width of the thumbnail
 *    @th_h  = the height of the thumbnail
 *
 **********************************************************/

function resizejpeg($dir, $img, $max_w, $max_h, $th_w, $th_h){
   // get original images width and height
   list($or_w, $or_h, $or_t) = getimagesize($dir.$img);

   // make sure image is a jpeg
   if ($or_t == 2) {

   // obtain the image's ratio
   $ratio = ($or_h / $or_w);

   // original image
   $or_image = imagecreatefromjpeg($dir.$img);

   // resize image
   if ($or_w > $max_w || $or_h > $max_h) {

       // first resize by width (less than $max_w)
       if ($or_w > $max_w) {
           $rs_w = $max_w;
           $rs_h = $ratio * $max_h;
       } else {
           $rs_w = $or_w;
           $rs_h = $or_h;
       }

       // then resize by height (less than $max_h)
       if ($rs_h > $max_h) {
           $rs_w = $max_w / $ratio;
           $rs_h = $max_h;
       }

       // copy old image to new image
       $rs_image = imagecreatetruecolor($rs_w, $rs_h);
       imagecopyresampled($rs_image, $or_image, 0, 0, 0, 0, $rs_w, $rs_h, $or_w, $or_h);
   } else {
       $rs_w = $or_w;
       $rs_h = $or_h;

       $rs_image = $or_image;
   }

   // generate resized image
  imagejpeg($rs_image, $dir.$img, 100);

   $th_image = imagecreatetruecolor($th_w, $th_h);

   // cut out a rectangle from the resized image and store in thumbnail
  $new_w = (($rs_w /4));
  $new_h = (($rs_h /4));
	imagecopyresized($th_image, $rs_image, 0, 0, $new_w, $new_h, $rs_w, $rs_h, $rs_w, $rs_h);
	$theName=substr($img, -10,1);    
   // generate thumbnail
   imagejpeg($th_image, $dir.$theName.'_thumb.jpg', 100);

   return true;
   } 

   // Image type was not jpeg!
   else {
       return false;
   }
}
$img = $k."_main.jpg";
resizejpeg($dir, $img, 360,540 , 60, 90);

[bpat1434]

This function does it for me:

function resizeIt($tmpname, $names=array(), $dest=array(), $max=array())
{
	// Has to be uploaded file already, so let's get to it.
	$o_dims = getimagesize($tmpname);
	// $o_dims[0] = image width
	// $o_dims[1] = image height

if($o_dims === false || $o_dims[2] != 2)
	die('There was an error with the image.');

$o_img = imagecreatefromjpeg($tmpname);

$tall = ($o_dims[1] >= $o_dims[0]);

if(empty($max))
{
	$max['thumb'][0] = 250;
	$max['thumb'][1] = 500;
	$max['view'][0] = 500;
	$max['view'][1] = 800;
}

// Define the new proportionate sizes:
$tempsize = ceil($o_dims[1]*$max['thumb'][0]/$o_dims[0]);
if($tall)
{
	if($tempsize > $max['thumb'][0])
	{
		$thumb[0] = $max['thumb'][0];
		$thumb[1] = $tempsize;
	}
	else
	{
		$thumb[0] = $tempsize;
		$thumb[1] = $max['thumb'][1];
	}
}
else
{
	$thumb[0] = $max['thumb'][0];
	$thumb[1] = $tempsize;
}

$tempsize = ceil($o_dims[1]*$max['view'][0]/$o_dims[0]);
if($tall)
{
	if($tempsize > $max['view'][0])
	{
		$view[0] = $max['view'][0];
		$view[1] = $tempsize;
	}
	else
	{
		$view[0] = $tempsize;
		$view[1] = $max['view'][1];
	}
}
else
{
	$view[0] = $max['view'][0];
	$view[1] = $tempsize;
}

// now, just cretae the images ;)
$img_thumb = imagecreatetruecolor($thumb[0], $thumb[1]);
$img_view = imagecreatetruecolor($view[0], $view[1]);

// Copy the old to the new
if(imagecopyresampled($img_thumb, $o_img, 0,0,0,0, $thumb[0], $thumb[1], $o_dims[0], $o_dims[1]) === false)
	die('Image resizing for thumbnail failed.');
if(imagecopyresampled($img_view, $o_img, 0,0,0,0, $view[0], $view[1], $o_dims[0], $o_dims[1]) === false)
	die('Image resizing for full-view failed.');

// Now to write the images permanently:
if(empty($dest))
	$dest = array(
		'thumb' => 'images/thumb/',
		'view'	=> 'images/view/',
	);

if(empty($names))
	$names = array(
		'thumb' => 'thumbnail_'.date('H.i.s_m.d.Y').'.jpg',
		'view'	=> 'view_'.date('H.i.s_m.d.Y').'.jpg',
	);

$new_thumb = $dest['thumb'].$names['thumb'];
$new_view = $dest['view'].$names['view'];

if(@imagejpeg($img_thumb, $new_thumb, 80)===false)
	die('Image saving for thumbnail failed.');
if(@imagejpeg($img_view, $new_view, 80)===false)
	die('Image saving for full-view failed.');

// Show our new images:
echo '
<img src="'.$new_thumb.'" alt="Thumbnail" />&nbsp;&nbsp;&nbsp;
<img src="'.$new_view.'" alt="Full-View" />';

}

You'd call it like so:

resizeIt($_FILES['photo']['tmp_name'], array('thumb' => 'thumb_123.jpg', 'view' => 'view_123.jpg'), array('thumb' => 'images/thumbs/', 'view' => 'images/view/'), array('thumb' => array(250, 500), 'view' => array(500, 800)));

// OR ALTERNATIVELY
$names = array('thumb' => 'thumb_'.date('H.i.s_m.d.Y').'.jpg',
  'view' => 'view_'.date('H.i.s_m.d.Y').'.jpg');
$dest = array('thumb' => 'images/thumbs/',
  'view' => 'images/view/');

$max = array(
  'thumb' => array(250, 500),
  'view' => array(500, 800)
);

resizeIt($_FILES['photo']['tmp_name'], $names, $dest, $max);

[Paul_Ferrie]

if you could help me with the code i have that would be very much apreciatted.

[bpat1434]

I think your math is wrong. Try taking out the $ratio and using the literal equation:

original height * new width / original width

See what that gives you. Note that if the equation gives you a larger number than your max sizes, you need to reverse them (note my example above & below):

        if($tempsize > $max['view'][0])
        {
            $view[0] = $max['view'][0];
            $view[1] = $tempsize;
        }
        else
        {
            $view[0] = $tempsize;
            $view[1] = $max['view'][1];
        }

[Paul_Ferrie]

I didnt write the code and dont really understand the math thats going on 🙁
I do understand what it's supposed to do bu thats about all.

Thanks