system() executing what resembles shell command.

[locomotive]

I have an user defined amount of files (images) being uploaded. They are moved to the appropriate folder for the stock number of the car. I want the image to be resized to a size and then the file copied and resized as a thumbnail.
I am having problems with the resizing of the thumbnail. Also, the first file, which resizes appropriately is being deleted.
I attempted this with commands other than that of $cmdText, but PHP is version 4.2 and has not been compiled with the proper GD.
I don't have any experience using shell commands, but I am assuming that this is one:

$cmdText = "convert -size 320x240 $dir -resize 320x240  +profile '*' $dir ";

Which, seems to work fine with the resizing to 320x240. I would not be suprised if there are unnecessary things in there - I don't know how that works. I copied that line from code that the guy that maintains our servers wrote, I assume that this was his was of getting around the image restrictions of our version of php and gd.

The next $cmdtext is a feeble attempt at hoping that a miracle occurs and the command works. This is for the thumbnail.

convert -size 80x60 $dir -resize 80x60  +profile '*' $thumb_dir 

The key difference here was my assumption that what follows '*' may be the same as the part of move uploaded file, where you say where the file is to be moved.
This is not the case, and therefore I am here hoping someone can help!!

All images will be landscape, and jpeg.

A relevant portion of the code I am using is:

for($i = 1; $i <= $amount; $i++){

		unset($size320);
		unset($name);
		unset($dir);
		unset($directory);
		unset($thumb_dir);

		$name = 'image_' . $i;
		$directory = $directory1 . $name;
		$thumb_dir = $directory1 . $name . '_thumb';
		$dir = $directory . '.jpg';
		$thumb_dir = $thumb_dir . '.jpg';

		if(isset($_FILES[$name])){	//If the file exists

				if (move_uploaded_file($_FILES[$name]['tmp_name'], $dir)){
					$cmdText = "convert -size 320x240 $dir -resize 320x240  +profile '*' $dir ";
					system($cmdText, $cmdStatus);
					unset($cmdText);
					if( $cmdStatus ) {
						$fail[] = 'Could not resize original image to 320x240 ( Image ' . $i . ' )';
						unset($cmdStatus);
					}else{
						$success[] = 'Image ' . $i . ' successfully resized to 320x240.';
						$size320 = 1;
					}						

					if($size320 == 1){

						$cmdText = "convert -size 80x60 $dir -resize 80x60  +profile '*' $thumb_dir ";
						system($cmdText, $cmdStatus);
						unset($cmdText);
						if( $cmdStatus ) {
							$fail[] = 'Could not resize original image to 80x60 ( Image ' . $i . "[$cmdStatus] )";
							unset($cmdStatus);
						}else{
							$success[] = 'Image ' . $i . ' successfully resized to 80x60.';
						}		

					}

					$success[] = 'Image ' . $i . ' Uploaded.';

				}else{

					$fail[] = 'Image ' . $i . ' Not uploaded.';

				}

		}else{

			$errors[] = 'File does not exist.';

		}

	}

Thankyou.
I am sure there are things in the code above that can be done much better, i'm learning.

[jazz_snob]

I find convert better for making thumbs than GD. And usually I get away w/ omitting the +profile "*" entirely. This page helped me http://www-128.ibm.com/developerworks/linux/library/l-graf/

[locomotive]

Ah this has been resolved before a reply has occurred 😉

If anyone is interested, this is the complete code. It works for Postgresql 7.3 (i think 7.3)

<?php 
include('config.php');

dbconnect($site["dbhost"], $site["dblogin"], $site["dbpass"], $site["dbname"], $site["dbport"]);

$errors = array();
$notices = array();

if($_GET['stock_number'] && is_numeric($_GET['stock_number'])){

$stock_no = $_GET['stock_number'];

$query = "SELECT * FROM afs_stock2 WHERE stock_no = '$stock_no'";
$result = pg_exec($query);
if(pg_num_rows($result) == 0){

	$errors[] = 'The car could not be found in stock. Please check the stock number and try again.';

}else{

	$row = pg_fetch_array($result, NULL, PGSQL_ASSOC);

	$nvic = $row['nvic'];
	$yard = $row['yard'];
	$car = $row['year'];
	$car .= ' ' . $row['make'];
	$car .= ' ' . $row['model'];

	unset($result);

}

}

if(isset($_POST['submitted'])){

if(isset($_POST['amount']) && is_numeric($_POST['amount'])){

	$amount = $_POST['amount'];

	$stock_no = $_POST['stock_no'];

}

if(isset($_POST['total']) && is_numeric($_POST['total'])){

	$amount = $_POST['total'];
	$directory1 = '/var/www/html/test/afs_search/image_uploads/' . $stock_no . '/';

	@mkdir("$directory1");

	$stock_no = $_POST['stock_no'];

	$success = array();
	$fail = array();

	for($i = 1; $i <= $amount; $i++){

		unset($size320);
		unset($name);
		unset($dir);
		unset($directory);
		unset($thumb_dir);

		$name = 'image_' . $i;
		$directory = $directory1 . $name;
		$thumb_dir = $directory1 . $name . '_thumb';
		$dir = $directory . '.jpg';
		$thumb_dir = $thumb_dir . '.jpg';

		if(isset($_FILES[$name])){	//If the file exists

				if (move_uploaded_file($_FILES[$name]['tmp_name'], $dir)){
					$cmdText = "convert -size 320x240 $dir -resize 320x240  +profile '*' $dir ";
					system($cmdText, $cmdStatus);
					unset($cmdText);
					if( $cmdStatus ) {
						$fail[] = 'Could not resize original image to 320x240 ( Image ' . $i . ' )';
						unset($cmdStatus);
					}else{
						$success[] = 'Image ' . $i . ' successfully resized to 320x240.';
						$size320 = 1;
					}						

					if($size320 == 1){

						exec("cp -r $dir $thumb_dir");

						$cmdText = "convert -size 80x60 $thumb_dir -resize 80x60  +profile '*' $thumb_dir ";
						system($cmdText, $cmdStatus);
						unset($cmdText);
						if( $cmdStatus ) {
							$fail[] = 'Could not resize original image to 80x60 ( Image ' . $i . "[$cmdStatus] )";
							unset($cmdStatus);
						}else{
							$success[] = 'Image ' . $i . ' successfully resized to 80x60.';
						}

					}

					$success[] = 'Image ' . $i . ' Uploaded.';

				}else{

					$fail[] = 'Image ' . $i . ' Not uploaded.';

				}

		}else{

			$errors[] = 'File does not exist.';

		}

	}

}

}

include('header.html');

?>
<div id="content">
<p><br /><p>
<h1>Upload and size images</h1>
<?php

if(!empty($errors)){

echo '<h2 class="error">Error</h2>';

foreach($errors as $msg){

	echo '<p class="error">' . $msg . '</p>';

}

}

if(!empty($success)){

echo '<h2>Success</h2>';

foreach($success as $msg){

	echo '<p>' . $msg . '</p>';

}

}

if(!empty($fail)){

echo '<h2 class="error">Failure</h2>';

foreach($fail as $msg){

	echo '<p class="error">' . $msg . '</p>';

}

}

if($amount){

echo '<form class="awesome" action="' . $PHP_SELF . '" method="post" enctype="multipart/form-data">
	  <div>
	  <p>Browse and find the files you wish to upload, and then click upload.</p>';

for($i = 1; $i <= $amount; $i++){

	echo '<label for="image_' . $i . '">Image ' . $i . '</label>
		  <input type="file" id="image_' . $i . '" name="image_' . $i . '" /><br />';

}

echo '</select><br />
		<input type="hidden" value="524288" name="MAX_FILE_SIZE" />
		<input type="hidden" value="submitted" name="submitted" />
		<input type="hidden" value="' . $stock_no . '" name="stock_no" />
		<input type="hidden" value="' . $amount . '" name="total" />
		<input type="submit" value="Upload" name="upload" /><br />
		<input type="reset" value="Reset" name="reset" />
		</div>
	  </form>';

}	  

if($_GET['stock_number']){

$stock_no = $_GET['stock_number'];

echo '<form class="awesome" action="' . $PHP_SELF . '" method="post">
		<p>Are you sure you want to upload photos for the ' . $car . ' located at ' . $yard . ' with nvic code ' . $nvic . '?</p>
		<div>
		<label for="amount">How many images to upload?</label>
		<select name="amount">';

for ($i = 1; $i <= 12; $i++){

			echo '<option value="' . $i . '">' . $i . '</option>';

}

echo '</select><br />
		<input type="hidden" value="submitted" name="submitted" />
		<input type="hidden" value="' . $stock_no . '" name="stock_no" />
		<input type="submit" value="Search" name="search" /><br />
		<input type="reset" value="Reset" name="reset" />
		</div>
	  </form>';

}

?>

<p><br /></p></div>
<?php include('footer.html'); ?>

[locomotive]

Thanks for the link mate, thats perfect.