[RESOLVED] drop down list from DB wont work!

[msimonds]

Not sure what I am doing wrong, I thought that this would work!

<?
         $query = "SELECT `teacher_id`, `teacher_name` FROM teachers ORDER BY `teacher_name`";
         if ($r = mysql_query ($query)) { // Run the query.

// Retrieve and print every record.
      	while ($row = mysql_fetch_array ($r)) {
          		echo "<select name=\"teacher\">";
                echo "<option value=\"{$row['teacher_id']}\">'".{$row['teacher_name']}."'</option>";
                echo "</select>";
      	}

      }
      else
      { // Query didn't run.
      	die ('<p>Could not run query: <b>' . mysql_error() . "</b>. The query was $query.</p>");
      }
     ?>

Can someone give me some direction here, I would appreciate it

Thanks
Mike

[devinemke]

$query = 'SELECT teacher_id, teacher_name FROM teachers ORDER BY teacher_name';
$r = mysql_query($query) or exit(mysql_error());
echo '<select name="teacher">';
while ($row = mysql_fetch_assoc($r))
{
	echo '<option value="' . $row['teacher_id'] . '">' . $row['teacher_name'] . '</option>';
}
echo '</select>';

[msimonds]

Thanks devinmke, works like a charm

I truly appreciate it so much