Contact Form errors

[hikaru]

Hello new friends. Just getting into PHP so I'm sure to be browsing around here quite a bit. Ran into my first problem and was hoping for some help. Simple contact list with multiple EmailTo options. So far I'm getting notices for undefined offset on line 12 and undefined index on line 33, 185, 186 and 187. If at all possible please talk to me like I'm five... without replacing all R's with W's. Thanks.

Code Below

<form method="POST" action="contact_test.php">

<table width="90%" cellspacing="5">
  <tr>
    <td><div align="right">Email To: </div></td>
    <td><select name="emailto">
      <option value="test00" selected><b>General 00</b></option>
      <option value="test01" style="background-color:darkgray;line-height:30px;color:white;"><strong>General 01</strong></option>
    </select></td>
  </tr>
  <tr>
    <td><div align="right">Name:</div></td>
    <td><input id="Name" name="Name" type="text" tabindex="1" size="30" /></td>
  </tr>
  <tr>
    <td><div align="right">Address:</div></td>
    <td><input id="Name" name="Name" type="text" tabindex="2" size="30" /></td>
  </tr>
  <tr>
    <td><div align="right">Address 2: </div></td>
    <td><input id="Name" name="Name" type="text" tabindex="3" size="30" /></td>
  </tr>
  <tr>
    <td><div align="right">Phone:</div></td>
    <td><input id="Name" name="Name" type="text" tabindex="4" size="30" /></td>
  </tr>
  <tr>
    <td><div align="right">Email:</div></td>
    <td><input id="EmailFrom" name="EmailFrom" type="text" tabindex="5" size="30" /></td>
  </tr>
  <tr>
    <td><div align="right">Best Time to Contact You: </div></td>
    <td><input id="Name" name="Name" type="text" tabindex="6" size="30" /></td>
  </tr>
  <tr>
    <td><div align="right">Products/Services of Interest: </div></td>
    <td><input id="Name" name="Name" type="text" tabindex="7" size="30" /></td>
  </tr>
  <tr>
    <td valign="top"><div align="right">Questions or Comments: </div></td>
    <td><textarea name="Message" tabindex="8" rows="10" cols="24" style="width:300px;"></textarea></td>
  </tr>
  <tr>
    <td>&nbsp;</td>
    <td><input type="submit" name="post" id="post" value="&nbsp;Send&nbsp;" />
    <input type="reset" value="&nbsp;Reset&nbsp;" /></td>
  </tr>
</table>
			</form>

PHP file-

<?php

session_start();
//Email Validation
function checkEmail($email) 
{
   if(eregi("^[a-zA-Z0-9_]+@[a-zA-Z0-9\-]+\.[a-zA-Z0-9\-\.]+$]", $email)) 
   {
      return FALSE;
   }

   list($Username, $Domain) = split("@",$email);

   if(@getmxrr($Domain, $MXHost)) 
   {
      return TRUE;
   }
   else 
   {
      if(@fsockopen($Domain, 25, $errno, $errstr, 30)) 
      {
         return TRUE; 
      }
      else 
      {
         return FALSE; 
      }
   }
}


// get posted data into local variables
switch ($_POST['emailto']){
   case "test00":
      $emailto = "[e-mail]";
      break;
   case "test01":
      $emailto = "[e-mail]";
      break;
} 
$EmailFrom = Trim(stripslashes($_POST['EmailFrom'])); 
$Name = Trim(stripslashes($_POST['Name'])); 
$Message = Trim(stripslashes($_POST['Message'])); 

// validation
$validationOK=true;
if(checkEmail($EmailFrom) == FALSE){
$error_msg[] = "Please enter in a valid email address.";
}
if (Trim($Name)==""){
$error_msg[] = "Please enter in a name.";
}
if (Trim($Phone)=="") {
$error_msg[] = "Please enter in a phone number.";
}
if (Trim($Message)==""){
$error_msg[] = "Please enter in a message.";
}
//triggers error message
if ($error_msg) {
$_SESSION['error_msg'] = $error_msg;
header ('Location: default.asp');
exit();
}
//sends email
else {
$Body = "You have a new email from $Name.\n Address\n $Address2\n $Phone\n\n Reply to $EmailFrom.\n $BestTime\n $ProdServ\n\n $Name says,\n $Message";
$success = mail($emailto, $ProdServ, $Body);
}
//redirect to success page
if ($success){
  print "<meta http-equiv=\"refresh\" content=\"0;URL=../contact_success.asp\">";
}
else{
  print "Nothing sent.";
}
?>

And no, I'm not getting an email. Yes, the emails have been changed for the purpose of posting. Originally there was close to 100 options so I've narrowed it to 2 for the sake of this post.

Thanks in advance for any help.

[Roger_Ramjet]

Start by marking which lines are 12, 33, 185, etc - we are not going to sit here and count them.

[hikaru]

Very good point. Sorry about that. Marked the line numbers as XXXX Line ##.

<?php

session_start();
function checkEmail($email) 
{
   if(eregi("^[a-zA-Z0-9_]+@[a-zA-Z0-9\-]+\.[a-zA-Z0-9\-\.]+$]", $email)) 
   {
      return FALSE;
   }

   XXXX LINE 12-- list($Username, $Domain) = split("@",$email);

   if(@getmxrr($Domain, $MXHost)) 
   {
      return TRUE;
   }
   else 
   {
      if(@fsockopen($Domain, 25, $errno, $errstr, 30)) 
      {
         return TRUE; 
      }
      else 
      {
         return FALSE; 
      }
   }
}
 XXXX LINE 33- switch ($_POST['emailto']){
   case "test00":
      $emailto = "[e-mail]";
      break;
   case "test01":
      $emailto = "[e-mail]";
      break;
} 
 XXXX LINE 185- $EmailFrom = Trim(stripslashes($_POST['EmailFrom'])); 
 XXXX LINE 186- $Name = Trim(stripslashes($_POST['Name'])); 
 XXXX LINE 187- $Message = Trim(stripslashes($_POST['Message'])); 

$validationOK=true;
if(checkEmail($EmailFrom) == FALSE){
$error_msg[] = "Please enter in a valid email address.";
}
if (Trim($Name)==""){
$error_msg[] = "Please enter in a name.";
}
if (Trim($Phone)=="") {
$error_msg[] = "Please enter in a phone number.";
}
if (Trim($Message)==""){
$error_msg[] = "Please enter in a message.";
}

if ($error_msg) {
$_SESSION['error_msg'] = $error_msg;
header ('Location: default.asp');
exit();
}

else {
$Body = "New message from $Name.\n Address\n $Address2\n $Phone\n\n Reply to $EmailFrom.\n $BestTime\n $ProdServ\n\n $Name says,\n $Message";
$success = mail($emailto, $ProdServ, $Body);
}
if ($success){
  print "<meta http-equiv=\"refresh\" content=\"0;URL=../contact_success.asp\">";
}
else{
  print "Email could not be sent.";
}
?>

[hikaru]

Anyone at all? If not... thanks anyway. This seems to be a pretty cool board to learn lots of new tricks.

[thorpe]

Where do you define $Username and $Domain? I dont see them within the function. You'll also need to make sure the variable $POST['emailto'] exists before trying to use it, wrap your switch in an if...eg;

if (isset($_POST['emailto'])) {
  switch($_POST['emailto']) {
    // rest of your code
  } // end switch
} // end if

That ought get you started.

ps; your form has 3 fields all named Name.

[bradgrafelman]

thorpe wrote:

ps; your form has 3 fields all named Name.

There's your main problem (though you should also fix the other things thorpe mentioned).

Looks like you copied and pasted the HTML code for the text boxes, but forgot to change the name="" part to reflect the appropriate field names.

[Clarkey_Boy]

thorpe wrote:

ps; your form has 3 fields all named Name.

Not quite correct... there are actually 6 fields called Name, unless I still have not quite sobered up completely (been out celebrating tonight as I got a place at university yesterday (studying web design / computer programming)). The offer was "unconditional" - even if I failed my exams, I got in. They have only looked at the stuff I did for their open day - in html. Since then I have been learning php, half written a couple of forums and am about 2 days away from finishing coding my game in php.

Clarkey Boy

[thorpe]

6 is correct! My bad.