MySQL won't update

bprof

Hi,

I've built a page that has a form sends date to a page called update.php everything in edit page works fine, and the data that it sends to update.php is working just fine(I echoed the results many times and they shown the values that were originally sent).

Now my problem is with the update.php page. And the problem is that this page does not update. Basically it does not do anything except printing that it received the values it should receive from edit page, and says that update was successful, but when I query the database I don't find anything changed. Could you please help me finding out what is going wrong?

Thanks,

Here is the update.php code

 
     <?php
                // Retreiving Form Elements from Form
	$Fname = $_POST['efname'];
	$Mname = $_POST['emname'];
	$Lname = $_POST['elname'];
	$Cell = $_POST['ecell'];

echo $Fname; //print the value from edit page(same value in DB)

   $con = mysql_connect("localhost","test","123");
   if (!$con) {
      die('Could not connect: ' . mysql_error());
   }
   mysql_select_db("users", $con);
   mysql_query("UPDATE list SET fname='$Fname',  mname='$Mname',     lname='$Lname' WHERE cell='$Cell'"); 

  //I tried fname=$Fname AND fname='Fname' nothing changed

  mysql_close($con);

  echo "Record Updated";
?>

bradgrafelman

Have you echo'd out $Cell and made sure that it was correct? Does [man]mysql_error/man return any information? What about [man]mysql_affected_rows/man ?

bprof

bradgrafelman wrote:
Have you echo'd out $Cell and made sure that it was correct?

Yes it shows the right value.

Does [man]mysql_error/man return any information?

No nothing.

What about [man]mysql_affected_rows/man ?

I didn't use this function before.

Thanks a lot.

I used this command

printf("Records deleted: %d\n", mysql_affected_rows());

This is the result I got

Records edited: -1 Record Updated

So I guess nothing were update. :o But why 😕

bradgrafelman

You might try making sure the rows actually exist in the table, like so:

       mysql_select_db("users", $con); 
       $query = 'SELECT COUNT(*) FROM `list` WHERE `cell` = \'' . $Cell . '\'';
       $result = mysql_query($query); 
       echo 'There were <b>' . mysql_num_rows($result) . '</b> rows found.';

If you use the above code snippet before your UPDATE query, what is the result?

EDIT: Also, what column type is the cell column?

bprof

I got this warning when I used mysql_num_rows()

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in C:\wamp\www\users\update.php on line 27

what column type is the cell column?

It's an integer.

I tried also using fname cause it's string but I also got the same result.

bradgrafelman

Okay, if it's an integer, try removing the quotes around it's value - integers should never have quotes around them.

As for the warning, try using this code snippet instead:

       $query = 'SELECT COUNT(*) FROM `list` WHERE `cell`=' . $Cell; 
       $result = mysql_query($query) or die('MySQL Error: ' . mysql_error() . '<hr/>' . $query); 
       echo 'There were <b>' . mysql_num_rows($result) . '</b> rows found.';

bprof

This is the result that I got using the second code

123MySQL Error: No database selectedSELECT COUNT(*) FROM list WHERE cell=123

bradgrafelman

Um.. can you repost your whole code? Did you remove the mysql_select_db() call?

bprof

Here is the full code 😕


<?php

// Retreiving Form Elements from Form
$Fname = $_POST['efname'];
$Mname = $_POST['emname'];
$Lname = $_POST['elname'];
$Cell = $_POST['ecell'];

echo $Mname;

  $con = mysql_connect("localhost","test","123");

  if (!$con) {
  die('Could not connect: ' . mysql_error());
  }

  mysql_select_db("users", $con);

  $query = 'SELECT COUNT(*) FROM list WHERE fname=' . $Mname;
       $result = mysql_query($query) or die('MySQL Error: ' . mysql_error() . '<hr/>' . $query);
       echo 'There were <b>' . mysql_num_rows($result) . '</b> rows found.';  


  mysql_query("UPDATE list SET fname='$Fname', mname=$'$Mname', lname='$Lname', cell='$Cell',  WHERE cell='$Cell'");

  printf("Records edited: %d\n", mysql_affected_rows());

  mysql_close($con);

  echo "Record Updated";

?>

I found an error(lsit insted of list) I corrected it (The code above is the corrected version)

When I ran it I got this result

There were 1 rows found. Records edited: -1 Record Updated

And the update still do nothing 😕

bprof

bradgrafelman,

Thank you very much for your all help, I really appreciate it.

The code working now, my mistake was using fname in the update query insted of Fname.

bradgrafelman

Don't forget to mark the thread resolved (if it has been).