[RESOLVED] how to receive variables from function

bull

this is my functions.php file

function param($kate){

switch ($kate){
case 'a':
	$k = $kate;
	break;
case 'g':
	$k = $kate;
	break;
case 'k':
	$k = $kate;
	break;
default:
	$k = 'dak';
}

$sql = "SELECT * FROM be_param WHERE kate = '$k'";
$result = @mysql_query( $sql );
$row = @mysql_fetch_assoc( $result );

$kat = $row[kate];
return ($kat);
$xxx = $row[xxx];
return ($xxx);
$topimg = $row[topimg];
return ($topimg);
}

this is table param in my database

kate|xxx|topimg

dak | 123 | sos.jpg

i include function file in index.php and call it..

param($kate);
$kat = param($kate);
$xxx = param($kate);
$topimg = param($kate);

echo "$kat $xxx $topimg";

when i execute index.php it prints out "dak dak dak"

why it is so? where is my mistake, why all variables are - 'dak' ?

samudasu

You can't call return 3 times in your function and expect it to give you 3 different values. That's not how return works. What you could do is return an array from the param function like so:

$sql = "SELECT * FROM be_param WHERE kate = '$k'";
$result = @mysql_query( $sql );
$row = @mysql_fetch_assoc( $result );
$arr = array($row['kate'], $row['xxx'], $row['topimg']);
return $arr;

And then call the function:

$val = param($kate);
$kat = val[0];
$xxx = val[1];
$topimg = val[2];

bradgrafelman

Your switch() statement can be shortened to something like:

	switch ($kate){
	case 'a': case 'g': case 'k':
		$k = $kate;
		break;
	default:
		$k = 'dak';
	}

You shouldn't ever do a SELECT * unless you're planning on using every single column in the table. Otherwise, you should name the columns you'll be using, i.e. SELECT kate, xxx, topimg FROM ...
I would agree with samudasu in saying that creating an array would be your best bet here... or else you could just return the entire $row array in the function. Then, you'd use it like so:

$data = param($kate);
echo $data['kat'] . ' -- ' . $data['xxx'] . ' -- ' . $data['topimg'];

bull

thanks to both of you samudasu, bradgrafelman for your advices!