[RESOLVED] updating db not working on form!

msimonds

The edit_student php works perfectly to affect the database table "students" except for one small problem. If I DO NOT change the teacher_id field, it places "0" into that field in the database.

I tried , tried, tried

I know it is something simple, probably just REALLY simple!!.

if I want to keep the same field in the database and not change it, How can I just leave it alone and not change it

echo "<tr><td>Current Teacher:</td><td>";
                                  get_teacher_name($row['teacher_id']);
                            echo "</td></tr>";
                            echo "<tr>
                              <td> New Teacher:</td>
                               <td>";
                                $newteacher_query = 'SELECT teacher_id, teacher_name FROM teachers ORDER BY teacher_name';
                                $s = mysql_query($newteacher_query) or exit(mysql_error());

                            echo '<select name="teacherid">';
                            echo '<option value="">Choose New Teacher</option>';
                            while ($rows = mysql_fetch_array($s))
                            {
                                echo '<option value="' . $rows['teacher_id'] . '">' . $rows['teacher_name'] . ' (Teacher Id = <strong>' .$rows['teacher_id']. ')</strong></option>';
                            }
                            echo '</select></tr>';
                        echo"
                            <td align=\"right\">
                                <input type=\"hidden\" name=\"id\" value=\"{$row['student_id']}\" />
                                <input type=\"submit\" name=\"submit\" value=\"Update this student\" />
                            </td>
                         </tr>

                      </table>
                      <a href=\"view_student.php\">View Current Students</a>
                    </form>";

TIA mike

iNFERiON

Can you also post the part where you UPDATE query gets run ?

msimonds

Sure sir, here is the entire script!!

I appreciate the quick reply:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head>
<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />
<title>New Little Saints &amp; Scholars Site</title>
<style type="text/css" media="all">@import "style.css";</style>
</head>

<body>

<div id="Header"><a href="#">Little Saints &amp; Scholars Site</a></div>

<div id="Content">
<?php
// This script edits an individual students information using an UPDATE query.

// Address error handing.
ini_set ('display_errors', 1);
error_reporting (E_ALL & ~E_NOTICE);

// Connect and select.
//Setup the datbase connection
include("./include/config.php");
include("./include/opendb.php");
include("./include/functions.php");

//setup variables coming from form to edit student information
$student_id     =   $_POST['id'];
$firstname 		= 	$_POST['fname'];
$lastname		=	$_POST['lname'];
$birthday		=	$_POST['bdate'];
$age			=	$_POST['age'];
$address1		=	$_POST['address1'];
$address2		=	$_POST['address2'];
$city			=	$_POST['city'];
$state			=	$_POST['state'];
$zip			=	$_POST['zip'];
$father			=	$_POST['father'];
$mother			=	$_POST['mother'];
$phone 			=	$_POST['phone'];
$teacherid		=	$_POST['teacherid'];



if (isset ($_POST['submit']))
{ // Handle the form.
	// Define the query.
    $query = "UPDATE students SET student_fname = '$firstname', student_lname = '$lastname', student_bdate = '$birthday', student_age = '$age', student_address1 ='$address1', student_address2 = '$address2',
              student_city = '$city', student_state = '$state', student_zip ='$zip', student_father = '$father', student_mother = '$mother', student_contact = '$phone', teacher_id = '$teacherid'
              WHERE student_id=$student_id";


$r = mysql_query ($query); // Execute the query.

// Report on the result.
if (mysql_affected_rows() == 1)
{
	echo '<p>The students information has been updated</p>';
    echo '<a href="index.php">Back To Home</a>';
}
else
{
	//echo "<p>Could update the entry because: <b>" . mysql_error() . "</b>. The query was $query.</p>";
	echo "<p>Could not update the students information becuase you did not change anything <b><br />";
    echo "<input type=button value=\"Go Back and Try Again\" onClick=\"history.go(-1)\">";
}
}
else
{ // Display the entry in a form.

// Check for a valid entry ID in the URL.
if (is_numeric ($_GET['id']) )
{
	// Define the query.
	$query = "SELECT * FROM students WHERE student_id={$_GET['id']}";
    		if ($r = mysql_query ($query)) { // Run the query.
    			$row = mysql_fetch_array ($r); // Retrieve the information.
    			// Make the form.
                 echo "<h1>Edit Students Name and Information:</h1>

                    <form action=\"edit_student.php\" method=\"post\">
                      <table width=\"100%\">
                        <tr>
                          <td>Students First Name:</td>
                          <td><input type=\"text\" name=\"fname\" value=\"{$row['student_fname']}\" size=\"40\" /></td>
                        </tr>
                        <tr>
                          <td>Students Last Name:</td>
                          <td><input type=\"text\" name=\"lname\" value=\"{$row['student_lname']}\" size=\"40\" /></td>
                        </tr>
                        <tr>
                          <td>Birthdate:</td>
                          <td><input type=\"text\" name=\"bdate\" value=\"{$row['student_bdate']}\" size=\"40\" /></td>
                        </tr>
                        <tr>
                          <td>Age</td>
                          <td><input type=\"text\" name=\"age\" value=\"{$row['student_age']}\" size=\"3\" /></td>
                        </tr>
                        <tr>
                          <td>Address 1:</td>
                          <td><input type=\"text\" name=\"address1\" value=\"{$row['student_address1']}\" size=\"40\" /></td>
                        </tr>
                        <tr>
                          <td>Address 2:</td>
                          <td><input type=\"text\" name=\"address2\" value=\"{$row['student_address2']}\" size=\"40\" /></td>
                        </tr>
                        <tr>
                          <td>City:</td>
                          <td><input type=\"text\" name=\"city\" value=\"{$row['student_city']}\" size=\"40\" /></td>
                        </tr>
                        <tr>
                          <td>State:</td>
                          <td><input type=\"text\" name=\"state\" value=\"{$row['student_state']}\" size=\"40\" /></td>
                        </tr>
                        <tr>
                          <td>Zip Code:</td>
                          <td><input type=\"text\" name=\"zip\" value=\"{$row['student_zip']}\" size=\"5\" /></td>
                        </tr>
                        <tr>
                          <td>Father's Name:</td>
                          <td><input type=\"text\" name=\"father\" value=\"{$row['student_father']}\" size=\"40\" /></td>
                        </tr>
                        <tr>
                          <td>Mother's Name:</td>
                          <td><input type=\"text\" name=\"mother\" value=\"{$row['student_mother']}\" size=\"40\" /></td>
                        </tr>
                        <tr>
                          <td>Contact Number</td>
                          <td><input type=\"text\" name=\"phone\" value=\"{$row['student_contact']}\" size=\"40\" /></td>
                        </tr>
                        <tr>";
                        echo "<tr><td>Current Teacher:</td><td>";
                              get_teacher_name($row['teacher_id']);
                        echo "</td></tr><tr>
                          <td> New Teacher:</td>
                           <td>";
                            $newteacher_query = 'SELECT teacher_id, teacher_name FROM teachers ORDER BY teacher_name';
                            $s = mysql_query($newteacher_query) or exit(mysql_error());

                            echo '<select name="teacherid">';
                            echo '<option value="">Choose New Teacher</option>';
                            while ($rows = mysql_fetch_assoc($s))
                            {
                                echo '<option value="' . $rows['teacher_id'] . '">' . $rows['teacher_name'] . ' (Teacher Id = <strong>' .$rows['teacher_id']. ')</strong></option>';
                            }
                            echo '</select>';
                        echo"</tr>
                        <tr>
                            <td align=\"right\">
                                <input type=\"hidden\" name=\"id\" value=\"{$row['student_id']}\" />
                                <input type=\"submit\" name=\"submit\" value=\"Update this student\" />
                            </td>
                      </table>
                      <a href=\"view_student.php\">View Current Students</a>
                    </form>";
    		}
            else
            { // Couldn't get the information.
    			echo "<p>Could retrieve the entry because: <b>" . mysql_error() . "</b>. The query was $query.</p>";
    		}

}
else
{ // No ID set.
	echo '<p><b>You must have made a mistake in using this page.</b></p>';
}

} // End of main IF.

include("./include/closedb.php");

?>
</div>

<div id="Menu">
    <strong>Navigation</strong>
	<p>
	<a href="/school/">Home</a><br />
	<a href="add_student.php">Add Student</a><br />
    <a href="add_teacher.php">Add Teacher</a><br />
	<a href="view_student.php">View Students</a><br />
    <a href="view_teacher.php">View Teachers</a><br />
    <a href="roster.php">View Roster</a>
	</p>
    <p>
    <form action="class_roster.php" method="post"><?
         include("./include/config.php");
         include("./include/opendb.php");
         $query = 'SELECT teacher_id, teacher_name FROM teachers ORDER BY teacher_name';
         $r = mysql_query($query) or exit(mysql_error());
         echo '<select name="teacher_id" onChange="this.form.submit()">';
         echo '<option value="">Choose Teacher</option>';
          while ($row = mysql_fetch_assoc($r))
          {
              echo '<option value="' . $row['teacher_id'] . '">' . $row['teacher_name'] . '</option>';
          }
          echo '</select>';
          include("./include/closedb.php");
         ?></p>

</form>
<br /><br /><br /><br /><br />
</div>

<!-- BlueRobot was here. -->

</body>

</html>

msimonds

I believe it is because the teacher_id coming out of the database is not being populated if I update student information!

I want to be able to place some sort of switch like:

$selected ='';

echo '<select name="teacherid">';
                                echo '<option value="">Choose New Teacher</option>';
                                while ($rows = mysql_fetch_assoc($s))
                                {
                                    echo '<option value="' . $rows['teacher_id'] . '">' . $rows['teacher_name'] . ' (Teacher Id = <strong>' .$rows['teacher_id']. ')</strong></option>';
                                }
                                echo '</select>';

to populate the teacher_id coming from the database with an if statement to check to see if the value is not being changed so that value remains the same if the teacher is not changed

msimonds

I have tried to get this to work with no avail:

I tried these two functions:

function get_teacher_name($idteacher)
{

$query = "SELECT * FROM teachers WHERE teacher_id = $idteacher";

$results = mysql_query($query) or die(mysql_error());

while ($row = mysql_fetch_assoc($results))
{
      //echo "<td>Name:{$t['teacher_name']}</td>\n";
      if ($idteacher == $row['teacher_id'])
      {
          echo "<strong>{$row['teacher_name']}</strong>";
          return $row['$teacher_name'];
      }
}


}

function get_teacher_id($teacherid)
{
    $query = "SELECT * FROM teachers WHERE teacher_id = $teacherid";

$results = mysql_query($query) or die(mysql_error());

while ($row = mysql_fetch_assoc($results))
{
      //echo "<td>Name:{$t['teacher_name']}</td>\n";
      if ($teacherid == $row['teacher_id'])
      {
          return $row['$teacher_id'];
      }
}

}

and then tried to retrieve them and I know that is working because it is returning the name from the teacher and their associated teacher ID

this code has been updated but still is not working

echo "<tr><td>Current Teacher:</td><td>";
                                  $oldteacher = get_teacher_name($row['teacher_id']);
                                  $oldteacher_id = get_teacher_id($row['teacher_id']);
                            echo "</td></tr><tr>
                              <td> New Teacher:</td>
                               <td>";
                                $newteacher_query = 'SELECT teacher_id, teacher_name FROM teachers ORDER BY teacher_name';
                                $s = mysql_query($newteacher_query) or exit(mysql_error());
                                echo '<select name="teacherid">';

                            if ($oldteacherid == $row['teacher_id'])
                            {
                                echo '<option value="' . $rows['teacher_id']. '" selected="selected">' . $rows['teacher_id'] . ' Teacher Id = <strong></option>';
                            }
                            else
                            {
                                while ($rows = mysql_fetch_assoc($s))
                                {
                                    echo '<option value="' . $rows['teacher_id'] . '">' . $rows['teacher_name'] . ' (Teacher Id = <strong>' .$rows['teacher_id']. ') - Not working</strong></option>';
                                    echo $oldteacherid;
                                }
                            }
                            echo '</select>';

you can view that by going here:

http://www.sportsrant.com/school/edit_student.php?id=17

you will notice that in the else statement, I placed not working in the drop down, showing that I am not properly selecting the teacher that is already in the database and assigned to that student

any help would be appreciated!

feel free to update the data, this is only a beta

THANKS IN ADVANCE!

msimonds

I was able to get this corrected myself

Thanks anyway!