Select ID for each value in array

Tezread

So im trying to do an insert of an array of choices made from a listbox. Im coming up with an error message: I would appreciate some assistance.

Notice: Undefined index: orgtype in /disk1/home3/mindseye/public_html/notts_quality/info_resource/infolinks_formhandler.php on line 223

Notice: Undefined index: activity in /disk1/home3/mindseye/public_html/notts_quality/info_resource/infolinks_formhandler.php on line 232

Warning: Invalid argument supplied for foreach() in /disk1/home3/mindseye/public_html/notts_quality/info_resource/infolinks_formhandler.php on line 236

Notice: Undefined variable: vals in /disk1/home3/mindseye/public_html/notts_quality/info_resource/infolinks_formhandler.php on line 242

Warning: implode() [
function.implode
]: Bad arguments. in /disk1/home3/mindseye/public_html/notts_quality/info_resource/infolinks_formhandler.php on line 242

here is my code:

<?php
// add data from form 1

$sql = "INSERT INTO qualityadmin SET qualityadmin_id =  NULL ";
foreach ($_SESSION['form1_data'] as $col =>$val ){
	if($col <> 'submit'){

	if ($col=='orgtype'){
	//ignore and  process later below for seperate table insert
	}
	elseif ($col=='activity'){
	//ignore and  process later below for seperate table insert
	}
			elseif ($col=='expert'){
	//ignore and  process later below for seperate table insert
	}
			elseif ($col=='qualitysystem'){
	//ignore and  process later below for seperate table insert
	}

	else{
	$sql .=", $col = '$val' ";
	}
	}
}

//////////////////////////////////
mysql_query($sql, $connection) or die(mysql_error()); 

//get last insert id
$activityidchosen ="select LAST_INSERT_ID() as id from activity_participant";
$result = mysql_query($activityidchosen, $connection) or die(mysql_error()); 
$row=mysql_fetch_array($result);
$id = $row['id'];
$sql ="select LAST_INSERT_ID() as id from qualityadmin";
$result = mysql_query($sql, $connection) or die(mysql_error()); 
$row=mysql_fetch_array($result);
$id = $row['id'];
//update orgtype_participant table
if($_SESSION['form1_data']['orgtype']){
foreach($_SESSION['form1_data']['orgtype'] as  $fvalue){
		$orgtypeid_sql ="INSERT INTO orgtype_participant SET orgtype_participant_id = NULL , qualityadmin_id = '$id', orgtype = '$fvalue' ";

	mysql_query($orgtypeid_sql, $connection) or die(mysql_error()); 

	}
	}
// insert array of activities chosen 
$activityarray = array ($_POST['activity']); 



foreach( $activityidchosen as $activityid ) 
{ 
   $vals[] = "( {$activityarray}, {$activityid} )" ; 
} 


$sqlVals = implode( ',', $vals ) ; 


$sql = "INSERT INTO activity_participant ( qualityadmin_relid, activity_participant_relid ) VALUES {$sqlVals}" ; 


?>

thankyou very much!!

mjax

This code is so full of constructs that are either useless, unsafe or unlogical, that it's hard to point out a specific fix.

Also, I think you are leaving out code, because the errors are refering to line numbers that aren't in your code.

the whole if...elseif...elseif...elseif could be replaced by a more readable switch or better still, be completely removed by just using those values in $_SESSION['form1_data'] that you need (instead of selecting all elements EXCEPT a few)
You are using the <> operator to compare strings. You should use != (or better still !==)
you are selecting a last generated ID from a table for which there have not been any INSERTS
directly after fetching this ID into the variabel $id you overwrite this by selecting the last generated ID from another table, leaving the first $id useless
I guess you need a activity_participant ID fro inserting into the orgtype_participant table. So you should first add rows to the activity_participant table and then to the related table, so that you can use the proper ID's.
please use escaping on any values you are using in SQL statements to prevent SQL injection

Tezread

I have a table of activities each with unique ids. The user chooses 1 or more activities and the id number of each is stored in another table called activity_participant.

here is what i have so far. the bit i get stuck on is inserting the id for each activity chosen into the activity_participant table. I have done something similar in that im selecting the last insert id from the qualityadmin table but i tried doing something similar to that but it wasn t happening

// add data from form 1

$sql = "INSERT INTO qualityadmin SET qualityadmin_id =  NULL ";
foreach ($_SESSION['form1_data'] as $col =>$val ){
	if($col <> 'submit'){

	if ($col=='orgtype'){
	//ignore and  process later below for seperate table insert
	}
	elseif ($col=='activity'){
	//ignore and  process later below for seperate table insert
	}
			elseif ($col=='expert'){
	//ignore and  process later below for seperate table insert
	}
			elseif ($col=='qualitysystem'){
	//ignore and  process later below for seperate table insert
	}

	else{
	$sql .=", $col = '$val' ";
	}
	}
}

//////////////////////////////////
mysql_query($sql, $connection) or die(mysql_error()); 


$sql ="select LAST_INSERT_ID() as id from qualityadmin";
$result = mysql_query($sql, $connection) or die(mysql_error()); 
$row=mysql_fetch_array($result);
$id = $row['id'];

// insert array of activities chosen 
$activityarray = array ($_POST['activity']); 

foreach( $activityidchosen as $activityid ) 
{ 
   $vals[] = "( {$activityarray}, {$activityid} )" ; 
} 


$sqlVals = implode( ',', $vals ) ; 


$activity_sql = "INSERT INTO activity_participant ( qualityadmin_relid, activity_participant_relid ) VALUES {$sqlVals}" ; 
$activity_result = mysql_query($activity_sql, $connection) or die(mysql_error()); 

?>

been trying all day on this one!. thx in advance dudes

Tezread

Made little progress on this although im getting close- so far i have an error message unknown column 'Array'. Not sure what to do next please help!!

<?php
// add data from form 1

$sql = "INSERT INTO qualityadmin SET qualityadmin_id =  NULL ";
foreach ($_SESSION['form1_data'] as $col =>$val ){
	if($col <> 'submit'){

	if ($col=='orgtype'){
	//ignore and  process later below for seperate table insert
	}
	elseif ($col=='activity'){
	//ignore and  process later below for seperate table insert
	}
			elseif ($col=='expert'){
	//ignore and  process later below for seperate table insert
	}
			elseif ($col=='qualitysystem'){
	//ignore and  process later below for seperate table insert
	}

	else{
	$sql .=", $col = '$val' ";
	}
	}
}

//////////////////////////////////
mysql_query($sql, $connection) or die(mysql_error()); 

//get the last inserted if from quality admin table
$sql ="select LAST_INSERT_ID() as id from qualityadmin";
$result = mysql_query($sql, $connection) or die(mysql_error()); 
$row=mysql_fetch_array($result);
$id = $row['id'];

// get the id of each chosen activity
$getactivityid ="select LAST_INSERT_ID() as id from activity"; 
$result_activity = mysql_query($getactivityid, $connection) or die(mysql_error()); 
$row=mysql_fetch_array($result_activity); 
$activityid = $row['id']; 

// insert array of activities chosen 
$activityarray = array ($_POST['activity']); 

foreach( $activityarray as $activityid ) 
{ 
   $vals[] = "( {$activityarray}, {$activityid} )" ; 
} 


$sqlVals = implode( ',', $vals ) ; 


$insert_activity = "INSERT INTO activity_participant ( qualityadmin_relid, activity_participant_relid ) VALUES {$sqlVals}" ; 
$insert_activity_result = mysql_query($insert_activity, $connection) or die(mysql_error()); 

?>

Tezread

this thread has been moved- apologies

http://phpbuilder.com/board/showthread.php?t=10328321