[RESOLVED] edit form with combobox

nadirah81

Hello everyone....

I've created a form which include text field, radio button and comboboxes. When user needs to edit the form, it will be loaded with the current values, and user can edit it by changing those values.

The problem is: If the changes is within the combobox, the value selected will be as per the selected one. But if there are no changes within the combobox, when user click submit, it will only save the first word from the combobox.

Below is the coding that I've used:

<tr>
<td><strong>Person In Charge (PIC):</strong></td>
<td width="31%"><select name="pic" onChange="showValue_pic_others();">
<option value=<?php echo "$row[pic]" ?> selected><?php echo "$row[pic]" ?></option>
<option value="Dr. Marina Tan">Dr. Marina Tan</option>
<option value="Ms Amy Masni">Ms Amy Masni</option>
<option>Others</option>
</select></td>
<td width="33%"><div id="pic_others" style="position:relative; z-index:1; visibility:hidden; width: 117px; height: 21px;">
<input type="text" name="pic_others" id="pic_others">
</div></td>
<td> </td>
</tr>

If I didn't edit this combobox, the value that is submitted by the edit form will be the first word "Dr." for "Dr. Marina Tan" and "Ms" for "Ms Amy Masni". Is there anyone who can help me debug this problem? Please....

bradgrafelman

Looks like an HTML issue...

Try adding quote around the first option's value (the one that is generated from PHP variables).

nadirah81

Sorry... I don't get what u mean. Could you give an example or further explaination??

bradgrafelman

Notice how all of your other OPTION elements have double quotes around the VALUE attribute? Now, look at the first OPTION element in your code:

<option value=<?php echo "$row[pic]" ?> selected>

Notice the lack of double quotes surrounding the value?

EDIT: While I'm correcting syntax:

Array indeces in your case should be strings. $row[name] does not have a string as an index, but a constant. PHP will detect this (assuming there actually isn't a constant named 'name') and throw an E_WARNING and then assume it is a string. So, use quotes: $row['name'].
Arrays, more specifically items in arrays referenced by indeces, should not simply appear inside a double-quoted string. If they do, they should be wrapped in braces ( {} ). Instead, I usually escape out of the string and concatenate the array in the middle, like so:
```
echo 'Your name is: ' . $row['name'] . '! Hello there.';
```

nadirah81

Thank you.... It works!!!!

bradgrafelman

Glad I could help. Don't forget to mark the thread resolved.

(Also, just for the sake of archiving, I moved this thread to the ClientSide Technologies forum).

lovesirius12

sorry