[RESOLVED] cant delete cookies?

dknight3

hello there i thought this function was working but i just tried it a second ago and it didnt work! Im trying to delete the cookies, username, and password.

heres the code:

function logout(){
	setcookie('username', $_COOKIE['username'], time() - $GLOBALS['cs_cookielength']);
	setcookie('password', $_COOKIE['password'], time() - $GLOBALS['cs_cookielength']);
	$_COOKIE['password'] = '';
	$_COOKIE['username'] = '';
	echo '1';
}

Installer

Cookies are deleted with "set_cookie()". Details and examples are on the manual page for that function. Your code only unsets the array values on the server.

dknight3

i know your trying to be helpful but wow!

    setcookie('username', $_COOKIE['username'], time() - $GLOBALS['cs_cookielength']);
    setcookie('password', $_COOKIE['password'], time() - $GLOBALS['cs_cookielength']);

did you even read my code at all before posting??

bradgrafelman

I would try just setting the time in the past:

setcookie('username', '', time() - 86400); 
setcookie('password', '', time() - 86400);

Also, can we see the code that you used to create these cookies in the first place? Don't forget, both calls to setcookie() - to create and delete - must be basically identical in parameters.

dknight3

thanks ill give that a try.
for some reason i was thinking that the value had to be identical also to delete it, sont know where i got that from.. lol thank you for reading my post before replying btw.

dknight3

hmm still doeant work... here is the code i use to creat it.

function login(){
	if (!empty($_POST['username']) && !empty($_POST['password'])){
		$username = $_POST['username'];
		$password = $_POST['password'];
		$remember = $_POST['remember'];
		$query = "SELECT * FROM users WHERE username='$username'";
		$result = mysql_query($query);
		$rows = mysql_num_rows($result);
		if($rows>0){
			$db_password = mysql_result($result,0,"password");
			$access_level = mysql_result($result,0,"admin");
			$active = mysql_result($result,0,"active");
			if ($db_password == $password){
				if($active == '1'){
					if($remember == '1'){
						$_COOKIE['username'] = $username;
						$_COOKIE['password'] = $password;		
						setcookie('username', $username, time() + $GLOBALS['cs_cookielength']);
						setcookie('password', $password, time() + $GLOBALS['cs_cookielength']);
						userinfo();
					}else{
						$_COOKIE['username'] = $username;
						$_COOKIE['password'] = $password;
						userinfo();
					}
				}else{
					echo 'Your account has not been activated yet!<br><br><a href="'.$GLOBALS['cs_sitepath'].'functions.php?username='.$username.'&action=sendactivationemail" target="_blank">Re-send activation email</a><br><a href="#" onclick="loginblock();">Go Back</a>';
				}
			}else{
				echo 'Incorrect password!<br><a href="#" onclick="loginblock();">Go Back</a>';
			}
		}else{
			echo 'Username not found!<br><a href="#" onclick="loginblock();">Go Back</a>';
		}
	}else{
		echo 'Please fill in all fields!<br><a href="#" onclick="loginblock();">Go Back</a>';
	}
}

function logout(){
	setcookie('username', '', time() - 3600);
	setcookie('password', '', time() - 3600);
	$_COOKIE['password'] = '';
	$_COOKIE['username'] = '';
	echo '1';
}

bradgrafelman

Is there any chance you could setup a test account and PM me the URL and login info?

dknight3

done

scrypted

Hey, you should look into storing a serialized array into your cookie. This way you can store many values username, password, etc in one cookie instead of many like you have now.

For example,

<?
//Compile array and store values in cookie:

$ScryptedCookies=Array('Username' => $username, 'Password' => $password);
setcookie ("ScryptedCookies", serialize($ScryptedCookies), time() + 3600);

//Then you can refer to these values throughout the script like this:

$ScryptedCookies=unserialize(stripslashes($_COOKIE['ScryptedCookies']));

print $ScryptedCookies['Username'];

//Then to unset the cookie array simply set it back into the past:
setcookie ("ScryptedCookies", serialize($ScryptedCookies), time() -3600);

?>

Just an idea : - )

dknight3

very interesting i will consider that, turns our my script worked in the first place theres just somthing wrong with my firefox.

scrypted

That's odd for it to be a problem with the browser since php is a server side language.

Scripts written in php are usually cross-browser compatible with web browsers, but not cross-server compatible.

You should post the url to your script so we can give you some feed back with whether or not it works in our browsers. For instance, I'm using firefox 1.5.0.6 and would be interested to test the page in FF & IE 7.0.

What version of FF are you running?

Installer

Yes, I did read your code, yes, I did misunderstand it because you were giving a value to the cookie, and yes, I was trying to be helpful. Sometimes I am and sometimes I'm not.

dknight3

its alright man, umm i think firefox is trying to like auto login or somthing im not sure and i dont really care as long as it works for other people.

i cant post the links yet because it is being developed and does not filter user inputs at all. maybe when i get a little farther along on the project i will post you guys a link.

scrypted

It's cool don't worry about it. Although, the popularity of FF is on a rising trend!

bradgrafelman

As per his PM, I tested out the login/logout system in both IE and FireFox, and both browsers worked flawlessly for me.