Who can help me to Improve this function

[c1a1o1]

<?
function thumb($srcFile,$dstFile,$dstW,$thumbdir){
		//$thumbdir&#26684;&#24335;/456/	
            if(!is_dir("$thumbdir")) {
			@mkdir("$thumbdir");
			@chmod("$thumbdir", 0777);
			@fclose(@fopen("$thumbdir".'index.html', 'w'));
			@chmod("$thumbdir".'index.html', 0777);
		}
           $data=GetImageSize($srcFile,&$info);
           switch($data[2]){
                  case 1:
                       $im=@ImageCreateFromGIF($srcFile);
                       break;
                  case 2:
                       $im=@ImageCreateFromJPEG($srcFile);
                       break;
                  case 3:
                       $im=@ImageCreateFromPNG($srcFile);
                       break;
           }
           $srcW = ImageSX($im);
           $srcH = ImageSY($im);
		   $radio= $srcW/$srcH;
		   $dstH = $dstW/$radio;
           $ni=imagecreatetruecolor($dstW,$dstH);
           $black=imagecolorallocate($ni,255,255,255);
           imagefilledrectangle($ni,0,0,$dstW,$dstH,$black);
           ImageCopyResized($ni,$im,0,0,0,0,$dstW,$dstH,$srcW,$srcH);
            $dstFile = $thumbdir.$dstFile;
            switch($data[2]){
                           case 1 :
			                    imagegif($ni,$dstFile,100);
			                    break;
                           case 2 :
			                    imagejpeg($ni,$dstFile,100);
			                    break;
                           case 3 :
			                    imagepng($ni,$dstFile,100);
			                    break;
                           default :
			                    return;
                }
    } 

thumb('ccj.jpg','12080.jpg',120,"./456/234/");
thumb('ccj.jpg','8585.jpg',85,"./456/345/");
?>

[halojoy]

hola hello ciao hej hallo
or what do you say in China?

can you give short description of your function
what is does
and what thing you think can be improved

I am sure it is working, isnt it?

[halojoy]

Here you have good thumbs script from 2001
You can see if same as your function. 🙂

$image = "images/picture.png";
$scale = 20; image size in % procent of $image original

Supports 3 formats: jpeg, gif, png

Howto Use:
In HTML
<img src="thumbsup.php?image=bild.gif&scale=10">
In URL
thumbsup.php?image=bild.gif&scale=10

<?php
/***       ThumbsUP 2.0

Mit ThumbsUP können Sie einfach Bilder zu
einer von Ihnen angegebenen Größe verkleinern.
Diese Größe müssen Sie Prozent angeben.

Instruction:
#######################

$image = "ihr_bild.gif";   // Bilddatei
$scale = 10;               // In Prozent

Entweder Sie geben im Teil "Angaben" Ihre
Angaben an, oder Sie Löschen $image und
$scale und geben dann im URL dies an:

thumbsup.php?image=bild.gif&scale=10

Sie können Dies auch einfach in den HTML
Quelltext einbinden, indem Sie folgendes schreiben:

<img src="thumbsup.php?image=bild.gif&scale=10">

######################
***/
/////////////////////////////////////////////////////////////////
// Copyright © 2001 Wanja Hemmerich
//        thumbsup.php

//$image = "ihr_bild.gif";   // Image file name
//$scale = 10;                    // In Prozent %

$image=$_GET["image"];
$scale=$_GET["scale"];

// Get values of image!
 $size = GetImageSize($image);
 $width = $size[0];
 $height = $size[1];
 $type = $size[2];
 $scale = $scale/100;
 $newwidth = round($width*$scale);
 $newheight = round($height*$scale);

 ###################

 if ($type == 1) {
     header ("Content-type: image/gif");
     $src = imagecreatefromgif("$image");
     $im = imagecreate($newwidth,$newheight);
     imagecopyresized($im,$src,0,0,0,0,$newwidth,$newheight,$width,$height);
     imagegif($im);
     imagedestroy($im);

 } else if ($type == 2) {
     header ("Content-type: image/jpeg");
     $src = imagecreatefromjpeg("$image");
     $im = imagecreate($newwidth,$newheight);
     imagecopyresized($im,$src,0,0,0,0,$newwidth,$newheight,$width,$height);
     imagejpeg($im);
     imagedestroy($im);

 } else if ($type == 3) {
     header ("Content-type: image/png");
     $src = imagecreatefrompng("$image");
     $im = imagecreate($newwidth,$newheight);
     imagecopyresized($im,$src,0,0,0,0,$newwidth,$newheight,$width,$height);
     imagepng($im);
     imagedestroy($im);

 } else {
     echo "Dieses Format wird nicht unterstüzt!";
 }
?>

[Weedpacket]

         if(!is_dir("$thumbdir")) {
            @mkdir("$thumbdir");
            @chmod("$thumbdir", 0777);
            @fclose(@fopen("$thumbdir".'index.html', 'w'));
            @chmod("$thumbdir".'index.html', 0777);
        } 

I'd add some error checking. It's not enough to just ignore errors if they happen, you have to deal with them, too.

[c1a1o1]

Thank you halojoy !

It is used to Narrow picture!

Can I talk with you by msn?

[c1a1o1]

Thank you Weedpacket!

I think that is a good idea !