Why does this code not update?

HeinekenBeer

Hey... Im having some problems with this code to update my database:

<?php
   $link = mysql_connect("localhost", "username", "password")
      or die("Could not connect: " . mysql_error());
   mysql_select_db('katrinelund', $link) or die ( mysql_error());
   $peoplesql = "SELECT
               *
             FROM
               `people`
            ";
   $result = mysql_query($peoplesql)
      or die("Invalid query: " . mysql_error());
   while( $row = mysql_fetch_array( $result , MYSQL_ASSOC )){
      $people[ $row['people_id'] ] = $row['people_fullname'];
   }

   switch( $_GET['action'] ){
      case "edit":
         $productssql = "SELECT
                     *
                   FROM
                     `products`
                   WHERE
                      `products`.`products_id` = '".$_GET['id']."'
                  ";
         $result = mysql_query($productssql)
            or die("Invalid query: " . mysql_error());
         $row = mysql_fetch_array( $result , MYSQL_ASSOC );
         $products_name         = $row[ 'products_name' ];
         $products_type         = $row[ 'products_type' ];
         $products_year         = $row[ 'products_year' ];
         $products_price        = $row[ 'products_price' ];
         $products_artist       = $row[ 'products_artist' ];
         $products_info         = $row[ ' products_info ' ];
         break;
      default:
         $products_name = "";
         $products_type = "";
         $products_year = "";
         $products_price = "";
         $products_artist = "";
         $products_info = "";
         break;
   }
?>
<html>
<head>
   <TITLE><?php echo $_GET['action']?> Produkt</TITLE>
</head>
<body>
<FORM action="commit.php?action=<?php echo $_GET['action']?>&type=products&id=<?php echo $_GET['id']?>" method="post">
   <table border=0 width="750" cellspacing=1 cellpadding=3 bgcolor="#353535" align="center">
      <tr>
         <td bgcolor="#ffffff" width="30%">
            Produkt titel:
         </td>
         <td bgcolor="#ffffff" width="70%">
            <input type="text" name="products_name" value="<?php echo $products_name?>">
         </td>
      </tr>
      <tr>
         <td bgcolor="#ffffff">
            Type:
         </td>
         <td bgcolor="#ffffff">
         <SELECT id="game" name="products_type" style="width:150px">
<?php
         $sql = "SELECT
                  `products_cat_id`,
                  `products_cat_label`
               FROM
                  `products_cat`
               ORDER BY
                  `products_cat_label`
               ";
         $result = mysql_query($sql)
            or die("<font color=\"#FF0000\">Query Error</FONT>".mysql_error());
         while ( $row = mysql_fetch_array($result) ){
            if ( $row['products_cat_id'] == $produtcs_type){
               $selected = " SELECTED";
            } else {
               $selected = "";
            }
            echo '<OPTION value="'.$row['products_cat_id'].'"'.$selected.'>'.$row['products_cat_label'].'</OPTION>'."\r\n";
         }
?>
         </SELECT>

     </td>
  </tr>
  <tr>
     <td bgcolor="#ffffff">
        Fremstillet i år
     </td>
     <td bgcolor="#ffffff">
        <SELECT name="products_year">
           <option value="" SELECTED>Vælg år</option>
<?php
for ($year=date("Y"); $year >= 1970 ;$year--){
            if ( $year == $products_year){
               $selected = " SELECTED";
            } else {
               $selected = "";
            }
?>
               <option value="<?php echo $year?>"<?php echo $selected?>><?php echo $year?></option>
<?
}
?>
            </SELECT>
         </td>
      </tr>
      <tr>
         <td bgcolor="#ffffff">
            Kunstner
         </td>
         <td bgcolor="#ffffff">
            <SELECT name="products_artist">
               <option value="" SELECTED>Vælg en kunstner</option>
<?php
foreach( $people as $people_id => $people_fullname ){
            if ( $people_id == $products_artist){
               $selected = " SELECTED";
            } else {
               $selected = "";
            }
?>
               <option value="<?php echo $people_id?>"<?php echo $selected?>><?php echo $people_fullname?></option>
<?php
}
?>
            </SELECT>
         </td>
      </tr>
      <tr valign="top">
        <td bgcolor="ffffff">
            Produkt pris:
        </td>
        <td bgcolor="ffffff">
            <INPUT type="text" name="price" value="<?php echo $products_price?>">
        </td>
      </tr>
      <tr valign="top">
         <td bgcolor="#ffffff" width="30%">
            Produkt information:
         </td>
         <td bgcolor="#ffffff" width="70%">
            <TEXTAREA rows="8" cols"40" name="products_info" value="<?php echo $products_info?>"></TEXTAREA>
         </td>
      </tr>
      <tr>
         <td bgcolor="#ffffff" colspan=2 align="center">
            <INPUT type="SUBMIT" name="SUBMIT" value="<?php echo $_GET['action']?>">
         </td>
      </tr>
   </table>
</FORM>
</body>
</html>

I really have tried to go through all the code over and over again but i just cant find any errors.

My commit.php looks this, if that is any help:

<?php
// COMMIT ADD
   $link = mysql_connect("localhost", "username", "password")
      or die("Could not connect: " . mysql_error());
   mysql_select_db('katrinelund', $link) or die ( mysql_error());
   switch( $_GET['action'] ){
      case "add":
         switch( $_GET['type'] ){
            case "products":
               $sql = "INSERT INTO
                        `products`
                        ( `products_name` ,
                        `products_year` ,
                        `products_type` ,
                        `products_info` ,
                        `products_price` ,
                        `products_artist` )
                     VALUES
                        ( '".$_POST['products_name']."' ,
                        '".$_POST['products_year']."' ,
                        '".$_POST['products_type']."' ,
                        '".$_POST['products_info']."' ,
                        '".$_POST['products_price']."' ,
                        '".$_POST['products_artist']."')
                     ";
               break;
         }
         break;
   }
   if ( isset( $sql ) && !empty( $sql )){
      echo "<!--".$sql."-->";
      $result = mysql_query( $sql )
         or die("Invalid query: " . mysql_error());
?>
      <p align="center" style="color:#FF0000">
         Done. <a href="index.php">Index</a>
      </p>
<?php
   }
?>

I sure hope that someone can help me, cause i simply cant find the error.

bradgrafelman

I removed the username and password from your code snippets... I'm not sure if they were valid or not, but if they were, I would highly advise against posting them in such a public area as this board.

Also, you told us that there is a "problem," yet you didn't describe the problem. What's happening? What isn't happening?

If it's a SQL error, have you debugged the SQL queries? Echo them out and visually inspect them? Check if [man]mysql_error/man is returning anything?

NogDog

I don't like the looks of the spaces around the array index in this line:

         $products_info         = $row[ ' products_info ' ];

HeinekenBeer

The problem simply is that the code do not update the database.

I have a code of page where i can add to the database and i have a page of code (commit.php) that should edit the database but it don't . The code in the first lines of code (products.php) i posted is the page of code where i enter the things i want to edit in the database.

The second line of code (commit.php) is the page of code which should update the database with whatever i entered in the first page.

The problem seems to be the commit.php, because the database does'nt update and because when i hit submit in products.php the page should be directed to commit.php. It does but the commit.php page does not show anything. it should show this line of code:

<p align="center" style="color:#FF0000">
Done. <a href="index.php">Index</a>
</p>

but it does'nt.

This is propperly a to long and complicated explaination, but i still hope someone can help.

bradgrafelman

Is error_reporting set to E_ALL and display_errors set to On?
Have you tried echo'ing out debug info after the if() statement at the end? For example, try echo'ing $_GET['action'] and $sql, etc.