[RESOLVED] Hmmm where have i gone wrong

[Tezread]

So - I have an insert procedure which is coming up with an undefined index error message. Now ofcourse I have come up with similar error messages before but - I don't know- must be tired today!! 😕 I have a procedure following my insert which creates an array of the answers so i can go on to a scoring system:

?php
include("connect.php");
session_start();
require_once('common_functions.php'); 
$_SESSION['form1_data'] = $_POST;

// build main query from form 1
	$sql = "INSERT INTO qualityuser SET qualityuser_id =  NULL ";
	foreach ($_SESSION['form1_data'] as $col =>$val ){
		if($col <> 'submit'){
		$sql .=", $col = '$val' ";
		}
	}
//////////////////////////////////
mysql_query($sql, $connection) or die(mysql_error()); 

//get last insert id
$sql ="select LAST_INSERT_ID() as id from qualityuser";
$result = mysql_query($sql, $connection) or die(mysql_error()); 
$row=mysql_fetch_array($result);
$id = $row['id'];

$answer = array();
$answer[1] = $_POST['type_registered_charity'];
$answer[2] = $_POST['type_incorporated'];
$answer[3] = $_POST['type_regional_association'];
$answer[4] = $_POST['type_regional_charity'];
$answer[5] = $_POST['type_project'];
$answer[6] = $_POST['nature_selfhelp'];
$answer[7] = $_POST['nature_frontline'];
$answer[8] = $_POST['nature_intermediary'];
$answer[9] = $_POST['nature_infrastructure'];
$answer[10] = $_POST['involved_commitee'];
$answer[11] = $_POST['involved_volunteers'];
$answer[12] = $_POST['involved_paid'];
$answer[13] = $_POST['funded_unrestrictedfunds'];
$answer[14] = $_POST['funded_localcouncil'];
$answer[15] = $_POST['funded_undercontract'];
$answer[16] = $_POST['funded_grants_fees'];
$answer[17] = $_POST['funded_socialenterprise'];
$answer[18] = $_POST['activity_care'];
$answer[19] = $_POST['activity_advice_individual'];
$answer[20] = $_POST['activity_advice_organisations'];
$answer[21] = $_POST['activity_specialist'];
$answer[22] = $_POST['activity_community'];
$answer[23] = $_POST['activity_awareness'];
$answer[24] = $_POST['activity_sport'];
$answer[25] = $_POST['activity_mutual_support'];
$answer[26] = $_POST['have_policies_procedures'];
$answer[27] = $_POST['have_management_structure'];
$answer[28] = $_POST['have_communication'];
$answer[29] = $_POST['have_supervision'];
$answer[30] = $_POST['have_strategy'];
$answer[31] = $_POST['have_aims'];
$answer[32] = $_POST['have_review'];
$answer[33] = $_POST['have_communication'];

if (isset($_POST['submit'])) {

// this will be made into an array!
if($answer[1] == '1'){ 
$score += 5; 
}
if($answer[2] == '2'){ 
$score += 5; 
}
if($answer[3] == '1'){ 
$score += 5; 
}
if($answer[4] == '1'){ 
$score += 5; 
}
if($answer[5] == '1'){ 
$score += 5; 
}

echo $score;
}

thx in advance

[Rodney_H_]

Texread:

I may be mistaken, as it is early and I had a little too little sleep myself, but it looks like your problem might be solved if you move and build your array , $answer, AFTER you check if the POST var is set:

<?php
include("connect.php");
session_start();
require_once('common_functions.php');
$_SESSION['form1_data'] = $_POST;

// build main query from form 1
$sql = "INSERT INTO qualityuser SET qualityuser_id =  NULL ";
foreach ($_SESSION['form1_data'] as $col =>$val )
{
	if($col <> 'submit')
	{
		$sql .=", $col = '$val' ";
	}
}

mysql_query($sql, $connection) or die(mysql_error());

//get last insert id
$sql ="SELECT LAST_INSERT_ID() AS id FROM qualityuser";
$result = mysql_query($sql, $connection) or die(mysql_error());
$row = mysql_fetch_array($result);
$id = $row['id'];


if (isset($_POST['submit'])) 
{

$answer[1] = $_POST['type_registered_charity'];
$answer[2] = $_POST['type_incorporated'];
$answer[3] = $_POST['type_regional_association'];
$answer[4] = $_POST['type_regional_charity'];
$answer[5] = $_POST['type_project'];
$answer[6] = $_POST['nature_selfhelp'];
$answer[7] = $_POST['nature_frontline'];
$answer[8] = $_POST['nature_intermediary'];
$answer[9] = $_POST['nature_infrastructure'];
$answer[10] = $_POST['involved_commitee'];
$answer[11] = $_POST['involved_volunteers'];
$answer[12] = $_POST['involved_paid'];
$answer[13] = $_POST['funded_unrestrictedfunds'];
$answer[14] = $_POST['funded_localcouncil'];
$answer[15] = $_POST['funded_undercontract'];
$answer[16] = $_POST['funded_grants_fees'];
$answer[17] = $_POST['funded_socialenterprise'];
$answer[18] = $_POST['activity_care'];
$answer[19] = $_POST['activity_advice_individual'];
$answer[20] = $_POST['activity_advice_organisations'];
$answer[21] = $_POST['activity_specialist'];
$answer[22] = $_POST['activity_community'];
$answer[23] = $_POST['activity_awareness'];
$answer[24] = $_POST['activity_sport'];
$answer[25] = $_POST['activity_mutual_support'];
$answer[26] = $_POST['have_policies_procedures'];
$answer[27] = $_POST['have_management_structure'];
$answer[28] = $_POST['have_communication'];
$answer[29] = $_POST['have_supervision'];
$answer[30] = $_POST['have_strategy'];
$answer[31] = $_POST['have_aims'];
$answer[32] = $_POST['have_review'];
$answer[33] = $_POST['have_communication'];

// this will be made into an array!
if($answer[1] == '1')
{
	$score += 5;
}
if($answer[2] == '2')
{
	$score += 5;
}
if($answer[3] == '1')
{
	$score += 5;
}
if($answer[4] == '1')
{
	$score += 5;
}
if($answer[5] == '1')
{
	$score += 5;
}

echo $score;
} 

?>

[Tezread]

Funny you should say that as I had that layout beforehand. I have rejigged the order of the code as you suggest and as was before I posted the question. However the same error message is revealed for all fields i.e "UNDEFINED INDEX'
Im baseing this approach on similar formhandlers that have worked fine in the past. Seems I need some sleep 🙂

[Rodney_H_]

What about this:

<?php
include("connect.php");
session_start();
require_once('common_functions.php');

if (!isset($_POST)) 
{
	echo 'Oops. You came to this page by mistake.<br />Please go back.';
	exit;
}
else 
{
	unset($_POST['submit']);
}

$_SESSION['form1_data'] = $_POST;

// build main query from form 1
$query = "INSERT INTO `qualityuser` SET `qualityuser_id` =  NULL ";
foreach ($_SESSION['form1_data'] as $col =>$val )
{
	$query .= ", $col = '$val' ";
}

if(!$result = mysql_query($query, $connection))
{
	echo '<p>The following query could not execute: ' . $query . '</p>';
	die(mysql_error());
}

// last insert id
$id = mysql_insert_id();

if($_POST['type_registered_charity'] == '1')
{
	$score += 5;
}
if($_POST['type_incorporated'] == '2')
{
	$score += 5;
}
if($_POST['type_regional_association'] == '1')
{
	$score += 5;
}
if($_POST['type_regional_charity'] == '1')
{
	$score += 5;
}
if($_POST['type_project'] == '1')
{
	$score += 5;
}

echo $score;
?>

[Tezread]

I have found out what is wrong. In my form im using checkboxes. If they are left unchecked then no value is passed in the session as there isn't one! - hence the undefined error messages. In my formhandler though you will notice im using a dynamic approach for inserting data into the database.

session_start();
require_once('common_functions.php'); 
$_SESSION['form1_data']=$_POST;

// build main query from form 1
	$sql = "INSERT INTO qualityuser SET qualityuser_id =  NULL ";
	foreach ($_SESSION['form1_data'] as $col =>$val ){
		if($col <> 'submit'){
		$sql .=", $col = '$val' ";
		}
	}
	mysql_query($sql, $connection) or die(mysql_error());

I need to include in the formhandler some code which says if there is a checkbox in the $_SESSION[form1data] and it is unchecked then the value = "0".

I looked up in the archives and their are references to fixing this none I could see which resemble my formhandler above

is there a better way of doing this without changing my formhandler a huge amount?