[RESOLVED] Arrays - yes that old chestnut!!

Tezread

Morning all. Friday at last yippeeeee! Im close to a point where ive finished this mini project and I can say ive acheived something this week!
I would like to enquire about an array issue

check this out

//define variable $score
$score = '0';
//set up an array for the answer 'types'
$type = array();
$type[1] = $_POST['registeredcharity'];
$type[2] = $_POST['incorporated'];
$type[3] = $_POST['regionalassociation'];
$type[4] = $_POST['regionalcharity'];
$type[5] = $_POST['project'];

//score each type chosen 5 points

function types($type) 
{ 
    foreach($type as $key=>$value) 
    { 
        if($value >= "1") 
        { 
            $score = $score + 5; 
        } 
        else 
        { 
            $score = $score + 0; 
        } 
    } 
    return $score; 
} 

// Print the number of points: 
echo "You got $score points!";

My problem is that the $score comes up as 0 points however many options i click to add 5 points. Ive had a look at array syntax in the manual - especially comments but I cannot see what on earth is wrong.

thankyou in advance

Rodney_H_

Hi,

I see two things that may be causing your problems:

1) You are not using the isset() function to test if the POST values have been set

2) You define a function, but you are not calling it. So, either call the function, or move the code outside a function definition...


<?php
//define variable $score
$score = '0';

//set up an array for the answer 'types'
$type = array();

// add values, if they exist
if(isset($_POST['registeredcharity'])) { $type[1] = $_POST['registeredcharity']; }
if(isset($_POST['incorporated'])) { $type[2] = $_POST['incorporated']; }
if(isset($_POST['regionalassociation'])) { $type[3] = $_POST['regionalassociation']; }
if(isset($_POST['regionalcharity'])) { $type[4] = $_POST['regionalcharity']; }
if(isset($_POST['project'])) { $type[5] = $_POST['project']; }


//score each type chosen 5 points
foreach($type as $key=>$value)
{
	if($value >= "1")
	{
		$score = $score + 5;
	}
	else
	{
		$score = $score + 0;
	}
}


// Print the number of points:
echo 'You have scored <strong>'. $score . '</strong> points!'; 

?>

Also, as a side note, "types" is not a very good name for your user-defined function. Function names should be descriptive, as yours is, surely, but they should also contain a present tense verb that describes the action or result of running that particular function. So, a function name "getScoreByType()" or "incrementScoreByType()" are a little longer, but make more sense when looking at your code several months from now, especially if your function is included in a separate file.... Just a thought. Hope that helps.

Tezread

marvelloud. working like a charm. you have made my weekend Rodney!! 🙂

Good point about the 'types' reference. Nothing worse than coming back in 2 months and thinking what the hell. I used Authorware in the past and in some cases it is not advisable to use common variable names as it is confusing to the algorithms.