passing values between functions

audiomove

I have a class content.class.php

<?php

class Content {

// News

function newsCategory()
 {
	$sql_category = mysql_query("Select `name` FROM Category WHERE sectionName='News'");

$category = array(); //create empty array

while($categoryRow = mysql_fetch_assoc($sql_category))
{
	$category[] = $categoryRow; //append the whole $categoryRow array in $category
}

return $category;

 } // end newsCategory()

function news($category_data)
 {
	$sql_news = mysql_query("SELECT id,title FROM Content WHERE sectionName='News' AND name='".$category_data."'"); 

$news = array(); 

while($newsRow = mysql_fetch_assoc($sql_news))
{
	$news[] = $newsRow; 
}

return $news;

 } // end news()

} // end Content

and it is called from index2.php like

$content_obj = new Content(); // call Content class 
		$category_data = $content_obj->newsCategory(); 
		$smarty->assign("category",$category_data); // assign

	$news_data = $content_obj->news($category_data); 
	$smarty->assign("news",$news_data); // assign

The above code executes without errors. The first three lines of index2.php above calls the class and calls the function newsCategory and passes the result into a SMARTY template file which works fine.

However, I want to pass the result of the first function call ( newsCategory() ) into the function news(). However the function news executes without printing anything to the screen. I can validate that all the SQL works as Ive hardcoded value replace

 ".$category_data."

with the expected result from the first function and everything prints to the screen as expected.

I've had all this code working procedureally but I want to streamline my code and lot more and have begun rewriting all the code. I'm obviously passing in the result from function newsCategory() to news() wrong and any advice to put it right would be appreciated.

angeljyt

Notice:

the function newsCategory() return an array,but the arguments of function news() is not an array,so the result will be wrong.

audiomove

Ok i see what you mean. How would I fix this?

angeljyt

My english is very poor,I am a Chinese.And I am a novice on PHP.I don't know what you want to do .but if you are certain to pass an array to function news().You need to change the function news() to treate the argument as an array not a normal varible .

audiomove

Yes that much I understand, thx at least I know the issue now. Will try google again. If anyone else here knows how to do this please post. None of my PHP books seem to mention this. Will check again.

angeljyt

Google is not always the omnipotence.You should learn to write a program with a clear thoughts.It means that you know what the program to do ,how to do,what the result it is.
The thought is IPO(input,process,output).What is the input,how to process,what is the output. Then,all the thing is in the charge of you.

audiomove

To be honest, I though it would except an array fine as is. I never knew it wouldn't till it didn't work. Again this project actually has a fully written analysis and design doc but the project is currently been rewritten to be more streamlined.

Does anyone here know how and what i need to change to pass the array results of the first function into the second so it can be used in the sql query?

Weedpacket

Well .... assuming that when you pass an array of strings you're expecting to get results if any of the names appear...

The SQL syntax for that is "WHERE name IN ('string1', 'string2', 'string3')"

So all of the strings in the array need to each be 'single-quoted', and the resulting quoted strings joined together with a comma, so that you'll have a string that can be put between the (parentheses) in the query.

Using "Where name=" won't work.

Or combine both queries into one

Select Content.id, Content.title, Content.name From Content, Category
Where
	Content.sectionName = 'News'
and
	Category.sectionName = 'News'
and
	Content.name = Category.name

And you'll not only have ids and titles, but you'll know the corresponding names as well.

audiomove

I dont want all the values passed into the where clause. I want to be able to pass one value at a time from the array and do an sql query on each. I have a foreach loop when printing, however i dont want all the values of the array in the where clause just one at a time. Can this still be done with IN()?

Installer

foreach ($category_data as $item) {
    $sql_news = mysql_query("SELECT id,title FROM Content WHERE sectionName='News' AND name='".$item."'");
    // etc.
}

audiomove

Hi Installer,

Would i chage the function to then look like this:

function news($category_data)
 {

  foreach ($category_data as $item) {
    $sql_news = mysql_query("SELECT id,title FROM Content WHERE sectionName='News' AND name='".$item."'"); 

$news = array(); 

while($newsRow = mysql_fetch_assoc($sql_news))
{
	$news[] = $newsRow; 
}

  } // end foreach

return $news;

 } // end news()

Ill post the code which displays the results of these functions also in case i need to change anything here:

{foreach item=cat from=$category}
	<div class="box">
	<h4>Category: {$cat.name}</h4>
 {foreach item=new from=$news} 
	<img src="images/go-next.png" /> 
	<a href='newslist.php?id={$new.id}'>{$new.title}</a><br />
 {/foreach}
	</div>
{/foreach}

audiomove

Unfortunatly, this is still a problem for me. When i test the sql statement it seems to only pass in the first letter of the word(s) be passed into $item however the printing out the array does show that the array is been passed into the function.

Can anyone please help me again?