help with deleteing a directory

[Talguy]

so I have a problem with my function that I have created to delete a whole directory. My directory file style is set up like this:
Main=>
images
thumbs

When i select the category of my gallery to delete and call the script to it trys to unlink the directories and doesn't open up the directories that I wanted to delete.

my code:

function delete_category($category_id, $path)
{
  $isDeleted = false;
  $folder_name = mysql_query( "SELCT category_name FROM gallery_category WHERE category_id='".addslashes( $category_id )."'");
  $result = mysql_query( "SELECT photo_filename FROM gallery_photo WHERE photo_category='".addslashes( $category_id )."'" );  

  if(is_dir($path . "/" . $folder_name)) {
		$files = scandir($path."/".$folder_name);
		print_r($files);
		for($x=0,$count = count($files); $x < $count; $x++) {
		  if(is_dir($files[$x]) && $files[$x] != ".." && $files[$x] != ".") {
			  $sub_files = scandir($path."/".$folder_name."/".$files[$x]);
				for($z=0, $count2 = count($sub_files); $z < $count2; $z++) {
				  if($sub_files[$x] == "." || $sub_files[$x] == "../")
			      continue;
			    else
			      unlink($sub_files[$x]);
				}
				rmdir($files[$x]);
			}
			elseif($files[$x] == "." || $files[$x] == "../")
			  continue;
			else
			  unlink($files[$x]);
		}
    while($row = @mysql_fetch_array($result)) {
      unlink($images_dir."/".$row[0]);
    }
    rmdir($path . "/" . $folder_name);
    mysql_query("DELETE FROM gallery_photo WHERE photo_category='".addslashes($category_id)."'");
    mysql_query("DELETE FROM gallery_category WHERE category_id='".addslashes($category_id)."'");
	  return true;
  }
  else {
    return false;
  }
}

[Rodney_H_]

It is very early SUnday morning, so this is just a suggestion probably flawed with several mistakes. Nevertheless, I would suggest trying something like the following:

<?php

// function to delete category from db, remove the directory and it's contents:
function delete_category($category_id, $path) {

/* Assumption: "$category_id" is an integer */

// get category name:
$query = "SELECT `category_name` 
		  FROM `gallery_category` 
		  WHERE `category_id` = ".(int)$category_id;

if(!$result = mysql_query($query)) 
{ 
	echo '<p>' . mysql_error() . '</p>';
	return false;
}

$row = mysql_fetch_array($result, MYSQL_ASSOC);

$directory = $row['category_name'];

// get files:
$query = "SELECT `photo_id`, `photo_filename`
		  FROM `gallery_photo`
		  WHERE `photo_category` = ".(int)$category_id;

if(!$result = mysql_query($query)) 
{ 
	echo '<p>' . mysql_error() . '</p>';
	return false;
}

while($row = mysql_fetch_array($result, MYSQL_ASSOC))
{
	$photos[$row['photo_id']] = $row['photo_filename'];
}

// if the directory does not exist:
if(!is_dir($path . '/' . $directory)) 
{
	echo '<p>The directory, <em>'.$directory.'<em>,  does not exist!</p>';
	return false;
}

// unlink each photo and delete from db:
foreach($photos as $key=>$value)
{
	if(unlink($path . '/' . $directory . '/' . $value))
	{
		$query = "DELETE FROM `gallery_photo`
				  WHERE `photo_id` = ".(int)$key."
				  LIMIT 1";

		if(!$result =  mysql_query($query))
		{
			echo '<p>' . mysql_error() . '</p>';
			return false;
		}
		else $deleted[$key] = $value;
	}
}

// if all the images were deleted:
if( count($delted) == count($photos) )
{
	// if the directory could not be removed:
	if(!rmdir($path . '/' . $directory))
	{
		echo '<p>The directory, <em>'.$directory.'<em>, could not be deleted!</p>';
		return false;		
	}

	// else delte the category:
	else
	{
		$query = "DELETE FROM `gallery_category`
				  WHERE `category_id` = ". (int)$category_id . "
				  LIMIT 1";

		if(!$result = mysql_query($query))
		{
			echo '<p>' . mysql_error() . '</p>';
			return false;				
		}
		else
		{
			return true;
		}
	}
}

// if not all of the images were deleted:
else
{
	echo '<p>Not all of the photos have been deleted!</p>';
	return false;		
}
} 
?>

Of course in production, you would remove the mysql_error() calls...

Hope this helps...

[Talguy]

Rodney H.

I just tried out the code that you gave me and yes it works to a point nothing gets deleted but it comes up with all the right information. I modified it so that it works with the file structure that I have. This is what goes wrong when I run the script to delete all the files an error comes up

i checked the directory and the file does exist inside of it

here is teh code

// function to delete category from db, remove the directory and it's contents:
function delete_category2($category_id, $path) {

/* Assumption: "$category_id" is an integer */

// get category name:
$query = "SELECT `category_name` FROM `gallery_category` WHERE `category_id` = ".addslashes((int)$category_id);

if(!$result = mysql_query($query)) {
  echo '<p>', mysql_error(), '</p>';
  return false;
}

$row = mysql_fetch_array($result, MYSQL_ASSOC);

$directory = $row['category_name'];
	$tempDirName = explode(" ", $directory);
	$directory = join("_", $tempDirName);

// get files:
$query = "SELECT `photo_id`, `photo_filename` FROM `gallery_photos`  WHERE `photo_category` = ".addslashes((int)$category_id);

if(!$result = mysql_query($query)) {
  echo '<p>', mysql_error(), '</p>';
  return false;
}

while($row = mysql_fetch_array($result, MYSQL_ASSOC)) {
  $photos[$row['photo_id']] = $row['photo_filename'];
}

// if the directory does not exist:
if(!is_dir($path . '/' . $directory)) {
  echo '<p>The directory, <em>'.$directory.'<em>,  does not exist!</p>';
  return false;
}

// unlink each photo and delete from db:
foreach($photos as $key=>$value) {
	  // unlink both the main image and the thumbnail image
  if(unlink($path . '/' . $directory . '/images/' . $value) && unlink($path . '/' . $directory . '/thumbs/tb_' . $value)) {
    $query = "DELETE FROM `gallery_photos` WHERE `photo_id` = ".addslashes((int)$key)." LIMIT 1";
      if(!$result =  mysql_query($query)) {
        echo '<p>' . mysql_error() . '</p>';
        return false;
      }
      else $deleted[$key] = $value;
  }
}

// if all the images were deleted:
if(count($delted) == count($photos)) {
  // if the directory could not be removed:
  if(!rmdir($path . '/' . $directory)) {
    echo '<p>The directory, <em>'.$directory.'<em>, could not be deleted!</p>';
    return false;        
  }

  // else delte the category:
  else {
    $query = "DELETE FROM `gallery_category` WHERE `category_id` = ". addslashes((int)$category_id) . " LIMIT 1";
    if(!$result = mysql_query($query)) {
      echo '<p>' . mysql_error() . '</p>';
      return false;                
    }
    else {
      return true;
    }
  }
}

// if not all of the images were deleted:
else {
  echo '<p>Not all of the photos have been deleted!</p>';
  return false;        
}
}

sry about any delayed responses from me college is a little crazy in this website I'm making is just a hobby i'm not even a CS major.