[RESOLVED] || operator not working as I expected

[kiwibrit]

$outitgoesa = '[URL]';
$dumpit = strpos($Comments, $outitgoesa);
if ($dumpit !== false) {
   header( "Location: $errorurl" );
   exit ;
}
$outitgoesb = '[url]';
$dumpit = strpos($Comments, $outitgoesb);
if ($dumpit !== false) {
   header( "Location: $errorurl" );
   exit ;
}

works.

$outitgoesa = '[URL]';
$outitgoesb = '[url]';
$outitgoes = $outitgoesa || $outitgoesb;
$dumpit = strpos($Comments, $outitgoes);
if ($dumpit !== false) {
   header( "Location: $errorurl" );
   exit ;
} 

Doesn't. Why not?

[laserlight]

What is it supposed to do, and how does it not work? As far as I can tell both do not work, since $Comments does not exist.

[kiwibrit]

My bad. I thought you would assume I had already declared $Comments, and $errorurl.

$Comments = $_POST['Comments'] ;
$errorurl = "http://www.mydomain.com/nospam.htm" ;

The first version I published above rejects the messages with the [URL] or [url] tags (the contact form forbids their use). The second version with the || operator does not.

[mjax]

What are you trying to achieve with this || operator? You do know that || is a boolean OR?

Is this what you are trying to do?

 $outitgoesa = '[URL]';
$outitgoesb = '[url]';
if (strpos($Comments, $outitgoesa) !== false || strpos($Comments, $outitgoesb) !== false) {
   header( "Location: $errorurl" );
   exit ;
}

[Installer]

The statement "$outitgoes = $outitgoesa || $outitgoesb;" will set $outitgoes to either (boolean) true or false (true in this case). Then when you check with strpos() to see whether it's part of the string, you're actually checking for a boolean value. No string will contain a boolean value; it's a string, after all.

So use mjax's code, or, slighty more concise:

$outitgoes = '[url]'; 
if (strpos(strtolower($Comments), $outitgoes) !== false) {
   header("Location: $errorurl"); 
   exit; 
}

And always make a type-strict comparison between false and strpos(), since strpos() may return 0 (1st character) which otherwise would resolve to false.

[kiwibrit]

Thanks to both of you, you have shown and explained the solution very clearly.