[RESOLVED] FP_swapImg() creating php error....

jcanker

I cut and pasted portions of html created by Front Page into an $output = "foo" but once it hits this function, php kicks back:

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting ']' in C:******_fns.php on line 29

The function works fine on the static html page.

Here is the offending FP function:

bradgrafelman

That's because that is a Javascript function, not a PHP function...

jcanker

bradgrafelman wrote:
That's because that is a Javascript function, not a PHP function...

That's correct, but this javascript function is included in the whole grouping of html code that was cut and pasted from the original site in the "$output = "foo" section (foo being all the stuff that was cut and pasted)

There are other javascript functions included in this section that php includes without a blip, and I've included javascript in $output="foo" sections before...it's just this one section that's making php puke. If I comment it out it moves on past the other functions without caring about them being present.

bradgrafelman

Hmm.. not sure what the issue is then... might be an unescaped quote. Can you paste more of the code before and after this?

NogDog

If that is text within a double-quoted or heredoc string in your PHP code, you may need to use "complex variable notation" to help the parser detect where your PHP variables begin/end. For instance, line 29 might need to be:

doc.[color=red]{[/color]$imgSwaps[color=red]}[/color][doc.[color=red]{[/color]$imgSwaps[color=red]}[/color].length]=elm;

This assumes $imgSwaps is a PHP variable which you want to embed within a quoted string.

jcanker

I tried using the curly braces, but they're javascript variables, not php variables, so that opened up a whole other can of worms 🙂

Here's my whole php function, do_html_header(), which uses all the copied and pasted javascript functions from FrontPage. I've marked the offending line with <<<<<<<<. It still strikes me as odd that the other 2 js functions work fine, and this js function works fine when presented as a static html page...I should just be able to include it like I always do with other js scripts, provided I swap double quotes for single ones...

//my function is below

function do_html_header($page_title)
{
$output = "
<html>

<head>
<meta http-equiv='Content-Language' content='en-us'>
<meta http-equiv='Content-Type' content='text/html; charset=windows-1252'>
<title>$page_title</title>
<script language='JavaScript'>
<!--

function FP_preloadImgs() {//v1.0
 var d=document,a=arguments; if(!d.FP_imgs) d.FP_imgs=new Array();
for(var i=0; i<a.length; i++) { d.FP_imgs[i]=new Image; d.FP_imgs[i].src=a[i]; }
}

function FP_getObjectByID(id,o) {//v1.0
 var c,el,els,f,m,n; if(!o)o=document; if(o.getElementById) el=o.getElementById(id);
 else if(o.layers) c=o.layers; else if(o.all) el=o.all[id]; if(el) return el;
 if(o.id==id || o.name==id) return o; if(o.childNodes) c=o.childNodes; if(c)
 for(n=0; n<c.length; n++) { el=FP_getObjectByID(id,c[n]); if(el) return el; }
 f=o.forms; if(f) for(n=0; n<f.length; n++) { els=f[n].elements;
 for(m=0; m<els.length; m++){ el=FP_getObjectByID(id,els[n]); if(el) return el; } }
 return null;
}
// -->
</script>
</head>";
echo  $output;

}//close of function

bradgrafelman

PHP is probably getting confused and things that you're trying to access $imgSwaps as if it was an array. Try closing the quoted string and concatenating variables, i.e.

$foo = "this is a " . $bar . " variable!";

jcanker

even though the variables are javascript variables? Won't concatenating them just force php to view them as php variables?

I'll give it a shot...cross yer fingers 🙂

jcanker

Newp...that just kicks back php error:

Undefined variable: imgSwaps in C:***\output_fns.php

hrm....

NogDog

Javascript variables don't have "$" prefixes, so either they are supposed to be PHP variables which you need to define somewhere, or else the "$" charactrers need to be removed.

jcanker

I thought so too, but that's how FP is creating them. I just went back and created a new set, just to be sure that my php editor didn't stick em in somewhere--FP put em in there. If I take the $'s out, then the buttons don't have the mouseover effect anymore

Weedpacket

If memory serves, Javascript variables can have names starting with '$' as well. If you don't want PHP interpreting them as PHP variables, then escape the $ by writing \$ instead.

Or don't stick all that stuff in a string if all you're going to do is echo it out:

function do_html_header($page_title)
{
?>
<html>

<head>
<meta http-equiv='Content-Language' content='en-us'>
<meta http-equiv='Content-Type' content='text/html; charset=windows-1252'>
<title><?php echo $page_title?></title>
<script language='JavaScript'>
<!--

function FP_swapImg()
{
//v1.0e
var doc=document,args=arguments,elm,n;
doc.$imgSwaps=new Array();
for(n=2; n<args.length;n+=2)
{ elm=FP_getObjectByID(args[n]);
if(elm)
{
doc.$imgSwaps[doc.$imgSwaps.length]=elm;
elm.$src=elm.src;
elm.src=args[n+1];
}
}
}


function FP_preloadImgs() {//v1.0
var d=document,a=arguments; if(!d.FP_imgs) d.FP_imgs=new Array();
for(var i=0; i<a.length; i++) { d.FP_imgs[i]=new Image; d.FP_imgs[i].src=a[i]; }
}

function FP_getObjectByID(id,o) {//v1.0
var c,el,els,f,m,n; if(!o)o=document; if(o.getElementById) el=o.getElementById(id);
else if(o.layers) c=o.layers; else if(o.all) el=o.all[id]; if(el) return el;
if(o.id==id || o.name==id) return o; if(o.childNodes) c=o.childNodes; if(c)
for(n=0; n<c.length; n++) { el=FP_getObjectByID(id,c[n]); if(el) return el; }
f=o.forms; if(f) for(n=0; n<f.length; n++) { els=f[n].elements;
for(m=0; m<els.length; m++){ el=FP_getObjectByID(id,els[n]); if(el) return el; } }
return null;
}
// -->
</script>
</head>
<?php
}//close of function

jcanker

Bah....

that seems to work, but now IE debugs syntax errors in the body where it actually puts the code to display the button.....argh...God bless Micro$oft :quiet:

Anyway, I'll mark this as resolved and say screw the mouseover buttons in php until I get more time to play with it..I need to get this website operational ASAP and don't have time to play around with bells and whistles...

Thanks for all your help guys!