Mail list errors

[XIII]

I just coded this e-mail list, it works well for entering data into database, but if user leaves the field blank or adds an already exist e-mail it gives him the error message and stops loading the rest of the page.

<?php
// Connects to your Database
mysql_connect("localhost", "my_username", "mypassword") or die(mysql_error());
mysql_select_db("Database name") or die(mysql_error());

//This code runs if the form has been submitted
if (isset($_POST['submit'])) {

//This makes sure they did not leave any fields blank
if (!$_POST['email']) 
{die('<font color=red><b><i>No e-mail added</i></b>');
}

// checks if that e-mail is in use
if (!get_magic_quotes_gpc()) {
$_POST['email'] = addslashes($_POST['email']);
}
$mailcheck = $_POST['email'];
$check = mysql_query("SELECT email FROM maillist WHERE email = '$mailcheck'")
or die(mysql_error());
$check2 = mysql_num_rows($check);

//if e-mail exists it gives an error
if ($check2 != 0) {
die('<font color=red><b><i>Already subscribed</i></b>');
}
else
{
echo"<font color=blue><b><i>Subscribed successfully</i></b>";
}

// now we insert it into the database
$insert = "INSERT INTO maillist (id, email) VALUES ('0', '".$_POST['email']."')";
$add_email = mysql_query($insert);
?>

<?php
}
else
{
?>


<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
<table border="0">
<tr bgcolor="#6652D8">
    <td width="140"><span class="style1"><span class="style1">Get our Newsletter</span>: </span></td>
  </tr>
<tr><td>
<input type="text" name="email" maxlength="100">
</td></tr>
<tr><th colspan=2><input type="submit" name="submit" value="Subscribe"></th></tr>
<tr><td></td></tr>
<tr><td bgcolor="#6652D8"></td>
</tr>
</table>
</form>

<?php
}
?>

1- i need to make it say the error message and continue loading the rest of the page.
2- checks for the entered text "if it's a valid e-mail format [e-mail]."

[XIII]

I already fixed some errors, but still need some help with the other problems :s

[bogu]

If u want to load the hole page don't use die() when u show error message because that will stop your script. U should create a message var that will output the error.

About email validator, here is a php function that validates email addresses:

	function emailCheck ($email) {
	if (!eregi("^[_a-z0-9-]+(\.[_a-z0-9-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,3})$", $email)) { 
		return false;
	} else return true;
} 

[XIII]

bogu wrote:

If u want to load the hole page don't use die() when u show error message because that will stop your script. U should create a message var that will output the error.

Thank you for that e-mail validator, about the first matter, i couldn't get a var that does this function as i want it to give an error message and in the same time to stop inserting that e-mail in a database.

[bogu]

XIII wrote:

Thank you for that e-mail validator, about the first matter, i couldn't get a var that does this function as i want it to give an error message and in the same time to stop inserting that e-mail in a database.

Well emailCheck function is a boolean function so u need to have something like this:

if (emailCheck($email)) {
    /* insert */
    echo"<font color=blue><b><i>Subscribed successfully</i></b>";
} else {
    echo '<font color=red><b><i>Already subscribed</i></b>';
}

[XIII]

These really helped me so much, but still have some other problems, here is the code after editting it:

<?php
/// Connects to your Database
mysql_connect("localhost", "my username", "my password") or die(mysql_error());
mysql_select_db("my db name") or die(mysql_error());

///This code runs if the form has been submitted
if (isset($_POST['submit'])) {

///This makes sure they did not leave any fields blank
if (!$_POST['email']) 
{
[COLOR=Red]die[/COLOR]"<font color=red><b><i>No e-mail added</i></b>";
}

/// checks if that e-mail is in use
if (!get_magic_quotes_gpc()) {
$_POST['email'] = addslashes($_POST['email']);
}
$mailcheck = $_POST['email'];
$check = mysql_query("SELECT email FROM maillist WHERE email = '$mailcheck'")
or die(mysql_error());
$check2 = mysql_num_rows($check);

///if e-mail exists it gives an error
if ($check2 != 0) {
echo"<font color=red><b><i>Already subscribed</i></b>";
}
else
{
$insert = "INSERT INTO maillist (id, email) VALUES ('0', '".$_POST['email']."')";
$add_email = mysql_query($insert);
echo"<font color=blue><b><i>Subscribed successfully</i></b>";
}

///now we insert it into the database

?>

<?php
}
else
{
?>


<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
<table border="0">
<tr bgcolor="#6652D8">
    <td width="140"><span class="style1"><span class="style1">Get our Newsletter</span>: </span></td>
  </tr>
<tr><td>
<input type="text" name="email" maxlength="100">
</td></tr>
<tr><th colspan=2><input type="submit" name="submit" value="Subscribe"></th></tr>
<tr><td></td></tr>
<tr><td bgcolor="#6652D8"></td>
</tr>
</table>
</form>

<?php
}
?>

the code for valediating e-mail addresses doesn't work as we did't assign $mail for any value, also it will like that red die above in the code stop loading of the whole page, and if i use print or echo, it will tell the error message but will not prevent inserting to database, the above red die in :

///This makes sure they did not leave any fields blank
if (!$_POST['email']) 
{
[COLOR=Red]die[/COLOR]"<font color=red><b><i>No e-mail added</i></b>";
}

stops all the page from continue loading, when i used echo instead, it didn't prevent inserting a blank row to database.

the second problem is, i have another form in the same page, when i press submit, it excute both scripts, what should i do?

[bogu]

Try empty function to check if the field is not empty ...