[RESOLVED] MP3 Upload Problem

[mpar612]

Hi everyone,

I am creating a form that creates a directory and uploads and MP3 into the newly created directory.

I think the audio/mpeg portion of the code may not be right, because the every time I run this script it takes a second for my selected file to upload, the directory does get created and then it displays the "Please use an mpeg" message.

Does anyone have any thoughts? Thanks!

Here is my code (excluding the HTML form):

 [code=php]$audio_dir_new = $_POST[upc];
 mkdir("../Lounge/audio/$audio_dir_new", 0777);	 

 $filetypes = array ('audio/mpeg');
 if (in_array($_FILES['song1']['type'], $filetypes)){
 $currentname = $_FILES['song1']['name'];
 $new_audtio_name = $currentname.date("Ymdhis");
 $audio_uploaddir = "../Lounge/audio/$audio_dir_new";
 print $audio_uploaddir;
if (move_uploaded_file($_FILES['song1']['tmp_name'], $audio_uploaddir.'/'.$new_audio_name)) {
    print("file upload was successful");
  	  } else {
    print("file upload failed");
  	  }
} else {
print "Please use an mpeg file";
} [/code]

[etully]

Yes, you are right. The problem is the audio/mpeg line. To find out what that line should really say, add this to the beginning of your script:

echo "I should really be using: " . $_FILES['song1']['type'] ;

[mpar612]

Thanks for the response!

I gave that a try and it prints it only prints "I should really be using: "

Does anyone have any other thoughts?

Thanks!

[etully]

So we know that $_FILES['song1']['type'] doesn't have a value when this particular type of file gets uploaded. That means that that attribute can't be trusted to reliably tell you what type of file was uploaded.

Is there a real likelihood that people will upload WAV, AVI, JPG, PDF, or EXE files when they're supposed to upload an MP3 ? Is it really a problem if they do upload the wrong filetype? Maybe it would just be easier to permit any type of file upload as long as the filename ends with mp3 ?

[mpar612]

Now, I am trying to do that. There are some security concerns that I want to avoid, that's why I want to limit the files to only mp3's.

Now I am trying the following code and I keep getting "File Upload Failed."

Any thoughts. Thanks for everyone's help!

   	 $audio_name = $_FILES['song1']['name'];
	 $audio_uploaddir = "../Lounge/audio/$audio_dir_new";
    if (move_uploaded_file($_FILES['song1']['tmp_name'], $audio_uploaddir.'/'.$audio_name)) {
        print("file upload was successful");
      	  } else {
        print("file upload failed");
      	  }

[etully]

You're having so many problems that you shouldn't be having. Let's start at the beginning... are you certain that $_FILES has any value at all? Try:

print_r($_FILES);

to see what's in that array. This will tell you if 'song1' is there and if it has a name, type, filesize, etc.

This is the code that I use for uploading files:

<form method="POST" action="update-info-image2.html" ENCTYPE="multipart/form-data">
<input TYPE="file" NAME="FILE1" SIZE=30 MAXLENGTH=80>
<input type=submit value="Upload!">

and then in the PHP file, I write:

@copy("$FILE1" ,"/usr/local/path/to_your/website/htdocs/data/info-images/$FILE1_name");

This way, instead of relying on the $_FILES array, you can use your own variable. You should still be able to get type, filesize, etc.

[mpar612]

Thanks!

Here is what print_r($_FILES) gives me:

[song1] => Array ( [name] => [type] => [tmp_name] => [error] => 2 [size] => 0 )

I'm not sure if this is a normal result or not.

I appreciate you giving me your code. I will give that a try.

Any other thoughts on how I might get my original way to work? Thanks!

[mpar612]

I must have gotten a bad batch of mp3's. I know they are a few years old, but I thought they would still work because they play just fine. I tried several that were just ripped and the code works great. Has anyone ever had this happen before?

Thanks for all of your help!

[hennety]

Hi mpar612,
Could you provide the link to the thread that solved this problem as I am currently putting together a script for mp3 file uploading and am running into the exact same problems, whereby the filename is recognised, but no other properties of the mp3 file are pulling through at all.

I've tried several approaches but so far none seem to work.

Thanks in advance.

[mpar612]

Hello,

I didn't find a thread that helped. This ended up being a trial and error sort of thing for me. Are you limiting the files uploaded by mime type? If so, try removing the part of your code and see it works.

I hope this helps in some way.