[RESOLVED] DB issues. Data not being added or listed

DeathfireD

Edited:
Solved

DeathfireD

Solved

bradgrafelman

Try some standard MySQL debugging methods?

$query = "SELECT * FROM servers ORDER BY name";
$exec = mysql_query($query) or die('MySQL error: ' . mysql_error() . '<hr>Query: ' . $query); 
$num = mysql_num_rows($query);

Although a more efficient way to get the total number of rows would probably be:

$query = 'SELECT COUNT(*) FROM servers ORDER BY name';
$exec = mysql_query($query);
$num = mysql_result($exec, 0);

At any rate, try debugging your query. I suspect you'll learn that MySQL is telling you that there is no such 'name' column.

DeathfireD

ha I over looked the name. Well I tryed replacing the name and the error went away but still no data displayed. Then I tryed adding in standard sql degun methods like you suggested for that line. The error comes back

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/ftpusers/otdb/html/index.php on line 25

Line 25 is this. $num = mysql_num_rows($query);
Im not sure why its not liking mysql_num_rows, any ideas?

Edited
Ok I replaced my num rows code with your second code snippet. I think that solved that issue but a new error shows up now. Parse error: syntax error, unexpected T_STRING in /home/ftpusers/otdb/html/index.php on line 32

Line 32 is if (@$_GET['see']=="list")

bradgrafelman

Woops! I had re-written your code and I forgot to change that variable. Replace $query with $exec on that line of code.

As I noted, however, I believe COUNT(*) would be a more efficient way of counting the rows (since this is a MyISAM table).

DeathfireD

look at my post above yours again I edited it.

Edited

my bad I made your changes again

//changed
$exec = 'SELECT COUNT(*) FROM servers ORDER BY  servername';
$exec = mysql_query($exec);
$num = mysql_result($exec, 0);

the page loads without any errors but still not db data is displayed. So you fixed one issue that I needed help with but Im still having the biggest issue left lol. My validator and my data lister dont seem to be getting or sending the data to the db.

bradgrafelman

The line you posted is fine... we need more context. When you have an error like this, paste a few lines before and after the line # given.

In the meantime, try looking for unescaped quotes or a missing semicolon.

DeathfireD

like I said in the above post (I edited again) no more errors but no data is being listed from the db. IM about to update my first post with the changed code so you can get a clear image.

DeathfireD

Ok I did some thinking and came up with a fix.

It ended up working. The data in the DB listed correctly with no issues at all.

So now the only issues/bugs I have left is the Validator. When people send there POST data to it, it dosnt add the data to the DB.

bradgrafelman

What does it do when you try to add data?
Have you tried the same debugging technique as above - echo'ing mysql_error() if the query fails as well as echo'ing out the query string to visually inspect it?
What's with all of the $post stuff? Why would you duplicate all of this instead of just using $_POST ???
Try echo'ing mysql_affected_rows() to see how many rows it did alter/add.

DeathfireD

bradgrafelman wrote:
1. What does it do when you try to add data?

Have you tried the same debugging technique as above - echo'ing mysql_error() if the query fails as well as echo'ing out the query string to visually inspect it?

What's with all of the $post stuff? Why would you duplicate all of this instead of just using $_POST ???

Try echo'ing mysql_affected_rows() to see how many rows it did alter/add.

It's hard to test since the php file is set there wile a .exe sends data to it using URL encoding POST. I used all the post variables so my fellow developers could edit them to something shorter when they feel the need too. I suppose I could just take that all out and use $_POST

Well as you can see I do have allot of dies with error debugging. But even with them and using the mysql_error() I don't get any errors at all. I do however keep getting "Error: IP sent does not match the IP the server connected from." Thats obviously becuse when visiting the page Im not sending any data for it to match the IP field with though 😛

// Validate the otserv's IP Address
if ($_POST["ip"] != $_SERVER["REMOTE_ADDR"]) {
  die("ERROR: IP sent does not match the IP the server connected from.");
}

So, I'm lost as to whats going on. Oh and btw I do use (mysql_affected_rows() != -1) or die ("ERROR: ". mysql_error()); at the very bottom of the file. Look at the source at the top maby you missed it before.

Edited I tryed just writing up a simple form to send the required post data.

 <FORM action="http://urlicantsay.com/otservdb.php" method="post">
    <P>
    <LABEL for="ip">ip: </LABEL>
              <INPUT type="text" id="ip"><BR>
    <LABEL for="servername">servername: </LABEL>
              <INPUT type="text" id="servername"><BR>
    <LABEL for="server">server: </LABEL>
              <INPUT type="text" id="server"><BR>
        <LABEL for="ownername">owner name: </LABEL>
              <INPUT type="text" id="ownername"><BR>
                  <LABEL for="motd">motd: </LABEL>
              <INPUT type="text" id="motd"><BR>
    <INPUT type="submit" value="Send"> <INPUT type="reset">
    </P>
 </FORM>

And I get the same error as just visiting the page "ERROR: IP sent does not match the IP the server connected from" So this leads me to think that my issue is not anything to do with the db but instead may have something to do with the ip check. I'm not sure why though. I'm gonna run some more tests but I still need help majorly if anyone can come up with answers.

DeathfireD

ok I decided to just comment out the IP check code to see what would happen. Well the error went away but now I goes to error: players online. I tryed changing

validNumber( $post["playersonline"], null, 400) or die("ERROR: players online");

validNumber( $_POST["playersonline"], null, 400) or die(mysql_error());

But the page just goes white. No errors or anything. I'm unsure whats going on.