[RESOLVED] complex if... then

lovesirius12

hi.

what do you thin is the problem with this code?

	<?php				
		$errmsg = "";
		$complete =  true;
		if (isset($_POST['submit'])) {
			$fname = ($_POST['firstname']);
			$lname = ($_POST['lastname']);

		if (empty($fname)) {
			$errmsg = "Plese provide your FirstName";
			$fname = "";
			$complete = false;
			}

		if (empty($lname)) {
			$errmsg = "Plese provide your LastName";
			$fname = "";
			$complete = false;
			}

		if ($complete == true) {
			echo "<script>document.location.href='fine.html'</script>";
			exit();
			}
		}
	else
	{
	echo $errmsg;
	}
	?>

thanks!

Houdini

This might be what you need...I am tired though so try it out

<?php                

        $errmsg = "";
        $complete =  true;
        if (isset($_POST['submit'])) {
            $fname = ($_POST['firstname']);
            $lname = ($_POST['lastname']);

        if (empty($_POST[fname])) {
            $errmsg = "Plese provide your FirstName";
            $fname = "";
            $complete = false;
            }

        if (empty($_POST[lname])) {
            $errmsg = "Plese provide your LastName";
            $fname = "";
            $complete = false;
            }

        if ($complete == true) {
            echo "<script>document.location.href='fine.html'</script>";
            exit();
            }
        }
    else
    {
    echo $errmsg;
    }
    ?>

lovesirius12

tnx, i tried it. but it doesn't work. 🙁

bradgrafelman

Actually, your original code will work just fine, if you consider the two following things:

Each if() statement that makes sure they filled in the first or last name fields will override the other. For example, if they left both fields blank, the message would only read "Plese provide your LastName" since the error message was overwritten with that text. Perhaps you should echo these error messages as they occur instead of trying to store them into a variable for later use.
Speaking of later use... you never echo the error messages! I believe this is the main part of your problem. You have an if() statement to check if $complete is true, but you don't have an else statement to deal with the opposite. If you echo the messages as they occur (like I suggested above), however, there will be no need for an if/else statement here.

lovesirius12

i changed the code to :

<?php
$errmsg = "";
$complete = true;
if (isset($POST['submit'])) {
$fname = ($POST['firstname']);
$lname = ($_POST['lastname']);

                    if (empty($_POSTfname)) {
                            $fname = "";
                            $complete = false;
                     }

                     if (empty($_POSTlname)) {
                           $lname = "";
                           $complete = false;
                    } 

		if ($complete == true) {
			echo "<script>document.location.href='fine.html'</script>";
			exit();
			}
		else
			{
			echo "Please provide the necessary information";
			}
		}

i think it has problem with the redirecting... what do you suggest?

bradgrafelman

As I said before, you can just go with your original code and make only a few modifications. The following is my solution-in-theory (I didn't test this), as well as using header() to redirect them:

<?php                 

        $errmsg = ""; 
        $complete =  true; 
        if (isset($_POST['submit'])) { 
            $fname = ($_POST['firstname']); 
            $lname = ($_POST['lastname']); 

        if (empty($fname)) { 
            echo "Please provide your FirstName <br/>"; 
            $complete = false; 
            } 

        if (empty($lname)) { 
            $errmsg = "Please provide your LastName <br/>"; 
            $complete = false; 
            } 

        if ($complete == true) { 
            header('Location: fine.html'); // better method of redirection 
            exit(); 
            } 
        } 
    else 
    { 
    echo 'No form submitted...'; 
    } 
?>

lovesirius12

thanks. it redirected but with another problem, i think i'll post it with another title. thanks a lot.