is this a correct way of OOP?

JackOfBlades

i just wanted to ask if this is a correct or good programming practice in php coding

function setYear(){
$this->nYear = $nCurDate['year'];
}

function setYear($nYear){ //overloading function of setYear()
$this->nYear = $nYear;
}

i made a setter function setYear that doesnt accept any parameter and another one that accepts a parameter i did this since they have the same function but different task i was just wonderin if this is correct and if it is, is it a good programming practice or is there any other better way to do this? thanks

JackOfBlades

also i would to add

is this valid :

function setMonthNames(){
$this->aMonthNames = array(1=>'January',
'Febuary',
'March',
'April',
'May',
'June',
'July',
'August',
'September',
'October',
'November',
'December');
}

this is the setter
and this is the getter

function getMonthNames(){
return $this->aMonthNames;
}

i would just like to ask if this is ok, i know in C your not supposed to use return statements if it's an array but im not quite sure in php

ahundiak

PHP does not support overloading methods. Your code will not work.

In many cases you can use default values to achieve similiar results:

function setYear($year = NULL)
{
    if ($year === NULL) $this->year = $curDate['yar'];
   else $this->year = $year;
}

And as far as best practices go, drop this $nYear stuff and just go with plain $year.

Weedpacket

ahundiak wrote:
And as far as best practices go, drop this $nYear stuff and just go with plain $year.

Nah, I'd go with the accessor methods - PHP5's magic methods if you've got PHP 5. Exposing your private parts to public manipulation without adequate safeguards is never a wise move.

NogDog

Weedpacket wrote:
Exposing your private parts to public manipulation without adequate safeguards is never a wise move.

LOL...Did you learn that in Programming 101 or Sex Education 101? 😉

JackOfBlades

ok thanks but i just want to ask..

how bout the array part? and returning it? was it valid?

ahundiak

Returning an array is fine. Just be aware that it's a copy of the objects internal array. Which should not be an issue for what you seem to be trying to do.

Might want to take a look at the PEAR Date object or even the Zend Date object.

===
As far as naming goes I'm just saying that it's better to use $this->year instead of $this->nYear. Misusing the Hungurian prefix notation (the n part) went out of style quite some time ago. Thankfully.