calling variable from another file

error_22

Hi,

I was wondering if someone could help me. I have a file called news.php:

news.php

<?
$sql = "SELECT * FROM `p_news` ORDER BY `p_id` DESC";  

$result = mysql_query($sql) or die(mysql_error());  

while ($row = mysql_fetch_object($result))  

{      

$title = $row->p_title;
$content = $row->p_content;
}
?>

Then I have another file, index.php:

index.php

<?
require ("./includes/db_con.php"); //connects to DB
require ("./includes/news.php");

echo $title;
echo "<br />";
echo $content;
echo "<br /><br />";
?>

My problem is, only the first row shows up, how do I fix it? I know why its not looped, but is there a solution? I dont want to merge the two files because I plan on displaying the content from that table in more than one file, and I plan to display it differently on ever page. Is there a solution to this?

Thanks in advance
Niklas

Piranha

Of course only one row shows up. In the row $title = $row->p_title; you constantly replace $title with the new title. Try something like this instead:

<?
$sql = "SELECT * FROM `p_news` ORDER BY `p_id` DESC";  

$result = mysql_query($sql) or die(mysql_error());  

$title = array()
while ($row = mysql_fetch_object($result))  

{
array_push($title, $row->p_title);      

$content = $row->p_content;
}
?>

Then when you show it you just put it in a loop. Note that you should add both title and content in the same array to avoid problems, look at http://www.w3schools.com/php/php_ref_array.asp to get some help with arrays.

error_22

The above example gives me errors, how exact would I do this? Thanks for helping!

I thought array_push only added more elements to the end of the array? Dont you need an array to begin with?

Niklas

void_function

Bad design. Don't use query result from one PHP file in another PHP file. But if you so desire, then you need to construct an array, for example, of results in news.php:

$sql = "SELECT * FROM `p_news` ORDER BY `p_id` DESC";  

$result = mysql_query($sql) or die(mysql_error());  

$title= array();
$content= array();
while ($row = mysql_fetch_object($result))  

{      

$title[] = $row->p_title;
$content[] = $row->p_content;
}

Then in index.php

require ("./includes/db_con.php"); //connects to DB
require ("./includes/news.php");

$cnt= count($title); // title and content should have same number of elements, so it doesn't matter which you count
for ($i=0; $i<$cnt; $i++) {
  echo $title[$i];
  echo "<br />";
  echo $content[$i];
  echo "<br /><br />"; 
}