[RESOLVED] maybe a precedence problem? Plz help!

ade1982

Hi,

Complete newbie here, please don't laugh 🙂

I have written a "contact me" page, and everything works fine, if all the fields are filled, the form emails me, if all of the fields are empty, it raises alerts and goes back, if one field is empty it raises the alert, etc.

However, the problem I am having is that the form actually refreshes if the name and email fields are full, but the message field is empty. The same doesn't happen if the message and name fields are full, but not the email.

This leads me to think there is something wrong with the way I am evaluating this

if(empty($contact_name) || empty($contact_email) || empty($contact_message)) {

as the || op is left precedent

but I could be wrong, or the might be something wrong with my code. Can someone help me find the mistake? It would be very much appreciated, as I have spent all day looking at it, and my eyes are square!

<html>
<head>

<script language="JavaScript">

function emailvalidation(entered, alertbox)
{
with (entered)
{
apos=value.indexOf("@");
dotpos=value.lastIndexOf(".");
lastpos=value.length-1;
if (apos<1 || dotpos-apos<2 || lastpos-dotpos>3 || lastpos-dotpos<2)
{if (alertbox) {alert(alertbox);} return false;}
else {return true;}
}
} 

function emptyvalidation(entered, alertbox)
{
with (entered)
{
if (value==null || value=="")
{if (alertbox!="") {alert(alertbox);} return false;}
else {return true;}
}
}

function formvalidation(thisform)
{
with (thisform)
{
if (emptyvalidation(FullName,"Please enter your name")==false) {FullName.focus(); return false;};
if (emptyvalidation(Subject,"Please enter a message")==false) {Suject.focus(); return false;};
if (emailvalidation(Email,"Please enter a VALID email address")==false) {Email.focus(); return false;};
}
}
  </script>
</head>


<body>

<div class="boxcontent">
<h1>Thanks for your comment</h1>

<?php
// declare values
$contact_email = $_POST['Email'];
$contact_name = $_POST['FullName'];
$contact_message = $_POST['Subject'];
$mydate = date ( 'l, F d Y g:i A',time()+240 );

// where to send e-mail to
$to = 'adrian_trythall@hotmail.com';

// e-mail subject
$subject = "Message submitted using Contact Us form";

// e-mail message
$message = "You have received a contact message:\r\n"

."----------------------------------------------------------------\r\n"
."Contact Name: $contact_name\r\n"
."Submitted: $mydate\r\n"
."From IP: {$_SERVER['REMOTE_ADDR']}\r\n\r\n"
."Message: $contact_message\r\n"
."Form Address: {$_SERVER['SERVER_NAME']}{$_SERVER['REQUEST_URI']}";

$headers = "From: $contact_name <$contact_email>\n"
."Reply-To: $contact_email\n"
."X-Mailer: PHP/".phpversion();

// check for validation, then send the e-mail
if(empty($contact_name) || empty($contact_email) || empty($contact_message)) {
echo '<p>Send us a message, enter your information below and click \'Submit\'!</p>
<form method="post" action="" onSubmit="return formvalidation(this)">
<table id="Form-Details">
<tbody>
<tr><td>Name:</td><td><input type="text" name="FullName" size="20" /></td><tr/>
<tr><td>Email:</td><td colspan="3"><input type="text" name="Email" size="20" /></td></tr>
<tr><td colspan="4">Message:</td></tr>
<tr><td colspan="4"><textarea rows="6" name="Subject" cols="47" class="input"></textarea></td></tr>
<tr><td colspan="4" class="right1"><input type="submit" value="Submit" /><input type="reset" value="Reset" /></td></tr>
</tbody>
</table>
</form>';
} else {
mail( $to, $subject, $message, $headers );
echo "<h3>Message Sent!</h3><p>Dear $contact_name,<br /><br />We will get back to you as soon as possible using $contact_email.";
}
?>

</div>

</body>
</html>

Rodney_H_

<?php // maybe try this... // ?>
<html>
<head>
<script language="JavaScript">
function emailvalidation(entered, alertbox)
{
	with (entered)
	{
		apos=value.indexOf("@");
		dotpos=value.lastIndexOf(".");
		lastpos=value.length-1;
		if (apos<1 || dotpos-apos<2 || lastpos-dotpos>3 || lastpos-dotpos<2)
		{
			if (alertbox) 
			{
				alert(alertbox);
			} 
			return false;
		}
		else 
		{
			return true;
		}
	}
} 

function emptyvalidation(entered, alertbox)
{
	with (entered)
	{
		if (value==null || value=="")
		{
			if (alertbox!="") 
			{
				alert(alertbox);
			} 
			return false;
		}
		else 
		{
			return true;
		}
	}
}

function formvalidation(thisform)
{
	with (thisform)
	{
		if (emptyvalidation(FullName,"Please enter your name")==false) {FullName.focus(); return false;};
		if (emptyvalidation(Subject,"Please enter a message")==false) {Suject.focus(); return false;};
		if (emailvalidation(Email,"Please enter a VALID email address")==false) {Email.focus(); return false;};
	}
}
</script>
</head>

<body>
<div class="boxcontent">
<h1>Thanks for your comment</h1>
<?php
// if the form has NOT been submitted:
if(!isset($_POST['submit']))
{
?>
<p>Send us a message, enter your information below and click &quot;Submit&quot;!</p>
<form method="post" action="" onSubmit="return formvalidation(this)">
<table id="Form-Details">
<tr>
	<td>Name:</td>
	<td><input type="text" name="name" size="20" /></td>
<tr/>
<tr>
	<td>Email:</td>
	<td><input type="text" name="email" size="20" /></td>
</tr>
<tr>
	<td>Message:</td>
	<td><textarea rows="6" name="message" cols="47" class="input"></textarea></td>
</tr>
<tr>
	<td>&nbsp;</td>
	<td class="right1"><input type="submit" name="submit" value="Submit" /><input type="reset" value="Reset" /></td>
</tr>
</table>
</form>
<?php
}

// else, process the posted form data:
else
{
	// declare values
	foreach($_POST as $key=>$value)
	{
		if(trim($value) == '')
		{
			$errors[] = $key;
		}
		else
		{
			$$key = trim($value);
		}
	}

if(isset($errors))
{
?>

<h2 class="error">Error!</h2>
<p>The following fields are still needed: <?php echo implode(', ', $errors); ?></p>
<p>Please try again:</p>
<form method="post" action="" onSubmit="return formvalidation(this)">
<table id="Form-Details">
<tr>
	<td>Name:</td>
	<td><input type="text" name="name" size="20" /></td>
<tr/>
<tr>
	<td>Email:</td>
	<td><input type="text" name="email" size="20" /></td>
</tr>
<tr>
	<td>Message:</td>
	<td><textarea rows="6" name="message" cols="47" class="input"></textarea></td>
</tr>
<tr>
	<td>&nbsp;</td>
	<td class="right1"><input type="submit" name="submit" value="Submit" /><input type="reset" value="Reset" /></td>
</tr>
</table>
</form>
<?php	
	} // .errors

// else no errors, the form was filled out properly, send email:
else
{
	// email parameters:
	$to = 'adrian_trythall@hotmail.com';
	$subject = 'Message submitted using Contact Us form';
	$message = "You have received a contact message:\r\n"
	."----------------------------------------------------------------\n"
	."Contact Name: ". $name . "\n"
	."Submitted: ".date ( 'l, F d Y g:i A',time()+240 )."\n"
	."From IP: ".$_SERVER['REMOTE_ADDR']."\n\n"
	."Message: ".$message."\n"
	."Form Address: ".$_SERVER['SERVER_NAME']." " .$_SERVER['REQUEST_URI'];
	$headers = "From: ".$name ."<".$email.">\r\n";
	$headers .= "Reply-To: ".$email."\r\n";
	$headers .= "X-Mailer: PHP/".phpversion();

	// send
	@mail($to, $subject, $message, $headers);
	echo "<h3>Message Sent!</h3>
	<p>Dear ".$name.",
	<br />
	<br />We will get back to you as soon as possible using ".$email;
}
}
?>
</div>

</body>
</html>

ade1982

Thanks. Unfortunately it doesn't quite work as I would hope

for instance, when you submit having only filled in the name field, it displays message

"you still need to enter email and message"

but doesn't keep the name in the name field, it just goes back to blank. If you then enter the email and message, but not the name, it says you need the name.

Thank you for your efforts though, and don't worry. It's only a weekend project.

Good Karma

Rodney_H_

You want the form to be "sticky".

There are several ways to do that.

Here is a very simple way:

<?php
// function to help keep the form "sticky" :
function makeSticky($var){

if(isset($_POST[$var]))
{
	return htmlspecialchars(trim($_POST[$var]));
}
}

// assign the form value to a variable:
$form = '<form method="post" action="" onSubmit="return formvalidation(this)">
<table id="Form-Details">
<tr>
    <td>Name:</td>
    <td><input type="text" name="name" size="20" value="'.makeSticky('name').'" /></td>
<tr/>
<tr>
    <td>Email:</td>
    <td><input type="text" name="email" size="20" value="'.makeSticky('email').'" /></td>
</tr>
<tr>
    <td>Message:</td>
    <td><textarea rows="6" name="message" cols="47" class="input">'.makeSticky('message').'</textarea></td>
</tr>
<tr>
    <td>&nbsp;</td>
    <td class="right1"><input type="submit" name="submit" value="Submit" /><input type="reset" value="Reset" /></td>
</tr>
</table>
</form>'."\n";

?>

<html>
<head>
<script language="JavaScript">
function emailvalidation(entered, alertbox)
{
    with (entered)
    {
        apos=value.indexOf("@");
        dotpos=value.lastIndexOf(".");
        lastpos=value.length-1;
        if (apos<1 || dotpos-apos<2 || lastpos-dotpos>3 || lastpos-dotpos<2)
        {
            if (alertbox)
            {
                alert(alertbox);
            }
            return false;
        }
        else
        {
            return true;
        }
    }
}

function emptyvalidation(entered, alertbox)
{
    with (entered)
    {
        if (value==null || value=="")
        {
            if (alertbox!="")
            {
                alert(alertbox);
            }
            return false;
        }
        else
        {
            return true;
        }
    }
}

function formvalidation(thisform)
{
    with (thisform)
    {
        if (emptyvalidation(FullName,"Please enter your name")==false) {FullName.focus(); return false;};
        if (emptyvalidation(Subject,"Please enter a message")==false) {Suject.focus(); return false;};
        if (emailvalidation(Email,"Please enter a VALID email address")==false) {Email.focus(); return false;};
    }
}
</script>
<style type="text/css">
body { font:12px Geneva, Arial, Helvetica, sans-serif; }
.error { color:#FF0000; }
</style>
</head>

<body>
<div class="boxcontent">
<h1>Thanks for your comment</h1>
<?php
// if the form has NOT been submitted:
if(!isset($_POST['submit']))
{
	echo $form;
}

// else, process the posted form data:
else
{
    // declare values
    foreach($_POST as $key=>$value)
    {
        if(trim($value) == '')
        {
            $errors[] = $key;
        }
        else
        {
            $$key = trim($value);
        }
    }

if(isset($errors))
{
?>
<h2 class="error">Error!</h2>
<p class="error">The following fields are still needed: 
	<strong><?php echo implode(', ', $errors); ?></strong></p>
<p class="error">Please try again:</p>
<?php
echo $form;
} // .errors

// else no errors, the form was filled out properly, send email:
else
{
    // email parameters:
    $to = 'adrian_trythall@hotmail.com';
    $subject = 'Message submitted using Contact Us form';
    $message = "You have received a contact message:\r\n"
    ."----------------------------------------------------------------\n"
    ."Contact Name: ". $name . "\n"
    ."Submitted: ".date ( 'l, F d Y g:i A',time()+240 )."\n"
    ."From IP: ".$_SERVER['REMOTE_ADDR']."\n\n"
    ."Message: ".$message."\n"
    ."Form Address: ".$_SERVER['SERVER_NAME']." " .$_SERVER['REQUEST_URI'];
    $headers = "From: ".$name ."<".$email.">\r\n";
    $headers .= "Reply-To: ".$email."\r\n";
    $headers .= "X-Mailer: PHP/".phpversion();

    // send
    @mail($to, $subject, $message, $headers);
    echo "<h3>Message Sent!</h3>
    <p>Dear ".$name.",
    <br />
    <br />We will get back to you as soon as possible using ".$email;
}
}
?>
</div>

</body>
</html>

ade1982

From this day forth my first son will be named Rodney 😃

Thank you!

bradgrafelman

ade1982 wrote:
From this day forth my first son will be named Rodney

In all of the compliments I've been given, no one's ever named a child after me... 😢

Anyway, don't forget to mark this thread resolved (if it is).

Rodney_H_

LOL..... I am honored, humbled and astonished.

Brad, my son is turning 16 next weekend...

I don't think I am going to have any more kids. Other wise, my kid's name would probably be as follows:

Brad Weedpacket Devinemke Thorpe Laserlight Halojoy Jason Bpat BuzzLY Elizabeth piersk Merve RogerR. Drakla Kudose (etc, etc, etc....)

(edit: not bad for "off the top o' me head, eh? )