Hit Counter Help.

TaylorTay

Hey yall, I am trying to write a hitcounter that writes to a txt file called hits.txt. I am also trying to makesure that the ip address is unique before it writes to the txt file. I am not able to get this working could any one tell me what is wrong with my code?

<?php
$ip = $_SERVER['REMOTE_ADDR'];
$unique = array_unique($ip);
if($unique)
{
$fp = fopen("hits.txt", "a+");
fwrite($fp, "$ip\n");
$new = fread($fp, filesize("counter.txt"));
$new++;
fclose($fp);
print("$new people have visited this page");
echo $ip;
}
?>

Installer

In this line:

$unique = array_unique($ip);

you're passing a scalar value to a function that takes an array. If you don't get an error message for that, it means you have error reporting turned off, at least partially. Not the best way to solve code problems.

Try using file() to put the file's lines into an array (e.g. "$file_array"), then check to see if "$ip" is in that array. You can set "$unique" to the value returned by "in_array($ip, $file_array)".

I'm stumped on this line:

$new = fread($fp, filesize("counter.txt"));

Why are you reading, from "hits.txt", the number of bytes in "counter.txt"? And how will that give you a count of site visitors?

If you count the elements in the array returned by "file()" you'll have the number of unique ip visitors.

TaylorTay

I am not entirly sure how to get the $ip into an array and then how to call it in the array_unique?

what do I put array_unique(HERE?);

Sorry I am new at this and I am a little confused.

Installer

Why are you insisting on using array_unique()?

Try something like this:

$ip = $_SERVER['REMOTE_ADDR'];
$file_arr = file('hits.txt');
foreach ($file_arr as $line) {
    $file_arr[$key] = trim($line);  // Remove newlines
}
$unique = in_array($ip, $file_arr);

or this:

$ip = $_SERVER['REMOTE_ADDR'];
$file_contents = file_get_contents('hits.txt');
$file_arr = explode("\n", $file_contents);
$unique = in_array($ip, $file_arr);

Then:

$total_ips = count($file_arr);
if ($unique) {
    $fp = fopen('hits.txt', 'a+');
    fwrite($fp, $ip . "\n");
    fclose($fp);
    $total_ips++;
}
echo $total_ips . ' people have visited this page<br />');
echo $ip;

TaylorTay

Thank you. You solved my problem I appreciate it.