[RESOLVED] Login system not working.

schwim

Hi there everyone,

I am in need of a very simply login system for my script(for the admin section), and I've found the following at codewalkers that I've attempted to implement, however, it's not working for me. When I attempt to log in, it loops back to the login form.

The errors I'm receiving seem to not have anything to do with the problem:

Notice: Undefined variable: action in /home/roughing/public_html/automonial/includes/login.php on line 7

Notice: Use of undefined constant login - assumed 'login' in /home/roughing/public_html/automonial/includes/login.php on line 7

Notice: Undefined variable: action in /home/roughing/public_html/automonial/includes/login.php on line 79

Line 7: if($action==login)(no quotes causing the error?)
Line 79: if($action=="")

I get the errors for line 7 even when the URL ends in: login.php?action=login

How would I begin to troubleshoot this? I've got error reporting on _ALL, hence the errors above, and I can see that a cookie isn't getting placed, but I don't know where to go from here.

thanks,
json

Installer

I'd troubleshoot that mess right off my hard drive and look around for another script.

devinemke

presumably the script you are using assumes that you have register_globals set to ON and you have it set to OFF. read up on Register Globals. change those to line to the following:

if ($_GET['action'] == 'login') {}
if ($_GET['action'] == '') {}

schwim

Ok, I got to thinking, and I've been chastised before that scripts written for reg_globals "on" would not work because you weren't defining the value, so I put the following at the top:

New line 7: $action = ($_POST['action']);

But I still get this error:

Notice: Undefined index: action in /home/roughing/public_html/automonial/includes/login.php on line 7

Which led me to remember that variables don't carry over into functions, so this might be my problem, but I can't seem to figure out where to make $action global.

How would I figure out where I need to place this, assuming of course that I'm even right that it's needed.

thanks,
json

schwim

aha! GET, not POST! I'll be right back 🙂

schwim

OK, the upside is that it went to the logging in page, then back to the index(where it was supposed to.

The downside is that the pages showed probably more than 30 errors during the two page refreshes, and at the end it asked me to log in again and no cookie was placed 🙂

Does anyone happen to know of a simple authorization script? I'm not savvy enough to troubleshoot this one, and Installer seems to think it's a steaming pile.

thanks,
json

Installer

I looked at all the scripts and it is that. It looks like, for one thing, it was developed with error_reporting off. Try this Google search.

Weedpacket

schwim wrote:
Notice: Undefined index: action in /home/roughing/public_html/automonial/includes/login.php on line 7

Well, you'd get that message if $POST['action'] (or $GET['action'], whichever it is you're trying to use) is not defined when you try to use it. All such variables should be checked for existence (using at least [man]isset[/man]) before even mentioning them anywhere else, and something suitable done instead if they don't exist.

Mistakes like that clearly mark the code as not ready for prime time....

schwim

Thanks very much for your reply weedpacket.

That was indeed the problem, but there are bunches more aside from that, so I'm not using it.

My problem is that the tutorials I'm finding are mostly advanced and many require modules that aren't standard, or later versions of PHP or MySQL.

I'm trying to write a script that will work on most any server, so I'm trying to find a simple login script that doesn't require these things. Unfortunately, the tutorias and code at Codewalkers are mostly like the one I was trying to use, out of date and poorly written(if I'm fixing stuff in it, it's REALLY bad).

Thank you guys very much for your time. I'm sorting through the Google results until I find something I can use.

thanks,
json

schwim

Well, I ended up using this one. I added the md5 encryption, and it seems to be working very well.

Thank you all very much for your help,
json

Weedpacket

schwim wrote:
later versions of PHP

How late are we talking about, here? The 4.3.x series has been around for nearly four years now and there's no excuse at all to be using anything older.

schwim

hehe, well up until 3 months ago, I was running 4.2.2 🙂

I was tied into a host that stated php could not be upgraded due to it being tied into Plesk, and I wasn't looking forward to moving 40+ domains.

My basic thinking is that what I'm writing is a stupid-simple script, and should not require any special stuff. I just didn't want to hobble a bunch of things together that require different things.

Wow, I didn't realize 4.3 was that old! I owned that server a lot longer than I thought!

thanks,
json