[RESOLVED] mysql_fetch_assoc not a valid resource

schwim

Hi there guys,

I'm trying to create a script that will edit user input, and I'm using the following when the edit page comes up:

$id=($_GET['id']);

$query = "SELECT * " .

"DATE_FORMAT(postdate, '%M %D, %Y') as date " .

"FROM testimonials WHERE id=$id";

    $result = mysql_query ($query);

while ($row = mysql_fetch_assoc ($result)) { <~~line 30

	  $date = $row['date'];

    $author = stripslashes ($row['author']);

	  $author_email = stripslashes ($row['author_email']);        
    $authorweb = stripslashes ($row['authorweb']);

    $authorwebname = stripslashes ($row['authorwebname']);

    $title = stripslashes ($row['title']);

    $testtext = stripslashes ($row['testtext']);

which nets me this error:

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in /my/path/to/edit.php on line 30

I've noted line 30 in the block of code above.

I'm using the same mysql call on another page, except instead of getting *, on the other page, I'm only grabbing a few values.

[EDIT] When clicking the link to edit.php, I can see that $id is getting a value placed in the URL.[/EDIT]

What would cause this problem?

thanks,
json

schwim

Is it because I'm only grabbing one result, and

while ($row = mysql_fetch_assoc ($result)) {

is only supposed to be used when you're grabbing multiple results?

If so, how should I write the mysql query?

thanks,
json

schwim

ok, I removed that line completely, and now the page is generating correctly without errors, but none of my values are getting passed to the form and attempting to echo a value results in nothing.

What should I use instead of this:

$author = stripslashes ($row['author']);

to define the variables?

thanks,
json

thorpe

Post your current code. The first error you posted indicated your query failed, try checking for success before using it.

schwim

Well, I got it to work using

$id=($_GET['id']);

 $result = mysql_query('SELECT * FROM testimonials WHERE id='.$id.'') or exit(mysql_error());

while ($row = mysql_fetch_assoc($result)) {

	  $date = $row['date'];

    $author = stripslashes ($row['author']);

	  $author_email = stripslashes ($row['author_email']);        
    $authorweb = stripslashes ($row['authorweb']);

    $authorwebname = stripslashes ($row['authorwebname']);

    $title = stripslashes ($row['title']);

    $testtext = stripslashes ($row['testtext']);

but it's a different way than I've been writing queries, as I had to (I guess) escape the $id variable in the query, or it wouldn't work.

Is this an ok way to write this? Is there another way to write it where I don't have to do that to the variable to make it work?

thanks,
json

ClarkF1

Don't use *

List the columns you need separated by commas including the DATE_FORMAT function and it should work

Using * is bad practice as it can waste time querying a database for unnecessary data

schwim

Thanks very much Clark. I edited all(I think ) of the queries to request only the items it needed.

thanks,
json