[RESOLVED] not outputting database query

Colin-uk

Hi,

I have a page that is created by various things from a database, the only thing is, it isnt outputting anything, or giving me any errors, the query is executed because I tested by outputting the results of mysql_affected_rows() so i really dont know what the problem is, here is my code:

<?php

include("inc/config.php");

$conn = mysql_connect("$db_host","$db_username","$db_password");
if (!$conn) die ("Could not connect MySQL");
mysql_select_db($db,$conn) or die ("Im sorry, there has been an error while connecting to the database, please contact the Administrator");

$result = mysql_query("SELECT * FROM systemconfig") or die(mysql_error());
$results_table = array();

while($row = mysql_fetch_array($result, MYSQL_ASSOC)){
  $results_table[$row['id']] = $row;
}

echo "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Strict//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd\">
<html xmlns=\"http://www.w3.org/1999/xhtml\" lang=\"en\" xml:lang=\"en\">
<head>
<title>".$results_table[3][value]." - ".$results_table[4][value]."</title>
<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />
<meta name=\"description\" content=\"".$results_table[5][value]."\" />
<meta name=\"keywords\" content=\"".$results_table[7][value]."\" />
<meta name=\"author\" content=\"".$results_table[8][value]."\" />
<link rel=\"stylesheet\" type=\"text/css\" href=\"style.css\" media=\"screen\" />";

?>

Im sure the syntax is correct otherwise it would give me php errors, wouldnt it?

any help would be much appreciated, ive been trying to solve this for hours..

Thanks
-Colin 🙂

ragedigital

Maybe I'm not understanding it, but what is "value" in this statement?

$results_table[3][value]

Can it not be:

$results_table[3]

Colin-uk

Thanks for the reply 🙂

"value" is the name of the field (column) that has the cells in it that i want to select

just using $results_table[3] would get the whole row (record) which isnt what i want to do

here is how my table looks in phpmyadmin

http://colin-uk.com/stuff/table.jpg

I just want to get the value in the 'value' column.

-Colin 🙂

ragedigital

Have you tried:

$results_table[3]["value"]

ClarkF1

Have you tried ['value'] instead

Colin-uk

ok, i just tried both of them and both of them dont seem to have done anything 😕

ragedigital

You already have $row set as an array, so you can also do this:

$row['metadesc']   //This equals your "This is the meta description."

It will also give a better description for you to fall back on.

Colin-uk

What would be the correct syntax for that?

I tried echoing:

<meta name=\"description\" content=\"$row['metadesc']\" />

and,

<meta name=\"description\" content=\"".$row['metadesc']."\" />

but it either does nothing or gives an error...

ragedigital

Change your echo statement and use single quotes, thay way you won't have to "escape" all the double-quotes.

Try this one line until it starts working:

echo '<meta name="description" content="'.$row['metadesc'].'">';

Colin-uk

ok so i tried it with this code:

<?php 

include("inc/config.php"); 

$conn = mysql_connect("$db_host","$db_username","$db_password"); 
if (!$conn) die ("Could not connect MySQL"); 
mysql_select_db($db,$conn) or die ("Im sorry, there has been an error while connecting to the database, please contact the Administrator"); 

$result = mysql_query("SELECT * FROM systemconfig") or die(mysql_error()); 
$results_table = array(); 

while($row = mysql_fetch_array($result, MYSQL_ASSOC)){ 
  $results_table[$row['id']] = $row; 
} 

echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> 
<html xmlns="http://www.w3.org/1999/xhtml" lang="en" xml:lang="en"> 
<head> 
<title>Title</title> 
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> 
<meta name="description" content="'.$row['metadesc'].'">
<meta name="keywords" content="" /> 
<meta name="author" content="" /> 
<link rel="stylesheet" type="text/css" href="css.css" media="screen" />
</head>
<body>
<div id="container">
<div id="header">
<div class="headtitle"></div>
</div>';
?>

and it didnt output anything, then i tried it with just this code:

<?php 

include("config.php"); 

$conn = mysql_connect("$db_host","$db_username","$db_password"); 
if (!$conn) die ("Could not connect MySQL"); 
mysql_select_db($db,$conn) or die ("Im sorry, there has been an error while connecting to the database, please contact the Administrator"); 

$result = mysql_query("SELECT * FROM systemconfig") or die(mysql_error()); 
$results_table = array(); 

while($row = mysql_fetch_array($result, MYSQL_ASSOC)){ 
  $results_table[$row['id']] = $row; 
} 

echo '<meta name="description" content="'.$row['metadesc'].'">';

?>

and it still didnt out put anything...

ClarkF1

I just created a database and inputted data based on the image you supplied.

I got the following output in the source code for the page using your original code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" lang="en" xml:lang="en">
<head>
<title>Sitename here - CMSname</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="description" content="This is the meta description" />
<meta name="keywords" content="these, are, the, meta, keywords" />
<meta name="author" content="Colin-uk dot com" />
<link rel="stylesheet" type="text/css" href="style.css" media="screen" />

However the page is blank, but if you go to the source code for the page in your browser - View -> Source - it's all filled in correctly. Check out the title for the page in your browser, it should say Sitename here - CMSname as expected

Colin-uk

Thats why i dont get it, its not outputting anything, im not getting anything in the content="" part of the meta description

heres what I get: http://www.colin-uk.com/test/phpmeta/test.php

and heres the source code im using: http://www.colin-uk.com/test/phpmeta/test.phps

Im really quite stumped as to why its not working...

ive even tried using a diffrent browser, clearing my cache / cookies / history to see if i get any diffrent results... and still no change :/

ClarkF1

Ignore the $row['metadesc'] code as it won't work due to the structure of the $results_table array.

The structure for that array is

array(9) {
  [1]=>
  array(3) {
    ["id"]=>
    string(1) "1"
    ["option"]=>
    string(9) "debugmode"
    ["value"]=>
    string(2) "no"
  }
  [2]=>
  array(3) {
    ["id"]=>
    string(1) "2"
    ["option"]=>
    string(11) "offlinemode"
    ["value"]=>
    string(2) "no"
  }
  [3]=>
  array(3) {
    ["id"]=>
    string(1) "3"
    ["option"]=>
    string(8) "sitename"
    ["value"]=>
    string(13) "Sitename here"
  }
  [4]=>
  array(3) {
    ["id"]=>
    string(1) "4"
    ["option"]=>
    string(7) "cmsname"
    ["value"]=>
    string(7) "CMSname"
  }
  [5]=>
  array(3) {
    ["id"]=>
    string(1) "5"
    ["option"]=>
    string(8) "metadesc"
    ["value"]=>
    string(28) "This is the meta description"
  }
  [6]=>
  array(3) {
    ["id"]=>
    string(1) "6"
    ["option"]=>
    string(9) "metatitle"
    ["value"]=>
    string(22) "This is the meta title"
  }
  [7]=>
  array(3) {
    ["id"]=>
    string(1) "7"
    ["option"]=>
    string(12) "metakeywords"
    ["value"]=>
    string(31) "these, are, the, meta, keywords"
  }
  [8]=>
  array(3) {
    ["id"]=>
    string(1) "8"
    ["option"]=>
    string(10) "metaauthor"
    ["value"]=>
    string(16) "Colin-uk dot com"
  }
  [9]=>
  array(3) {
    ["id"]=>
    string(1) "9"
    ["option"]=>
    string(8) "sidemenu"
    ["value"]=>
    string(2) "on"
  }
}

You had it right in the first place

Use your original code (from the original post) and it should work. Don't forget to change [value] to ['value'].

ragedigital

ClarkF1 wrote:
Ignore the $row['metadesc'] code as it won't work due to the structure of the $results_table array.

Why won't $row['metadesc'] work when he executes this line:

$row = mysql_fetch_array($result)

This is for my own understanding...

ClarkF1

It wouldn't work in this case as the field names in the database are id, option and value as shown in the image

So $row would have elements $row['id'], $row['option'] and $row['value']

Colin-uk

ClarkF1 wrote:
You had it right in the first place

Use your original code (from the original post) and it should work. Don't forget to change [value] to ['value'].

Ive tried that already, with no luck, still nothing outputted..

heres the generated page: http://www.colin-uk.com/test/phpmeta/orig/orig.php

heres the source: http://www.colin-uk.com/test/phpmeta/orig/orig.phps

Im starting to think it must be the server or something its on, if the code is ok and my browser isnt caching anything... i really cant think of what else it could be..

ClarkF1

Did you get any errors when inserting the data into the database.

When I was putting in the data into my copy it threw up an error because Option is a reserved word so you need to encase it with `s

e.g. "INSERT INTO systemconfig (id,option,value) VALUES ('5','metadesc','This is the meta description')"

It's a ` not ' (the key left of 1 on the keyboard)

What output do you get if you put print_r($row); into the while loop???

Colin-uk

I dont remember getting any errors entering the data... i think its because i used the `s first time though...

heres what i get when i put print_r($row); in the while loop

Array
(
    [ID] => 1
    [option] => debugmode
    [value] => no
)
Array
(
    [ID] => 2
    [option] => offlinemode
    [value] => no
)
Array
(
    [ID] => 3
    [option] => sitename
    [value] => Site name here
)
Array
(
    [ID] => 4
    [option] => cmsname
    [value] => CMSname
)
Array
(
    [ID] => 5
    [option] => metadesc
    [value] => This is the meta description
)
Array
(
    [ID] => 6
    [option] => metatitle
    [value] => This is the meta title
)
Array
(
    [ID] => 7
    [option] => metakeywords
    [value] => these, are, the, meta, keywords
)
Array
(
    [ID] => 8
    [option] => metaauthor
    [value] => Colin-uk dot com
)
Array
(
    [ID] => 9
    [option] => sidemenu
    [value] => on
)

ClarkF1

Try this. I've altered the array that the details get written into so it's more readable like the form that was suggested i.e. $results_table['metadesc']

If it doesn't work, put print_r($results_table) after the while loop and post the output

<?php

$conn = mysql_connect("$db_host","$db_username","$db_password");
if (!$conn) die ("Could not connect MySQL");
mysql_select_db($db,$conn) or die ("Im sorry, there has been an error while connecting to the database, please contact the Administrator");

$result = mysql_query("SELECT * FROM systemconfig") or die(mysql_error());
$results_table = array();

while($row = mysql_fetch_array($result, MYSQL_ASSOC)){
  $results_table[$row['option']] = $row['value'];
}

echo "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Strict//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd\">
<html xmlns=\"http://www.w3.org/1999/xhtml\" lang=\"en\" xml:lang=\"en\">
<head>
<title>".$results_table['sitename']." - ".$results_table['cmsname']."</title>
<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />
<meta name=\"description\" content=\"".$results_table['metadesc']."\" />
<meta name=\"keywords\" content=\"".$results_table['metakeywords']."\" />
<meta name=\"author\" content=\"".$results_table['metaauthor']."\" />
<link rel=\"stylesheet\" type=\"text/css\" href=\"style.css\" media=\"screen\" />";

?>

Colin-uk

omg, that worked! thanks so much! 😃

ive been pulling my hair out for days trying to get it to work, no idea why the original code didnt work

Heres the working page: http://www.colin-uk.com/test/phpmeta/newcode/newcode.php

Thanks again!